Audit Logging Plugin

beforeDelete, afterInsert, afterUpdate GORM event handlers not firing

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: Grails-AuditLogging 0.5.4
  • Labels:
    None
  • Environment:
    Plugin Version 0.5.2, Grails 1.2.2

Description

It looks like the plugin tries to add the PreDeleteEventListerer and others without affecting other listeners, but the events don't fire.

I put in a simple workaround to check for it, here is an example for AuditLogListener.onPostInsert() - put this towards the end of the method after audit logging has executed.

if (entity.metaClass.respondsTo(entity, 'afterInsert')) {
log.error "afterInsert exists on domain Class $

{event.getEntity().getClass().getName()}

. Calling it"
entity.afterInsert()
}

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. GPAUDITLOGGING-9 audit-logging breaks deletes in grails 1.3.X (grails hibernate-plugin 1.3X)

  • Critical - Crashes, loss of data, severe memory leak.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Improvement - An improvement or enhancement to an existing feature or task. GRAILS-5725 Allow plugins to easily insert hibernate event listeners

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Shawn Hartsock added a comment -

I'll schedule this fix for the next point release.

Show
Shawn Hartsock added a comment - I'll schedule this fix for the next point release.
Hide
Permalink
Jean Barmash added a comment -

Uploaded the corrected file.

Implemented a new method that I am using in several places.

I believe the in GORM spec you can implement GORM events in several ways, but 1.2.x recommends to implement them as methods, so that's what I am handling here.

Show
Jean Barmash added a comment - Uploaded the corrected file. Implemented a new method that I am using in several places. I believe the in GORM spec you can implement GORM events in several ways, but 1.2.x recommends to implement them as methods, so that's what I am handling here.
Hide
Permalink
Shawn Hartsock added a comment -

This is not as clear cut as you would believe.

1) I am injecting my listener into the array of existing listeners. If the other listeners are functioning properly then this change will cause the events to fire twice
2) future GORM changes will change the method by which listeners are registered see: http://jira.codehaus.org/browse/GRAILS-5725

Show
Shawn Hartsock added a comment - This is not as clear cut as you would believe. 1) I am injecting my listener into the array of existing listeners. If the other listeners are functioning properly then this change will cause the events to fire twice 2) future GORM changes will change the method by which listeners are registered see: http://jira.codehaus.org/browse/GRAILS-5725
Hide
Permalink
Jean Barmash added a comment - - edited

Shawn,

Thanks for taking a look. When looking at this originally, I saw that you were injecting the listener into the array of others, and I would expect them to fire. Not understanding that mechanism fully, I figured that there is some other underlying bug. Anyway, the events are not firing for me, which is why I needed a workaround. With the patch I created, they are firing for me once only.

I am not sure why - but I tested it in a simple application and when audit-logging plugin is enabled, event handlers are not firing. When disabled, they do.

Are event handlers in question working for you when defined and audit-logging installed?

I am using Grails 1.2.2.

Show
Jean Barmash added a comment - - edited Shawn, Thanks for taking a look. When looking at this originally, I saw that you were injecting the listener into the array of others, and I would expect them to fire. Not understanding that mechanism fully, I figured that there is some other underlying bug. Anyway, the events are not firing for me, which is why I needed a workaround. With the patch I created, they are firing for me once only. I am not sure why - but I tested it in a simple application and when audit-logging plugin is enabled, event handlers are not firing. When disabled, they do. Are event handlers in question working for you when defined and audit-logging installed? I am using Grails 1.2.2.
Hide
Permalink
Shawn Hartsock added a comment -

I did not create tests cases around this before hand. That was a mistake of mine I'll have to fix. I keep a few fake projects around to test install, upgrade, and performance of the Audit Logging plugin when used with various databases and other plugins. I can't test all possible combinations exhaustively but I think your test is one that deserves special attention.

Because of how this fix will inter-operate with the rest of the system I may opt to wait for GRAILS-5725 to get fixed before fixing this. I'm not sure. When GRAILS-5725 is finally fixed it will break backwards compatibility for this plugin.

I won't be able to make this change as lightly or as quickly as I originally though I would.

Show
Shawn Hartsock added a comment - I did not create tests cases around this before hand. That was a mistake of mine I'll have to fix. I keep a few fake projects around to test install, upgrade, and performance of the Audit Logging plugin when used with various databases and other plugins. I can't test all possible combinations exhaustively but I think your test is one that deserves special attention. Because of how this fix will inter-operate with the rest of the system I may opt to wait for GRAILS-5725 to get fixed before fixing this. I'm not sure. When GRAILS-5725 is finally fixed it will break backwards compatibility for this plugin. I won't be able to make this change as lightly or as quickly as I originally though I would.
Hide
Permalink
Shawn Hartsock added a comment -

auditable should not evict other event handlers

Show
Shawn Hartsock added a comment - auditable should not evict other event handlers
Hide
Permalink
Shawn Hartsock added a comment -

I'll roll this fix in with release 0.5.4

Show
Shawn Hartsock added a comment - I'll roll this fix in with release 0.5.4
Hide
Permalink
Shawn Hartsock added a comment -

This fix is committed to the trunk now. It will go out with the next release.

Show
Shawn Hartsock added a comment - This fix is committed to the trunk now. It will go out with the next release.

People

  • Assignee:
    Shawn Hartsock
    Reporter:
    Jean Barmash
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
30m
Original Estimate - 30 minutes
Remaining:
30m
Remaining Estimate - 30 minutes
Logged:
Not Specified
Time Spent - Not Specified