Ckeditor Plugin

uiColor Config parameters is not allowed

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 0.6
  • Fix Version/s: 3.3.2
  • Component/s: None
  • Labels:
    None

Description

Allow setting the UI Color of the CKEditor. This setting is known as 'uiColor' for ckeditor config.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Fabien Benichou added a comment -

Also, why do we need to check for ALLOWED_CONFIG_ITEMS ? It means that every new (or missed) configuration options of ckeditor will require a new version of the plugin.
I think that we should allow the developer to choose whether or not he wants to check for allowed configuration items (through a config flag for instance).

Show
Fabien Benichou added a comment - Also, why do we need to check for ALLOWED_CONFIG_ITEMS ? It means that every new (or missed) configuration options of ckeditor will require a new version of the plugin. I think that we should allow the developer to choose whether or not he wants to check for allowed configuration items (through a config flag for instance).
Hide
Permalink
Stefano Gualdi added a comment -

Hi Fabien,

thank you for the patch.

The ALLOWED_CONFIG_ITEMS check is there to show a meaningful message to the user.

In a lot of cases, if wrongly configured, Ckeditor does not render on the page and this can be confusing for the user.

Show
Stefano Gualdi added a comment - Hi Fabien, thank you for the patch. The ALLOWED_CONFIG_ITEMS check is there to show a meaningful message to the user. In a lot of cases, if wrongly configured, Ckeditor does not render on the page and this can be confusing for the user.
Hide
Permalink
Fabien Benichou added a comment -

No problem. Yes I understand why the ALLOWED_CONFIG_ITEMS is there but I suggest to allow developer to choose whether or not he wants to use this pre-check. Because in case he wants to use a configuration option that is not yet supported by the plugin, then he can switch to the "uncheck" mode.

Show
Fabien Benichou added a comment - No problem. Yes I understand why the ALLOWED_CONFIG_ITEMS is there but I suggest to allow developer to choose whether or not he wants to use this pre-check. Because in case he wants to use a configuration option that is not yet supported by the plugin, then he can switch to the "uncheck" mode.
Hide
Permalink
Stefano Gualdi added a comment -

Ok, please raise another jira for this improvement.

I'll give a look for the next version.

Show
Stefano Gualdi added a comment - Ok, please raise another jira for this improvement. I'll give a look for the next version.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.1#660-r161644) | Report a problem
Powered by a free Atlassian JIRA open source license for Grails project. Try JIRA - bug tracking software for your team.