Dojo Plugin

ContentPane tag don't use attribute "id"

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.7.2.0
  • Labels:
    None

Description

ContentPane tag remove id attribute from map but never inject it into the output.

def contentPane = {attrs, body ->
def id = attrs.remove("id") ?: "dojo_ui_dialog$

{Util.randomId()}

"
....
}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Robert A Meidal added a comment -

Thanks for finding this. I had switched the code in other places to preserve the id for loading a grails action and then using the name parameter for the DOM id... but I missed this one.

-Rob

Show
Robert A Meidal added a comment - Thanks for finding this. I had switched the code in other places to preserve the id for loading a grails action and then using the name parameter for the DOM id... but I missed this one. -Rob
Hide
Permalink
Robert A Meidal added a comment -

Found that this was code submitted by a pull request. I will fix it but I would recommend using a <dojo:frame> as it has more features like containLinks="true".

  • Rob
Show
Robert A Meidal added a comment - Found that this was code submitted by a pull request. I will fix it but I would recommend using a <dojo:frame> as it has more features like containLinks="true". Rob
Hide
Permalink
Robert A Meidal added a comment -

This has been fixed and added to version 1.7.2.0.

  • Rob
Show
Robert A Meidal added a comment - This has been fixed and added to version 1.7.2.0. Rob

People

  • Assignee:
    Robert A Meidal
    Reporter:
    jorge
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: