Grails Scaffolding Plugin

Scaffolding Controller template not used in Dynamic Scaffolding

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Labels:
    None
  • Environment:
    Windows XP
    Java JDK 1.6.0_04
    Grails 1.0.1
  • Testcase included:
    yes

Description

When using Dynamic Scaffolding (def scaffold = true;), the Controller scaffolding template found in src/templates/scaffolding/Controller.groovy is not used. This template IS used when performing grails generate-controller. And the View templates in this folder ARE used with Dynamic Scaffolding. This prevents mass customization of Controllers through Dynamic Scaffolding. It also breaks the expectations of the user; one works and one doesn't.

Attached an example project, where an attempt is made to add a 'Cancel' action and selection to scaffolded Controllers and Views. Files of note:

grails-app/controllers/SomeObjectController.groovy Dynamic Scaffold Controller for SomeObject Domain Class
src/templates/scaffolding/Controller.groovy Expected template for Dynamic Scaffold Controllers; added cancel action
src/templates/scaffolding/create.gsp Added a Cancel button
src/templates/scaffolding/edit.gsp Added a Cancel button

Running this project, both the Create and Edit views include the Cancel button added to the create.gsp and edit.gsp templates. But attempting to select either Cancel button results in the following Runtime Exception:
org.codehaus.groovy.grails.web.servlet.mvc.exceptions.UnknownControllerException: No controller found for URI [/someObject/cancel]!

The included test (grails test-app SomeObjectController) also fails. Both functionalities work if the Controller and Views are generated (grails generate-all SomeObject). This confirms that the cancel action added to the Controller template is not being included in the Dynamic Scaffolding, as expected.

Issue Links

relates to

Sub-task - The sub-task of the issue GPSCAFFOLD-20 View Template Files - Dynamic Identification

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Graeme Rocher added a comment -

This is a large issue and I prefer to not introduce such a big change in a point release

Show
Graeme Rocher added a comment - This is a large issue and I prefer to not introduce such a big change in a point release
Hide
Permalink
Marcel Overdijk added a comment -

I totally agree. Good to see the scaffolding pluggability and extensibility is a candidate for 1.1.
This morning I already started a thread about it on the dev mailing list.

Show
Marcel Overdijk added a comment - I totally agree. Good to see the scaffolding pluggability and extensibility is a candidate for 1.1. This morning I already started a thread about it on the dev mailing list.
Hide
Permalink
Graeme Rocher added a comment -

Reduced priority of non critical issues which have current workarounds

Show
Graeme Rocher added a comment - Reduced priority of non critical issues which have current workarounds
Hide
Permalink
Marcel Overdijk added a comment -

Hope this issue won't be forgotten due to lowering the priority.

I think it's still annoying that - when changing the templates - the generate commands behave differently then the dynamic scaffold property.

Show
Marcel Overdijk added a comment - Hope this issue won't be forgotten due to lowering the priority. I think it's still annoying that - when changing the templates - the generate commands behave differently then the dynamic scaffold property.
Hide
Permalink
Rob Hunter added a comment -

I assume the work around is simply the regeneration of controllers. I too hope this won't be forgotten with the lowering of priorities. Is a fix likely in the 1.1 release.

Show
Rob Hunter added a comment - I assume the work around is simply the regeneration of controllers. I too hope this won't be forgotten with the lowering of priorities. Is a fix likely in the 1.1 release.
Hide
Permalink
Marcel Overdijk added a comment -

Yes the wourkaround is to use the static scaffolding using the generate-* commands.

6 voters already for this issue so I have the feeling a lot of uses think this feature isimportant.

Show
Marcel Overdijk added a comment - Yes the wourkaround is to use the static scaffolding using the generate-* commands. 6 voters already for this issue so I have the feeling a lot of uses think this feature isimportant.
Hide
Permalink
Les Martin added a comment -

I think that this is a must. Up until running into this little twig all my Grails research was going smooth, but this is confusing to most users since when you generate templates you can update other dynamic scaffolding options (via the views).

+1 to make this into the 1.1 since I can't vote again

Show
Les Martin added a comment - I think that this is a must. Up until running into this little twig all my Grails research was going smooth, but this is confusing to most users since when you generate templates you can update other dynamic scaffolding options (via the views). +1 to make this into the 1.1 since I can't vote again

People

  • Assignee:
    Burt Beckwith
    Reporter:
    Justin Michalczak
Vote (11)
Watch (9)

Dates

  • Created:
    Updated:
    Resolved: