Details
-
Type:
Bug
-
Status:
Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 0.6
-
Component/s: None
-
Labels:None
-
Environment:Grails 1.1, Searchable 0.5.3
Description
We have noticed in a couple of projects that objects updated via
GORM are not automatically reindexed. However, objects created
(save()) are reindexed.
In https://svn.codehaus.org/grails-plugins/grails-searchable/trunk/src/conf/Searchable.groovy,
the following is stated:
/**
* Should changes made through GORM/Hibernate be mirrored to the index
* automatically (using Compass::GPS)?
*
* If false, you must manage the index manually using index/unindex/reindex
*/
mirrorChanges = true
But that doesn't work for us. We have to manually call domainObject.reindex()
A similar problem/workaround was posted to this list:
http://www.nabble.com/searchable-plugin%2C-missing-component-from-lucene-doc--td21067300.html
Issue Links
| This issue is duplicated by: | ||||
| GPSEARCHABLE-55 | Indexing only on application startup |
|
|
|
Activity
I have been experiencing the same issue using searchable 0.5.5. I have investigated the issue tracing through the source code and have found the issue to be in the following class/method.
class HibernateEventListenerUtils {
...
public static void persistPending(CompassSession session, Object entity, Map<Object, Collection> pendingMap, boolean create) {
for (Iterator iter = pendingMap.keySet().iterator(); iter.hasNext()
{
Object pending = iter.next();
Collection dependencies = pendingMap.get(pending);
if (dependencies.remove(entity)) {
if (dependencies.isEmpty()) {
if (create) {
session.create(pending);
} else {
session.save(pending);
}
iter.remove();
}
}
}
}
...
}
From reading where this code is called from and the parameters passed it seems that the following line will never be true :-
if (dependencies.remove(entity))
this seems to be checking that the key from the map is in the values of the map for that key, this will never be the case resulting in the pending objects never being saved (lucene index).
Reading the original source i struggled to understand what it was trying to do, I thought it was trying to remove all the dependencies form the entity then save that entity but when i corrected the code to do this it resulted in a hibernate concurrent exception. I then changed it to just save each entity that was in the key of the map and this seemed to work, i checked and also the dependencies are also saved/updated in the lucene index. This works for me but i presume there is a reason for trying to remove the dependencies, otherwise the entity would just be saved in place in the HibernateEventListener. The updated method is shown below, please could you look at this and see if there are any issues that we haven't yet found.
public static void persistPending(CompassSession session, Object entity, Map<Object, Collection> pendingMap, boolean create) {
// Iterate around all the entities in the map and save/update them
for (Iterator iter = pendingMap.keySet().iterator(); iter.hasNext() {
Object pending = iter.next();
if (create) {
session.create(pending);
} else {
session.save(pending);
}
}
}
Thanks
Daniel Lees
{
Object pending = iter.next();
Collection dependencies = pendingMap.get(pending);
if (dependencies.remove(entity)) {
if (dependencies.isEmpty()) {
if (create) {
session.create(pending);
} else {
session.save(pending);
}
iter.remove();
}
}
}
}
...
}
From reading where this code is called from and the parameters passed it seems that the following line will never be true :-
if (dependencies.remove(entity))
this seems to be checking that the key from the map is in the values of the map for that key, this will never be the case resulting in the pending objects never being saved (lucene index).
Reading the original source i struggled to understand what it was trying to do, I thought it was trying to remove all the dependencies form the entity then save that entity but when i corrected the code to do this it resulted in a hibernate concurrent exception. I then changed it to just save each entity that was in the key of the map and this seemed to work, i checked and also the dependencies are also saved/updated in the lucene index. This works for me but i presume there is a reason for trying to remove the dependencies, otherwise the entity would just be saved in place in the HibernateEventListener. The updated method is shown below, please could you look at this and see if there are any issues that we haven't yet found.
public static void persistPending(CompassSession session, Object entity, Map<Object, Collection> pendingMap, boolean create) {
// Iterate around all the entities in the map and save/update them
for (Iterator iter = pendingMap.keySet().iterator(); iter.hasNext() {
Object pending = iter.next();
if (create) {
session.create(pending);
} else {
session.save(pending);
}
}
}
Thanks
Daniel Lees
Hi all, we have similar issues in searchable 0.5.4.