UI Plugin

DataTable: recursion error in grailsui when using prototype

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 1.2
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

Upgraded to Grails-UI-1.1-SNAPSHOT and after that, I got the following error in my firebug console:

too much recursion
http://10.0.0.100:8082/AdminTool/plugins/grails-ui-1.1-SNAPSHOT/js/grailsui/grailsui.js
Line 48

I traced it down to the function: GRAILSUI.util.replaceDateStringsWithRealDates = function(inputData), where it seems that when iterating through data to find Date objects, recursion continues into functions as well. I have made a small patch (attached) which solved this problem by avoiding recursion when the next element is a function, thus not copying functions to the new data array.

Hope this patch will do.

Issue Links

Activity

Hide
Matthew Taylor added a comment -

thank you very much.

Show
Matthew Taylor added a comment - thank you very much.
Hide
Søren Berg Glasius added a comment -

Fixed with the patch and comited to trunk

Show
Søren Berg Glasius added a comment - Fixed with the patch and comited to trunk

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: