Grails

Redirect Fails on Multi-Part File Upload

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-RC1
  • Fix Version/s: 1.0-RC3
  • Component/s: None
  • Labels:
    None

Description

After completing a multi-part file upload, I attempt to perform a redirect. At this point the code fails. It appears as if the request is being processed twice. Since the file has already been read from the request the following error results:

org.springframework.web.multipart.MultipartException: Could not parse multipart servlet request; nested exception is org.apache.commons.fileupload.FileUploadBase$UnknownSizeException: the request was rejected because its size is unknown

An example application illustrating the issue is attached.

  1. File
    bug-app.tgz
    03/Dec/07 8:40 AM
    125 kB
    Scott Delap
  2. GZip Archive
    GRAILS-1938.tar.gz
    04/Dec/07 3:00 PM
    143 kB
    Valdemar Mejstad

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Graeme Rocher added a comment -

Hmm your application works fine for me have you tried the RC2 release? What platform are you on?

Show
Graeme Rocher added a comment - Hmm your application works fine for me have you tried the RC2 release? What platform are you on?
Hide
Permalink
Domingo Suárez Torres added a comment -

I´m using RC2 with WebFlow and the error persist

Show
Domingo Suárez Torres added a comment - I´m using RC2 with WebFlow and the error persist
Hide
Permalink
Valdemar Mejstad added a comment -

I also see this after upgrading my grails-application to RC2 on OSX Leopard.

Show
Valdemar Mejstad added a comment - I also see this after upgrading my grails-application to RC2 on OSX Leopard.
Hide
Permalink
Graeme Rocher added a comment -

Can one of you two post an app that reproduces the problem, because for me the problem doesn't occur with the current attached sample app

Show
Graeme Rocher added a comment - Can one of you two post an app that reproduces the problem, because for me the problem doesn't occur with the current attached sample app
Hide
Permalink
Valdemar Mejstad added a comment -

I attached a sample application.

I also did some further investigation and found that the exception only occurs when trying to upload files using Safari (v3, haven't tested earlier versions).

Uploading files with Firefox works!

Show
Valdemar Mejstad added a comment - I attached a sample application. I also did some further investigation and found that the exception only occurs when trying to upload files using Safari (v3, haven't tested earlier versions). Uploading files with Firefox works!
Hide
Permalink
Scott Delap added a comment -

Never thought of just checking Safari as the issue. Still odd.

Show
Scott Delap added a comment - Never thought of just checking Safari as the issue. Still odd.
Hide
Permalink
Graeme Rocher added a comment -

Hmm ok now that gives me something to go on. I'll investigate again. Thanks

Show
Graeme Rocher added a comment - Hmm ok now that gives me something to go on. I'll investigate again. Thanks
Hide
Permalink
Graeme Rocher added a comment -

This bug is interesting in that I am sure it is a Safari bug. Safari seems to include the multipi part request bit in the redirect, but ommits the Content-Length header. The first request headers look like:

Cache-Control: max-age=0
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
Accept-Language: en-us
Accept-Encoding: gzip, deflate
Cookie: JSESSIONID=ix592wxv5oef
Connection: keep-alive
Host: localhost:8080
Referer: http://localhost:8080/bug-app/person/uploadFile
Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryV1eAxa6ilWxQ64K4
Content-Length: 15845

Whilst the redirect request headers look like:

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-us) AppleWebKit/523.10.3 (KHTML, like Gecko) Version/3.0.4 Safari/523.10
Cache-Control: max-age=0
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
Accept-Language: en-us
Accept-Encoding: gzip, deflate
Cookie: JSESSIONID=ix592wxv5oef
Connection: keep-alive
Host: localhost:8080
Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryV1eAxa6ilWxQ64K4

With no Content-Length header present. Guess we'll have to work round it somehow

Show
Graeme Rocher added a comment - This bug is interesting in that I am sure it is a Safari bug. Safari seems to include the multipi part request bit in the redirect, but ommits the Content-Length header. The first request headers look like: Cache-Control: max-age=0 Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5 Accept-Language: en-us Accept-Encoding: gzip, deflate Cookie: JSESSIONID=ix592wxv5oef Connection: keep-alive Host: localhost:8080 Referer: http: //localhost:8080/bug-app/person/uploadFile Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryV1eAxa6ilWxQ64K4 Content-Length: 15845 Whilst the redirect request headers look like: User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-us) AppleWebKit/523.10.3 (KHTML, like Gecko) Version/3.0.4 Safari/523.10 Cache-Control: max-age=0 Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5 Accept-Language: en-us Accept-Encoding: gzip, deflate Cookie: JSESSIONID=ix592wxv5oef Connection: keep-alive Host: localhost:8080 Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryV1eAxa6ilWxQ64K4 With no Content-Length header present. Guess we'll have to work round it somehow
Hide
Permalink
Marc Palmer added a comment -

Is this the same bug that JIRA and other applications suffer from with Safari 3? There is a known issue with redirects in Safari

Show
Marc Palmer added a comment - Is this the same bug that JIRA and other applications suffer from with Safari 3? There is a known issue with redirects in Safari

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Scott Delap
Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: