Grails

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0-RC4
• Fix Version/s: 1.0-RC4
• Component/s: Persistence
• Labels:

  None

The constraints added in a subclass are are ignored in save() and validate()

class Parent {
   static constraints = {
        prop1(nullable: false, blank: false)
   }

   String prop1
}

class Child extends Parent {
   static constraints = {
      other(nullable: true)
   }

   Other other
}

class Other {
   String prop
}

void testSubClassConstraints() {
        def second = new Second()
        second.prop1 = "Property 1"

        def valid = second.validate()
        def errors = second.errors

        // both will fail
        assert valid 
        assert errors.errorCount == 0
    }

The Problem is, that in ConstraintsEvaluatingDynamicProperty.java, line 86, the constraints-Closure is received through a call to GrailsClassUtils.getStaticPropertyValue(..), which again tries to get the getter for the constraint-property, invokes it and returns the value.

However, the getter-Method whicht should be Child.getConstraints() is never found - instead Parent.getConstraints() is returned which results in a duplicate instantiation of the validators defined in Parent.constraints. Child.contraints ist never processed.

The attached zip-File contains a Grails-Bugreport containing the same Code as above.

1. $i18n.getText("admin.common.words.hide")

   

   TestProject-bug-report-26122007.zip

   26/Dec/07 7:12 AM

   14 kB

   Christian Laakmann

   1. 
      grails-app/conf/BootStrap.groovy 0.1 kB
   2. 
      grails-app/conf/Config.groovy 3 kB
   3. 
      grails-app/conf/DataSource.groovy 0.6 kB
   4. 
      grails-app/conf/UrlMappings.groovy 0.2 kB
   5. 
      grails-app/conf/spring/resources.xml 0.3 kB
   6. 
      grails-app/domain/First.groovy 0.1 kB
   7. 
      grails-app/domain/Other.groovy 0.0 kB
   8. 
      grails-app/domain/Second.groovy 0.3 kB
   9. 
      grails-app/i18n/messages.properties 2 kB
   10. 
       grails-app/i18n/messages_de.properties 3 kB
   11. 
       grails-app/i18n/messages_es.properties 3 kB
   12. 
       grails-app/i18n/messages_fr.properties 2 kB
   13. 
       grails-app/i18n/messages_it.properties 2 kB
   14. 
       grails-app/i18n/messages_ja.properties 2 kB
   15. 
       grails-app/i18n/messages_nl.properties 3 kB
   16. 
       grails-app/i18n/messages_ru.properties 4 kB
   17. 
       grails-app/i18n/messages_th.properties 5 kB
   18. 
       grails-app/.../messages_zh_CN.properties 2 kB
   19. 
       grails-app/views/error.gsp 1 kB
   20. 
       grails-app/views/layouts/main.gsp 0.7 kB
   21. 
       test/integration/ConstraintTests.groovy 0.4 kB
   22. 
       test/reports/TEST-ConstraintTests.xml 0.5 kB
   23. 
       test/reports/.../TEST-ConstraintTests.txt 0.4 kB

   Download Zip

   $i18n.getText("admin.common.words.show")

   

   TestProject-bug-report-26122007.zip

   26/Dec/07 7:12 AM

   14 kB

   Christian Laakmann

• Assignee:

  Graeme Rocher

  Reporter:

  Christian Laakmann

• Created:

  26/Dec/07 7:12 AM

  Updated:

  18/May/11 3:16 PM

  Resolved:

  10/Jan/08 10:22 AM