Grails

grails-app/i18n/messages.properties is not being read

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.2
  • Fix Version/s: 0.2.1
  • Component/s: Project infrastructure
  • Labels:
    None
  • Environment:
    Ubuntu 6.06, Java 1.5

Description

1. Capture a system call level trace such as this during a grails app runtime instance

$ strace -f -o run.trace grails run-app # Linux system call trace, following children with -f

and then load a page that uses, e.g., <g:message> tag. It is revealed that i18n/messages.properties is stat'd but never actually opened or read. A consequence is that properties defined in the message bundle are silently unavailable to the application.

2. Proving the messages file is stat'd by the OS:

$ egrep '^[0-9]+ stat.*tmp.*i18n/messages\.properties' run.trace
12590 stat64("/home/petrovic/Projects/TeachersP/tmp/war/WEB-INF/grails-app/i18n/messages.properties",

{st_mode=S_IFREG|0644, st_size=2167, ...}) = 0
12590 stat64("/home/petrovic/Projects/TeachersP/tmp/war/WEB-INF/grails-app/i18n/messages.properties", {st_mode=S_IFREG|0644, st_size=2167, ...}

) = 0
...

3. Proving the message file is never read by the OS, by proving it is never open'd:

$ egrep '^[0-9]+ open.*tmp.*i18n/messages\.properties' run.trace

which produces no output.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mark Petrovic added a comment -

I'm currently examining this bit of configuration, printed to stdout at runtime

[groovy] <bean
[groovy] class="org.springframework.context.support.ReloadableResourceBundleMessageSourc
e" id="messageSource">
[groovy] <property name="basename">
[groovy] <value>WEB-INF/classes/grails-app/i18n/messages</value>
[groovy] </property>
[groovy] </bean>

wondering if the <value> element should read

<value>WEB-INF/grails-app/i18n/messages</value>

Where is the Spring template config such that I can change and test??

Show
Mark Petrovic added a comment - I'm currently examining this bit of configuration, printed to stdout at runtime [groovy] <bean [groovy] class="org.springframework.context.support.ReloadableResourceBundleMessageSourc e" id="messageSource"> [groovy] <property name="basename"> [groovy] <value>WEB-INF/classes/grails-app/i18n/messages</value> [groovy] </property> [groovy] </bean> wondering if the <value> element should read <value>WEB-INF/grails-app/i18n/messages</value> Where is the Spring template config such that I can change and test??
Hide
Permalink
Mark Petrovic added a comment -

That seems to have been the problem. I tweaked

grails/src/commons/org/codehaus/groovy/grails/commons/spring/SpringConfig.java

recompiled, reran the app, and now the resources are found.

Show
Mark Petrovic added a comment - That seems to have been the problem. I tweaked grails/src/commons/org/codehaus/groovy/grails/commons/spring/SpringConfig.java recompiled, reran the app, and now the resources are found.
Hide
Permalink
Graeme Rocher added a comment -

Excellent. Please feel free to attach a patch. Thanks for all the investigative work!

Show
Graeme Rocher added a comment - Excellent. Please feel free to attach a patch. Thanks for all the investigative work!
Hide
Permalink
Mark Petrovic added a comment -

Patch attached.

Apply using

$ patch ./grails/src/commons/org/codehaus/groovy/grails/commons/spring/SpringConfig.java messageSource.patch

Show
Mark Petrovic added a comment - Patch attached. Apply using $ patch ./grails/src/commons/org/codehaus/groovy/grails/commons/spring/SpringConfig.java messageSource.patch
Hide
Permalink
Mark Petrovic added a comment -

For posterity and accuracy:

#2 does not prove my point as I reported it. I dont' know what process wanted to know specifically about the message file in /home/petrovic/Projects/TeachersP/tmp/war/WEB-INF/grails-app/i18n/messages.properties. But it wasn't the process I was actually indicting. That process was truncated when I neglected to post the entire output of egrep.

Here is the line proving the mis-named properties file was sought

12621 stat64("/home/petrovic/Projects/TeachersP/tmp/war/WEB-INF/classes/grails-app/i18n/messages.properties", <unfinished ...>

and that is not yet finished executing.

Ultimately, it was the lack of "open()" on the message file that proves the point.

Ergo, same result, but for different reasons.

Show
Mark Petrovic added a comment - For posterity and accuracy: #2 does not prove my point as I reported it. I dont' know what process wanted to know specifically about the message file in /home/petrovic/Projects/TeachersP/tmp/war/WEB-INF/grails-app/i18n/messages.properties. But it wasn't the process I was actually indicting. That process was truncated when I neglected to post the entire output of egrep. Here is the line proving the mis-named properties file was sought 12621 stat64("/home/petrovic/Projects/TeachersP/tmp/war/WEB-INF/classes/grails-app/i18n/messages.properties", <unfinished ...> and that is not yet finished executing. Ultimately, it was the lack of "open()" on the message file that proves the point. Ergo, same result, but for different reasons.
Hide
Permalink
Graeme Rocher added a comment -

Fixed in class GrailsRuntimeConfigurator (http://svn.grails.codehaus.org/browse/grails/trunk/grails/src/commons/org/codehaus/groovy/grails/commons/spring/GrailsRuntimeConfigurator.java??r=HEAD) during the refactoring of SpringConfig

Show
Graeme Rocher added a comment - Fixed in class GrailsRuntimeConfigurator ( http://svn.grails.codehaus.org/browse/grails/trunk/grails/src/commons/org/codehaus/groovy/grails/commons/spring/GrailsRuntimeConfigurator.java??r=HEAD ) during the refactoring of SpringConfig

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Mark Petrovic
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: