Grails

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.1
• Fix Version/s: 1.0.1
• Component/s: TagLib, Testing
• Labels:

  None

The attached patch brings the test coverage to 100% for GroovyIfTag#doStartTag. The additional tests in the patch address the two cases not covered in the current tests.

The patch also offers refactorings for the #doStartTag implementation. These refactorings use method extraction to reduce repetition. They also cut the amount of conditional logic in half.

–

Note: The test improvements (in CoreTagsTests.groovy) are independent of the refactorings (in GroovyIfTag.java). In case the team disagrees with the refactorings, the additional test cases can still be applied to offer increased test coverage for the existing code base.

1. 

   increase_coverage_and_maintainability_for_GroovyIfTag.diff

   16/Feb/08 10:33 PM

   4 kB

   Jason Rudolph

• Assignee:

  Graeme Rocher

  Reporter:

  Jason Rudolph

• Created:

  16/Feb/08 10:33 PM

  Updated:

  18/Feb/08 4:15 AM

  Resolved:

  18/Feb/08 4:15 AM