Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.1
    • Fix Version/s: 1.3-RC1
    • Component/s: None
    • Labels:
      None

      Description

      I noticed some slightly braindead, although readable, code in RedirectDynamicMethod:

      Object id = argMap.get(ARGUMENT_ID);
              String frag = argMap.get(ARGUMENT_FRAGMENT) != null ? argMap.get(ARGUMENT_FRAGMENT).toString() : null;
              Object uri = argMap.get(ARGUMENT_URI);
              String url = argMap.containsKey(ARGUMENT_URL) ? argMap.get(ARGUMENT_URL).toString() : null;
              Map params = (Map)argMap.get(ARGUMENT_PARAMS);
              if(params==null)params = new HashMap();
      

      This is executing a great deal of hash retrievals for every single redirect, although invariably only one of them is needed. The best we can hope for is test the "most common" param first, and then only read the others in turn just before we test them.

        Activity

        Hide
        Graeme Rocher added a comment -

        Reduced priority of non critical issues which have current workarounds

        Show
        Graeme Rocher added a comment - Reduced priority of non critical issues which have current workarounds
        Hide
        Graeme Rocher added a comment -

        Moving non-critical issues that aren't going to make it into 1.1 to 1.2

        Show
        Graeme Rocher added a comment - Moving non-critical issues that aren't going to make it into 1.1 to 1.2
        Hide
        Graeme Rocher added a comment -

        There is no scope / time to resolve these remaining lower priority issues for 1.2 so moving to 1.3

        for 1.2 final only issues considered blocking will now be fixed

        Show
        Graeme Rocher added a comment - There is no scope / time to resolve these remaining lower priority issues for 1.2 so moving to 1.3 for 1.2 final only issues considered blocking will now be fixed
        Show
        Burt Beckwith added a comment - http://github.com/grails/grails-core/commit/58e924e5e1b9e7665f9000a7fe92f9da64851507

          People

          • Assignee:
            Burt Beckwith
            Reporter:
            Marc Palmer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development