Grails

FormatName is not correctly handled in <g:formatDate formatName="...." />

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.1
  • Fix Version/s: 1.1.2
  • Component/s: TagLib
  • Labels:
    None

Description

I looked at the formatDate code to find out that it is possible to put the format string in my "messages.properties" file. When the given key (by formatName) does not exist, a TagError should be thrown. However, this does not happen.

The existence of the formatName key is checked with:

format = message(code:formatName)
if(!format) throwTagError("Attribute [formatName] of Tag [formatDate] specifies a format key [$formatName] that does not exist within a message bundle!")

IMHO this should be:

format = message(code:formatName, default: "")
if(!format) throwTagError("Attribute [formatName] of Tag [formatDate] specifies a format key [$formatName] that does not exist within a message bundle!")

Sorry, I don't know how to submit this as a patch.

Activity

There are no comments yet on this issue.

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Jeroen Gordijn
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: