Grails

Return PagedResultList in case list* methods are provided with max and offset param

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.1
  • Fix Version/s: 2.0-RC2
  • Component/s: Persistence
  • Labels:
    None

Description

As far as I know only when using criteria Grails will return a PagedResultList.

It would be really nice if all list* methods would do this in case max and/or offset params are specified.

E.g. how it is currently

def result = Book.createCriteria().list(max: params.max, offset: params.offset) {}
assert result instanceof PagedResultList => TRUE

def result = Book.list(max: 10, offset: 0)
assert result instanceof PagedResultList => FALSE

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-8206 totalCount is broken

  • Blocker - Blocks development and/or testing work, production could not run.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. GRAILS-7945 Named Query results should be of type PagedResultList in order to support Pagination

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
Trackbacks

[Pearltrees] Articles Discover a selection of related articles on Pearltrees

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Marcel Overdijk added a comment -

Same for the findAll* methods

Show
Marcel Overdijk added a comment - Same for the findAll* methods
Hide
Permalink
Robert Watts added a comment -

Add executeQueryv methods

Show
Robert Watts added a comment - Add executeQueryv methods
Hide
Permalink
Allan Dixon added a comment -

Any update on this?

Show
Allan Dixon added a comment - Any update on this?
Hide
Permalink
Graeme Rocher added a comment -

Jeff - could you look at this? I think you did something in this area recently

Show
Graeme Rocher added a comment - Jeff - could you look at this? I think you did something in this area recently
Hide
Permalink
Jeff Brown added a comment -

Graeme - Will do.

Show
Jeff Brown added a comment - Graeme - Will do.
Hide
Permalink
Graeme Rocher added a comment -

How does one control whether you get 2 queries or 1?

https://github.com/grails/grails-core/commit/723b6239e279e55613ff743d5c22b305207b092d

Right now you always get 2 queries and there is no way to control whether you want the count as well or not?

Show
Graeme Rocher added a comment - How does one control whether you get 2 queries or 1? https://github.com/grails/grails-core/commit/723b6239e279e55613ff743d5c22b305207b092d Right now you always get 2 queries and there is no way to control whether you want the count as well or not?
Hide
Permalink
Jeff Brown added a comment -

The static list(...) method now returns a PagedResultList for paginated queries.

Show
Jeff Brown added a comment - The static list(...) method now returns a PagedResultList for paginated queries.
Hide
Permalink
Marcel Overdijk added a comment -

To bad findAll method is not returning PagedResultList in case max/offset param is provided.
Have to fallback to createCriteria method instead.

Show
Marcel Overdijk added a comment - To bad findAll method is not returning PagedResultList in case max/offset param is provided. Have to fallback to createCriteria method instead.
Hide
Permalink
Rick Jensen added a comment -

@MarcelOverdijk - Agreed. It would be rather nice to be able to treat all GORM-returned collections more similarly, regardless of how they are generated.

Show
Rick Jensen added a comment - @MarcelOverdijk - Agreed. It would be rather nice to be able to treat all GORM-returned collections more similarly, regardless of how they are generated.
Hide
Permalink
Rick Jensen added a comment -

or at least those retrieved with pagination parameters.

Show
Rick Jensen added a comment - or at least those retrieved with pagination parameters.
Hide
Permalink
Jeff Brown added a comment -

I think this issue addressed list(...) queries. If there are other query methods that need to be addressed a new JIRA should be filed so we can track those and implement them where that makes sense.

Show
Jeff Brown added a comment - I think this issue addressed list(...) queries. If there are other query methods that need to be addressed a new JIRA should be filed so we can track those and implement them where that makes sense.

People

  • Assignee:
    Jeff Brown
    Reporter:
    Marcel Overdijk
Vote (18)
Watch (20)

Dates

  • Created:
    Updated:
    Resolved: