Grails

Grails interactive test-app remembers paramters passed to it

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.3
  • Fix Version/s: 1.2-M4
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

When using grails interactive:

grails interactive
test-app

(you'll notice that two tests run - one for Book and one for Author)

test-app Book

(you'll notice that only one test runs, this is as expected)

test-app

(notice that only one test was run - I expected that since I didn't pass the name of a test to the test-app command, it would have run the whole suite again, but it only ran Book.)

  1. Text File
    grails-2811.patch.txt
    16/Oct/08 2:26 AM
    7 kB
    Rob Nielsen

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-2800 Grails Interactive mode doesn't use correct environment when running tests

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. GRAILS-2840 Grails interactive "remembering" previous arguments

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. GRAILS-3204 In interactive mode, Grails creates a war file with grails.env=development

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rob Nielsen added a comment -

Here's a patch for this issue (based off trunk revision 7434). Changes were all to
src/commons/org/codehaus/groovy/grails/cli/GrailsScriptRunner.groovy

The problem was that system properties were being set for
the scripts and being left around for subsequent scripts. I changed it to
take a copy of the system properties and restore it after each step.
I also added an 'exit' command to get out of interactive mode.

There was 0% coverage of GrailsScriptRunner so I added a
test/groovy/org/codehaus/groovy/grails/cli/InteractiveTests.groovy
file that tests basic interactive mode functionality.

This patch also resolves GRAILS-2800, GRAILS-2840, GRAILS-3204

Show
Rob Nielsen added a comment - Here's a patch for this issue (based off trunk revision 7434). Changes were all to src/commons/org/codehaus/groovy/grails/cli/GrailsScriptRunner.groovy The problem was that system properties were being set for the scripts and being left around for subsequent scripts. I changed it to take a copy of the system properties and restore it after each step. I also added an 'exit' command to get out of interactive mode. There was 0% coverage of GrailsScriptRunner so I added a test/groovy/org/codehaus/groovy/grails/cli/InteractiveTests.groovy file that tests basic interactive mode functionality. This patch also resolves GRAILS-2800 , GRAILS-2840 , GRAILS-3204
Hide
Permalink
Peter Ledbrook added a comment -

Fixed

Show
Peter Ledbrook added a comment - Fixed
Hide
Permalink
Graeme Rocher added a comment -

Bulk closing bunch of resolved issues

Show
Graeme Rocher added a comment - Bulk closing bunch of resolved issues

People

  • Assignee:
    Peter Ledbrook
    Reporter:
    Mike Hugo
Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: