actionSubmit tags retains default action URL in address bar

I'm not sure what to do about this. Everything is working as expected, it is just that the 404 error is mis-leading. I have had a quick look at the code, and it seems that fixing the 404 error would be non-trivial.

Much apologies. I was playing around to check out different scenarios, and I posted the wrong view code. Use this instead:

    <g:form controller="test">
        <g:actionSubmit name="testButton" value="Success" action="success"/>
    </g:form>

I left off the action attribute, which otherwise wouldn't behave as I described without that. The code above in your view will produce the incorrect behavior above.

I keep thinking about this, but the only solution I can come up with is to simply not include the default action in the form's target URL. This would avoid the confusion caused when using the <g;actionSubmit> tag.

When somebody fixes this, please update the Grails functional test FormsControllerTest.testActionSubmit() in the HelloWorld test app. There is a line commented out that tests for the behaviour described in my previous comment.

Sorry, this can't be fixed in time for the 1.0.4 release.

I just spent a good amount of time on a wild goose chase, and I believe this was the issue. Unfortunately I had chosen to give my submit button the same name as an existing action - and thus kept submitting to the same action! Something like:

class TestDirectoryController {
def scan =

}

<g:form action="handleScan">
The directory to scan: <g:textField name="dir" value="" />
<g:actionSubmit value="Scan" />
</g:form>

Very confusing!

Just a thought, in the case of an actionSubmit to edit:

def edit = {
    // In the case of an actionSubmit button, rewrite action name from 'index'.
    if(params._action_Edit)
    { params.action='edit' }
    
    ...do action...
}

If this could be done "behind the scenes" params.action would be correct and coupled with leaving the default action off the url, as suggested by Peter, may suffice as a partial fix?

The description of this issue is wrong. There is nothing wrong with actionSubmit, it is working as documented and as designed since handling of multiple submit buttons is done on the server and not on the client.

I've changed the description of the issue to say that the default action URL is retained in the address bar. Having said that I too am not sure what the fix is because changing this behavior would result in mass breakage and given the issue can be worked around with a custom URL mapping I don't see it being a serious one.

Given that I am also lowering the priority

Perhaps a new option for actionSubmit, rewrite="true".
Which would drop the default action from the post url and adjust params.action

Graeme: could you please post what you had in mind for a custom URL mapping.

There is no scope / time to resolve these remaining lower priority issues for 1.2 so moving to 1.3

for 1.2 final only issues considered blocking will now be fixed

voting for this also because I think actionSubmit should be able to set the action in the URL.
This would allow acegi requestmaps to hit on the action again which it presently can't because it inspects the ULR before the URLmapping.

here's a workaround/fix:

you can augment your actionSubmit buttons with an onclick that sets the proper action link to the actual form element as such:

<g:actionSubmit class="delete" onclick="this.form.action='$

'; return confirm('Are you sure?');" value="Delete" />

or for the scaffolding template add a / before createLink

<g:actionSubmit class="delete" onclick="this.form.action='\$

'; return confirm('Are you sure?');" value="Delete" />

this is assuming you still use the hidden input field to send the id as a parameter.

question:
if using requestmaps in acegi, isn't the way grails can map the parameters to the request a security hole, because anybody can formulate such a request to bypass my reuqestmaps?