Grails

Change "Events.groovy" to be "_Events.groovy"

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.4
  • Fix Version/s: 1.0.4
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

If the script file is "Events.groovy", you end up getting an "events" command-line task. This probably isn't intentional, so we should instead use "_Events.groovy" as the file name.

Attached is a patch which will try to use "_Events.groovy", and if it doesn't exist, will use "Events.groovy" and display a warning message to the screen. My suggestion would be to use this, and in 1.1, do away with "Events.groovy" in favor of "_Events.groovy" altogether.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Graeme Rocher added a comment -

Since this is a breaking change we'll put it into 1.1

Show
Graeme Rocher added a comment - Since this is a breaking change we'll put it into 1.1
Hide
Permalink
Robert Fischer added a comment -

For the record, the patch I submitted allows you to use either "Events.groovy" or "_Events.groovy", explicitly so that it won't be a breaking change.

You've got bigger fish to fry, though, so postponing this to a 1.1 release in order to get 1.0.4 out sooner is OK by me.

Show
Robert Fischer added a comment - For the record, the patch I submitted allows you to use either "Events.groovy" or "_Events.groovy", explicitly so that it won't be a breaking change. You've got bigger fish to fry, though, so postponing this to a 1.1 release in order to get 1.0.4 out sooner is OK by me.
Hide
Permalink
Graeme Rocher added a comment -

Oh ok, wasn't aware of that so moving back

Show
Graeme Rocher added a comment - Oh ok, wasn't aware of that so moving back
Hide
Permalink
Robert Fischer added a comment -

Yeah, I was pretty sneaky and subtle with how I mentioned the transitional nature of the patch right there in the issue description. ;-D

Show
Robert Fischer added a comment - Yeah, I was pretty sneaky and subtle with how I mentioned the transitional nature of the patch right there in the issue description. ;-D
Hide
Permalink
Graeme Rocher added a comment -

Thanks for the patch!

Show
Graeme Rocher added a comment - Thanks for the patch!
Hide
Permalink
Peter Ledbrook added a comment -

Due to the script refactoring, this got lost in the merge, sorry. It will be there for beta2.

Show
Peter Ledbrook added a comment - Due to the script refactoring, this got lost in the merge, sorry. It will be there for beta2.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.1#660-r161644) | Report a problem
Powered by a free Atlassian JIRA open source license for Grails project. Try JIRA - bug tracking software for your team.