Grails

PackagePlugin including stuff it shouldn't in plugin.xml

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.1-beta1
  • Fix Version/s: 2.1.1
  • Component/s: None
  • Labels:
    None

Description

The "package-plugin" command is including various resources in the "plugin.xml" file that it shouldn't:

  • Resources from global plugins
  • Stuff in the pluginExcludes list, such as PreInit.groovy and Config.groovy

Activity

Ascending order - Click to sort in descending order
Graeme Rocher made changes -
Field Original Value New Value
Assignee Graeme Rocher [ graemerocher ]
Contegix Support made changes -
Project Import Thu Mar 24 21:22:24 CDT 2011 [ 1301019744151 ]
Burt Beckwith made changes -
Workflow jira [ 33213 ] Grails [ 40431 ]
Burt Beckwith made changes -
Workflow Grails [ 40431 ] Copy of Grails [ 47862 ]
Burt Beckwith made changes -
Workflow Copy of Grails [ 47862 ] Grails [ 55272 ]
Burt Beckwith made changes -
Workflow Grails [ 55272 ] Grails2 [ 62821 ]
Burt Beckwith made changes -
Workflow Grails2 [ 62821 ] jira [ 74564 ]
Burt Beckwith made changes -
Workflow jira [ 74564 ] Grails2 [ 83359 ]
Peter Ledbrook made changes -
Last Reviewed 01/Jan/10
Peter Ledbrook made changes -
Workflow Grails2 [ 83359 ] jira [ 91839 ]
Peter Ledbrook made changes -
Workflow jira [ 91839 ] Grails2 [ 100015 ]
Hide
Permalink
Richard Vowles added a comment -

This has still not been fixed.

Show
Richard Vowles added a comment - This has still not been fixed.
Hide
Permalink
Richard Vowles added a comment -

It affects binary plugins which get ERROR's in their logs with all the junk resources.

Show
Richard Vowles added a comment - It affects binary plugins which get ERROR's in their logs with all the junk resources.
Repository Branch Revision Date Author/Committer Message
Grails Core 2.0.x 8b77053... 2012-09-08 00:52:09 -0700 Richard Vowles / Richard Vowles GRAILS-3577 - adds honoring the pluginexcludes for resources
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.1.x 8b77053... 2012-09-08 00:52:09 -0700 Richard Vowles / Richard Vowles GRAILS-3577 - adds honoring the pluginexcludes for resources
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x 8b77053... 2012-09-08 00:52:09 -0700 Richard Vowles / Richard Vowles GRAILS-3577 - adds honoring the pluginexcludes for resources
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core master 8b77053... 2012-09-08 00:52:09 -0700 Richard Vowles / Richard Vowles GRAILS-3577 - adds honoring the pluginexcludes for resources
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Hide
Permalink
Richard Vowles added a comment -

I have issued a pull request for fixing this. Its against Grails 2.0.3 (which is the version we are using until 2.0.5 comes out) - I'm not sure if it quite matches standards, happy to take feedback.

https://github.com/grails/grails-core/pull/262

Show
Richard Vowles added a comment - I have issued a pull request for fixing this. Its against Grails 2.0.3 (which is the version we are using until 2.0.5 comes out) - I'm not sure if it quite matches standards, happy to take feedback. https://github.com/grails/grails-core/pull/262
Repository Branch Revision Date Author/Committer Message
Grails Core 2.0.x dc74d7a... 2012-09-08 02:16:23 -0700 Richard Vowles / Richard Vowles GRAILS-3577 - PluginPackager shows a directory is accessible
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.1.x dc74d7a... 2012-09-08 02:16:23 -0700 Richard Vowles / Richard Vowles GRAILS-3577 - PluginPackager shows a directory is accessible
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x dc74d7a... 2012-09-08 02:16:23 -0700 Richard Vowles / Richard Vowles GRAILS-3577 - PluginPackager shows a directory is accessible
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core master dc74d7a... 2012-09-08 02:16:23 -0700 Richard Vowles / Richard Vowles GRAILS-3577 - PluginPackager shows a directory is accessible
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Hide
Permalink
Graeme Rocher added a comment -

The pull request was closed?

Show
Graeme Rocher added a comment - The pull request was closed?
Hide
Permalink
Richard Vowles added a comment -

Yes, I decided it wasn't good enough. I'd like to test it more in real plugins as well and I'm having a little difficulty with getting to grips with Gradle.

Show
Richard Vowles added a comment - Yes, I decided it wasn't good enough. I'd like to test it more in real plugins as well and I'm having a little difficulty with getting to grips with Gradle.
Hide
Permalink
Richard Vowles added a comment -

I have now added another

Show
Richard Vowles added a comment - I have now added another
Repository Branch Revision Date Author/Committer Message
Grails Core 2.0.x c4acff8... 2012-09-11 05:08:13 -0700 graemerocher / graemerocher Merge pull request #266 from rvowles/dc74d7a001aea3762a8b72c5743c92a19c02cec5

Fix for GRAILS-3577
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core 2.1.x c4acff8... 2012-09-11 05:08:13 -0700 graemerocher / graemerocher Merge pull request #266 from rvowles/dc74d7a001aea3762a8b72c5743c92a19c02cec5

Fix for GRAILS-3577
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x c4acff8... 2012-09-11 05:08:13 -0700 graemerocher / graemerocher Merge pull request #266 from rvowles/dc74d7a001aea3762a8b72c5743c92a19c02cec5

Fix for GRAILS-3577
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core master c4acff8... 2012-09-11 05:08:13 -0700 graemerocher / graemerocher Merge pull request #266 from rvowles/dc74d7a001aea3762a8b72c5743c92a19c02cec5

Fix for GRAILS-3577
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core 2.0.x ba24018... 2012-09-11 05:08:43 -0700 graemerocher / graemerocher Merge pull request #267 from rvowles/plugin-fix

Plugin fix includes GRAILS-9333 and GRAILS-3577
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core 2.1.x ba24018... 2012-09-11 05:08:43 -0700 graemerocher / graemerocher Merge pull request #267 from rvowles/plugin-fix

Plugin fix includes GRAILS-9333 and GRAILS-3577
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x ba24018... 2012-09-11 05:08:43 -0700 graemerocher / graemerocher Merge pull request #267 from rvowles/plugin-fix

Plugin fix includes GRAILS-9333 and GRAILS-3577
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core master ba24018... 2012-09-11 05:08:43 -0700 graemerocher / graemerocher Merge pull request #267 from rvowles/plugin-fix

Plugin fix includes GRAILS-9333 and GRAILS-3577
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core 2.1.x 4413cfb... 2012-09-11 05:09:30 -0700 Richard Vowles / Graeme Rocher GRAILS-3577 - adds honoring the pluginexcludes for resources
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core master 4413cfb... 2012-09-11 05:09:30 -0700 Richard Vowles / Graeme Rocher GRAILS-3577 - adds honoring the pluginexcludes for resources
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x 4413cfb... 2012-09-11 05:09:30 -0700 Richard Vowles / Graeme Rocher GRAILS-3577 - adds honoring the pluginexcludes for resources
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.1.x eea8d3a... 2012-09-11 05:09:38 -0700 Richard Vowles / Graeme Rocher GRAILS-3577 - PluginPackager shows a directory is accessible
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core master eea8d3a... 2012-09-11 05:09:38 -0700 Richard Vowles / Graeme Rocher GRAILS-3577 - PluginPackager shows a directory is accessible
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x eea8d3a... 2012-09-11 05:09:38 -0700 Richard Vowles / Graeme Rocher GRAILS-3577 - PluginPackager shows a directory is accessible
Files Changed
MODIFY grails-core/src/main/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGenerator.groovy
MODIFY grails-core/src/test/groovy/org/codehaus/groovy/grails/plugins/publishing/PluginDescriptorGeneratorSpec.groovy

Hide
Permalink
Graeme Rocher added a comment -

Thanks

Show
Graeme Rocher added a comment - Thanks
Graeme Rocher made changes -
Status Open [ 1 ] Closed [ 6 ]
Assignee Graeme Rocher [ graemerocher ]
Fix Version/s 2.1.1 [ 13207 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Peter Ledbrook
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
    Last Reviewed: