Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.1-beta1
    • Fix Version/s: 2.1.1
    • Component/s: None
    • Labels:
      None

      Description

      The "package-plugin" command is including various resources in the "plugin.xml" file that it shouldn't:

      • Resources from global plugins
      • Stuff in the pluginExcludes list, such as PreInit.groovy and Config.groovy

        Activity

        Peter Ledbrook created issue -
        Graeme Rocher made changes -
        Field Original Value New Value
        Assignee Graeme Rocher [ graemerocher ]
        Contegix Support made changes -
        Project Import Thu Mar 24 21:22:24 CDT 2011 [ 1301019744151 ]
        Burt Beckwith made changes -
        Workflow jira [ 33213 ] Grails [ 40431 ]
        Burt Beckwith made changes -
        Workflow Grails [ 40431 ] Copy of Grails [ 47862 ]
        Burt Beckwith made changes -
        Workflow Copy of Grails [ 47862 ] Grails [ 55272 ]
        Burt Beckwith made changes -
        Workflow Grails [ 55272 ] Grails2 [ 62821 ]
        Burt Beckwith made changes -
        Workflow Grails2 [ 62821 ] jira [ 74564 ]
        Burt Beckwith made changes -
        Workflow jira [ 74564 ] Grails2 [ 83359 ]
        Peter Ledbrook made changes -
        Last Reviewed 01/Jan/10
        Peter Ledbrook made changes -
        Workflow Grails2 [ 83359 ] jira [ 91839 ]
        Peter Ledbrook made changes -
        Workflow jira [ 91839 ] Grails2 [ 100015 ]
        Hide
        Richard Vowles added a comment -

        This has still not been fixed.

        Show
        Richard Vowles added a comment - This has still not been fixed.
        Hide
        Richard Vowles added a comment -

        It affects binary plugins which get ERROR's in their logs with all the junk resources.

        Show
        Richard Vowles added a comment - It affects binary plugins which get ERROR's in their logs with all the junk resources.
        Hide
        Richard Vowles added a comment -

        I have issued a pull request for fixing this. Its against Grails 2.0.3 (which is the version we are using until 2.0.5 comes out) - I'm not sure if it quite matches standards, happy to take feedback.

        https://github.com/grails/grails-core/pull/262

        Show
        Richard Vowles added a comment - I have issued a pull request for fixing this. Its against Grails 2.0.3 (which is the version we are using until 2.0.5 comes out) - I'm not sure if it quite matches standards, happy to take feedback. https://github.com/grails/grails-core/pull/262
        Hide
        Graeme Rocher added a comment -

        The pull request was closed?

        Show
        Graeme Rocher added a comment - The pull request was closed?
        Hide
        Richard Vowles added a comment -

        Yes, I decided it wasn't good enough. I'd like to test it more in real plugins as well and I'm having a little difficulty with getting to grips with Gradle.

        Show
        Richard Vowles added a comment - Yes, I decided it wasn't good enough. I'd like to test it more in real plugins as well and I'm having a little difficulty with getting to grips with Gradle.
        Hide
        Richard Vowles added a comment -

        I have now added another

        Show
        Richard Vowles added a comment - I have now added another
        graemerocher 11/Sep/2012 5:08 AM PDT
        View full commit
        Merge pull request #266 from rvowles/dc74d7a001aea3762a8b72c5743c92a19c02cec5

        Fix for GRAILS-3577
        graemerocher 11/Sep/2012 5:08 AM PDT
        View full commit
        Merge pull request #267 from rvowles/plugin-fix

        Plugin fix includes GRAILS-9333 and GRAILS-3577
        Hide
        Graeme Rocher added a comment -

        Thanks

        Show
        Graeme Rocher added a comment - Thanks
        Graeme Rocher made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Graeme Rocher [ graemerocher ]
        Fix Version/s 2.1.1 [ 13207 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Graeme Rocher
            Reporter:
            Peter Ledbrook
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Last Reviewed:

              Development