Grails

removeFrom not deleting records

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.1-RC1
  • Fix Version/s: 1.1.1
  • Component/s: Persistence
  • Labels:
    None

Description

I encoutered some problems with my parent-child domain classes when deleting childs.
I couldn't actually pinpoint why and when in was going wrong but after adding and deleteing childs suddenly records were not deleted.
This problems occured using the controllers and views.

I tried to reproduce it in Bootstrap by adding and deleting stuff and veryfing my actions. But it al seemed to work according to my println's...
However it's not the case!

Run the attached application.

  • In Bootstrap an invoice is created with some child lines
  • Then in bootstrap I remove, add and again remove some lines
  • At the end it has just 1 line as is also displayed using a println
  • So everything seems to be fine.....
  • But in the started application go the edit view of the invoice and it will display 3 lines (should be just 1 line)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Graeme Rocher added a comment -

You're not explicilty calling delete() on the child, just calling removeFrom* doesn't delete the instance

Show
Graeme Rocher added a comment - You're not explicilty calling delete() on the child, just calling removeFrom* doesn't delete the instance
Hide
Permalink
Marcel Overdijk added a comment -

I thought that was needed. Just as I don't explicitly call save() on the child.
Maybe we should put that somewhere in the docs?

Show
Marcel Overdijk added a comment - I thought that was needed. Just as I don't explicitly call save() on the child. Maybe we should put that somewhere in the docs?
Hide
Permalink
Marcel Overdijk added a comment -

I also tried a custom mapping in SalesInvoice like:

    static mapping = {
        lines cascade: "all,delete-orphan"
    }

But it makes no difference.

The ref guide (5.5.2.9 Custom Cascade Behaviour) states that this would delete removed childs automatically.

Show
Marcel Overdijk added a comment - I also tried a custom mapping in SalesInvoice like: static mapping = { lines cascade: "all,delete-orphan" } But it makes no difference. The ref guide (5.5.2.9 Custom Cascade Behaviour) states that this would delete removed childs automatically.
Hide
Permalink
Graeme Rocher added a comment -

Seems it is supposed to be "all-delete-orphan" I have corrected the docs

Show
Graeme Rocher added a comment - Seems it is supposed to be "all-delete-orphan" I have corrected the docs
Hide
Permalink
John Rellis added a comment -

FYI - the "all,delete-orphan" error still exists in the 1.1 docs. http://www.grails.org/doc/1.1/

I ran into problems today after removing a child from a parent, I was getting a null property exception at the end of the transaction , as in child.parent cannot be null. I think it makes sense to delete the child automatically if it has one parent and it is removed from that parent, but maybe I am not seeing the bigger picture...

Show
John Rellis added a comment - FYI - the "all,delete-orphan" error still exists in the 1.1 docs. http://www.grails.org/doc/1.1/ I ran into problems today after removing a child from a parent, I was getting a null property exception at the end of the transaction , as in child.parent cannot be null. I think it makes sense to delete the child automatically if it has one parent and it is removed from that parent, but maybe I am not seeing the bigger picture...

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Marcel Overdijk
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: