Grails

Unable to delete domain object from within a beforeDelete event

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 1.1
  • Fix Version/s: 1.2-M2
  • Component/s: None
  • Labels:
    None
  • Environment:
    Tested on both Windows XP and Mac OS X 10.5

Description

I have a controller which deletes a domain object. The domain object has a beforeDelete event. In that event I load another domain object and try to delete it but nothing happens. There is a beforeDelete event in the ProductLevel object but that's not called either.

This is my beforeDelete event:

def beforeDelete = {
def pl = ProductLevel.get(objectId)
log.debug "To delete: " + pl
if(pl)

{ log.debug "Calling delete" pl.delete() }

}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Bjørn Remseth added a comment -

I believe I see the same phenomenon. Here are the relevant pieces of a little sample project I wrote to smoke out the bug:

Domain classes:
=============

class Person {
String name;

static constraints = {
}

static hasMany = [
initiating: Relationship,
recipient: Relationship
];

static mappedBy = [
initiating: 'initiator',
recipient: 'recipient'
];

static mapping =

{ initiating cascade:'all, delete-orphan' recipient cascade:'all, delete-orphan' }

}

class Relationship {
String name;
Person initiator;
Person recipient;

static belongsTo = [initiator:Person, recipient:Person]

def beforeInsert =

{ initiator.addToInitiating(this); recipient.addToRecipient(this); }

def beforeDelete =

{ System.out.println("This is not happening"); // Never fires. initiator?.removeFromInitiating(this); recipient?.removeFromRecipient(this); }

static constraints = {
}
}

Failing integration test:
==================

import grails.test.*

class PersonTestTests extends GrailsUnitTestCase {
Person a;
Person b;
RelationshipType rt;
Relationship r;

protected void setUp()

{ super.setUp(); rt = new RelationshipType(name: "rt"); a = new Person(name: "a"); a.save(flush:true); b = new Person(name: "b"); b.save(flush:true); r = new Relationship(initiator: a, recipient: b, name: "relationship"); r.save(flush:true); }

protected void tearDown()

{ super.tearDown() // r.delete(flush:true); a.delete(flush:true); b.delete(flush:true); a= null; b= null; r= null; }

void testSomething() {

}
}

Show
Bjørn Remseth added a comment - I believe I see the same phenomenon. Here are the relevant pieces of a little sample project I wrote to smoke out the bug: Domain classes: ============= class Person { String name; static constraints = { } static hasMany = [ initiating: Relationship, recipient: Relationship ]; static mappedBy = [ initiating: 'initiator', recipient: 'recipient' ]; static mapping = { initiating cascade:'all, delete-orphan' recipient cascade:'all, delete-orphan' } } class Relationship { String name; Person initiator; Person recipient; static belongsTo = [initiator:Person, recipient:Person] def beforeInsert = { initiator.addToInitiating(this); recipient.addToRecipient(this); } def beforeDelete = { System.out.println("This is not happening"); // Never fires. initiator?.removeFromInitiating(this); recipient?.removeFromRecipient(this); } static constraints = { } } Failing integration test: ================== import grails.test.* class PersonTestTests extends GrailsUnitTestCase { Person a; Person b; RelationshipType rt; Relationship r; protected void setUp() { super.setUp(); rt = new RelationshipType(name: "rt"); a = new Person(name: "a"); a.save(flush:true); b = new Person(name: "b"); b.save(flush:true); r = new Relationship(initiator: a, recipient: b, name: "relationship"); r.save(flush:true); } protected void tearDown() { super.tearDown() // r.delete(flush:true); a.delete(flush:true); b.delete(flush:true); a= null; b= null; r= null; } void testSomething() { } }
Hide
Permalink
Graeme Rocher added a comment -

With the attached project and going to http://localhost:8080/before-delete/product/index I cannot reproduce the problem against Git HEAD

Please attach a project that reproduces the problem

Show
Graeme Rocher added a comment - With the attached project and going to http://localhost:8080/before-delete/product/index I cannot reproduce the problem against Git HEAD Please attach a project that reproduces the problem
Hide
Permalink
Graeme Rocher added a comment -

One note, when the beforeDelete event fires, it is fired by Hibernate too late in the flushing process so delete() calls won't take effect unless you flush the session again. You can work around this in Grails 1.2 (when its released) by doing your updates in a new session. So you code would be:

def beforeDelete() {
   ProductLevel.withNewSession {
       def pl = ProductLevel.get(objectId)
       log.debug "To delete: " + pl
       if(pl) { log.debug "Calling delete" pl.delete() }
   }
}

Which will work just fine

Show
Graeme Rocher added a comment - One note, when the beforeDelete event fires, it is fired by Hibernate too late in the flushing process so delete() calls won't take effect unless you flush the session again. You can work around this in Grails 1.2 (when its released) by doing your updates in a new session. So you code would be: def beforeDelete() { ProductLevel.withNewSession { def pl = ProductLevel.get(objectId) log.debug "To delete: " + pl if (pl) { log.debug "Calling delete" pl.delete() } } } Which will work just fine

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Roland Bali
Vote (6)
Watch (8)

Dates

  • Created:
    Updated:
    Resolved: