Grails

suggestion: can we make source code attachments available in maven repo for the various parts of grails?

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 2.0-M1
  • Component/s: ContinuousBuild
  • Labels:
    None
  • Environment:
    windoze vista.

Description

Hi..

It would be quite handy to have source code attachments available for grails.

This does not seem to be available at the moment:>
http://repository.codehaus.org/org/grails/grails-core/1.1/

These attachments are available for most other open source projects.. for example, Groovy>>
http://repository.codehaus.org/org/codehaus/groovy/groovy-all/1.6.3/groovy-all-1.6.3-sources.jar

Having the source is really valuable for those of us who have use Maven... Using mvn idea:idea (or eclipse:eclipse) -DdownloadSources=true enables you to have a grails project set up in your IDE that enables you to debug into all dependent modules that have source attachments... This is available out-of-the-box.

Even though grails isnt' built with maven it would be quite straight forward to add some stuff to your ant build to jar up the sources and stick them in the correct place in the maven repo...

Hey, I'll even do this for you if it is agreed that this is a useful thing to have.

Just drop a line.. contact info is below.

  • Chris

___________
Chris Bedford

Founder & Lead Lackey
Build Lackey Labs
http://buildlackey.com
chris [<at>] buildlackey.com

Activity

Hide
chris bedford added a comment -

I just looked at some of your ant build files and noticed that you actually had some code in
place to do what i suggested above ( in the file ./ant/build/maven.xml )

<macrodef name="mavenInstallRepo">
<attribute name="version"/>
<attribute name="prefix"/>
<sequential>
<artifact:install file="${targetDistDirectory}/@{prefix}-@{version}.jar">
<pom refid="@{prefix}.pom"/>
<!--
<attach file="${targetDistDirectory}/@{prefix}-@{version}-sources.jar" classifier="sources"/>

It would be great if this could be re-enabled...

If there is some tricky issue preventing that, then perhaps you might want to use the quick and dirty solution that i hacked together for my own purposes.. ?

The code below adds "all sources" jar file target" to ant/build/bundle.xml.. This jar file can then be used to "attach sources" in eclipse, IDEA, or other IDE's so that you can debug into grails source code.

The solution I developed isn't 100% ideal, because it doesn't set up the source attachments
magically and automatically (as would happen if you re-enabled the commented out lines above)...

But it provides a reasonably convenient way for folks to attach the grails source manually.

->>>>

<target name="src-jar" depends="" description="Jar up the source">
<jar destfile="${grails.dist}/grails-source-all-${grails.version}.jar" >
<fileset dir="${basedir}/src/groovy/">
<include name="**" />
</fileset>
<fileset dir="${basedir}/src/jsp21/">
<include name="**" />
</fileset>
<fileset dir="${basedir}/src/persistence/">
<include name="**" />
</fileset>
<fileset dir="${basedir}/src/scaffolding/">
<include name="**" />
</fileset>
<fileset dir="${basedir}/src/web/">
<include name="**" />
</fileset>
<fileset dir="${basedir}/src/commons/">
<include name="**" />
</fileset>
</jar>
</target>

best regards,

  • chris
  • Chris

___________
Chris Bedford

Founder & Lead Lackey
Build Lackey Labs
http://buildlackey.com
chris [<at>] buildlackey.com

Show
chris bedford added a comment - I just looked at some of your ant build files and noticed that you actually had some code in place to do what i suggested above ( in the file ./ant/build/maven.xml ) <macrodef name="mavenInstallRepo"> <attribute name="version"/> <attribute name="prefix"/> <sequential> <artifact:install file="${targetDistDirectory}/@{prefix}-@{version}.jar"> <pom refid="@{prefix}.pom"/> <!-- <attach file="${targetDistDirectory}/@{prefix}-@{version}-sources.jar" classifier="sources"/> It would be great if this could be re-enabled... If there is some tricky issue preventing that, then perhaps you might want to use the quick and dirty solution that i hacked together for my own purposes.. ? The code below adds "all sources" jar file target" to ant/build/bundle.xml.. This jar file can then be used to "attach sources" in eclipse, IDEA, or other IDE's so that you can debug into grails source code. The solution I developed isn't 100% ideal, because it doesn't set up the source attachments magically and automatically (as would happen if you re-enabled the commented out lines above)... But it provides a reasonably convenient way for folks to attach the grails source manually. ->>>> <target name="src-jar" depends="" description="Jar up the source"> <jar destfile="${grails.dist}/grails-source-all-${grails.version}.jar" > <fileset dir="${basedir}/src/groovy/"> <include name="**" /> </fileset> <fileset dir="${basedir}/src/jsp21/"> <include name="**" /> </fileset> <fileset dir="${basedir}/src/persistence/"> <include name="**" /> </fileset> <fileset dir="${basedir}/src/scaffolding/"> <include name="**" /> </fileset> <fileset dir="${basedir}/src/web/"> <include name="**" /> </fileset> <fileset dir="${basedir}/src/commons/"> <include name="**" /> </fileset> </jar> </target> best regards,
  • chris
  • Chris
___________ Chris Bedford Founder & Lead Lackey Build Lackey Labs http://buildlackey.com chris [<at>] buildlackey.com
Hide
Reiner Saddey added a comment -

We've got a not so off-the-shelf Grails app (e.g. legacy databases, true contract-first web services using JAX-WS RI).

Thus upgrading to a new Grails version is quite an effort. That effort could be reduced in half, if Grails would supply source jars along with its binary artifacts (i.e. as attached sources jars at repo1.maven.org).

A small step for Grails and a leap for mankind

Show
Reiner Saddey added a comment - We've got a not so off-the-shelf Grails app (e.g. legacy databases, true contract-first web services using JAX-WS RI). Thus upgrading to a new Grails version is quite an effort. That effort could be reduced in half, if Grails would supply source jars along with its binary artifacts (i.e. as attached sources jars at repo1.maven.org). A small step for Grails and a leap for mankind
Hide
Graeme Rocher added a comment -

source/javadoc jars are published to our maven repo at http://repo.grails.org/grails/core

Show
Graeme Rocher added a comment - source/javadoc jars are published to our maven repo at http://repo.grails.org/grails/core

People

Vote (12)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved: