Grails

Regression: NPE in taglibs - probably actionName being null

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.2-M1
  • Fix Version/s: 1.2-M2
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes

Description

The Navigation plugin has code like this in the taglib:

                if ((controllerName == data.controller) && 
                        (!actionMatch || (actionName == data.action)) && 
                        (!data.params || (data.params.every { e -> params.get(e.key)?.equals(e.value) })) ) {
                    data.active = true
                }
                out << body(var ? [(var):data] : data)

This code is NPE'ing on existing apps with 1.2M1, but works fine with 1.1.1

My guess is that actionName is null in 1.2M1? This code is executed from a tag that then executes the above code in a closure.

Source for the tag is here: https://svn.codehaus.org/grails-plugins/grails-navigation/trunk/grails-app/taglib/NavigationTagLib.groovy

Line 131 or so.

Activity

Hide
Permalink
Marc Palmer added a comment -

Isolated it. 1.2M1 causes NPE in this code (line 131) in the nav taglib:

130                if ((controllerName == data.controller) && 
131                        (!actionMatch || (actionName == data.action)) && 
132                        (!data.params || (data.params.every { e -> params.get(e.key)?.equals(e.value) })) ) {
133                    data.active = true
134                }

With 1.1.1 this is fine. data is not null as it gets past 130. actionName appears to be null in 1.2M1

Show
Marc Palmer added a comment - Isolated it. 1.2M1 causes NPE in this code (line 131) in the nav taglib: 130 if ((controllerName == data.controller) && 131 (!actionMatch || (actionName == data.action)) && 132 (!data.params || (data.params.every { e -> params.get(e.key)?.equals(e.value) })) ) { 133 data.active = true 134 } With 1.1.1 this is fine. data is not null as it gets past 130. actionName appears to be null in 1.2M1

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Marc Palmer
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: