Grails

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2-M2
• Fix Version/s: 1.4-M1
• Component/s: Testing
• Labels:

  None

With the following mapping:

"/user/$idText?"{
    controller = "user"
    action = "publicProfile"
}

The following assert should fail, but it doesn't:

assertForwardUrlMapping("/user", controller: "user", action: "publicProfile") {
	idText = "1234"
}

The problem is that the method assertForwardUrlMapping doesn't check the params assertions. I have checked it debugging the code, and I think that the problem exactly is in the line 170 of the GrailsUrlMappingsTestCase:

if(!controllers.containsKey(actual) && mappingInfos.size() > 1) return

In all the cases the code checks if the "actual" value is a controller. For the cases of actions (in my case "publicProfile") the return sentence is executed and the sentences that really check the param assertions (later in the code) are never executed.

I think that the solution is to make the check only if we are talking about a controller:

if(key == "controller" && !controllers.containsKey(actual) && mappingInfos.size() > 1) return

BTW, in the line 187 of the same file (GrailsUrlMappingsTestCase), the assertEquals compares "value.toString()" and "mapping.params[name]". When the value is null (for instance, to check that an specific param is not set) the assertion fails. I think that the solution is to compare "value.toString()" with "mapping.params[name].toString()". I changed the code, I tested it and it ran ok.

1. $i18n.getText("admin.common.words.hide")

   

   mappingtest.zip

   14/Apr/11 6:45 AM

   290 kB

   Marcin Erdmann

   1. 
      mappingtest/.project 0.5 kB
   2. 
      mappingtest/.classpath 0.7 kB
   3. 
      mappingtest/application.properties 0.2 kB
   4. 
      mappingtest/target/stacktrace.log 41 kB
   5. 
      mappingtest/.../org.codehaus.groovy.eclipse.preferences.prefs 0.1 kB
   6. 
      mappingtest/.../UrlMappings.groovy 0.2 kB
   7. 
      mappingtest/grails-app/.../Config.groovy 4 kB
   8. 
      mappingtest/.../BuildConfig.groovy 1 kB
   9. 
      mappingtest/grails-app/.../BootStrap.groovy 0.1 kB
   10. 
       mappingtest/grails-app/.../DataSource.groovy 0.8 kB
   11. 
       mappingtest/.../messages_ru.properties 4 kB
   12. 
       mappingtest/.../messages.properties 3 kB
   13. 
       mappingtest/.../messages_th.properties 5 kB
   14. 
       mappingtest/.../messages_zh_CN.properties 2 kB
   15. 
       mappingtest/.../messages_pt_BR.properties 3 kB
   16. 
       mappingtest/.../messages_da.properties 3 kB
   17. 
       mappingtest/.../messages_es.properties 3 kB
   18. 
       mappingtest/.../messages_nl.properties 3 kB
   19. 
       mappingtest/.../messages_fr.properties 2 kB
   20. 
       mappingtest/.../messages_pt_PT.properties 3 kB
   21. 
       mappingtest/.../messages_ja.properties 2 kB
   22. 
       mappingtest/.../messages_de.properties 4 kB
   23. 
       mappingtest/.../messages_it.properties 2 kB
   24. 
       mappingtest/grails-app/views/error.gsp 2 kB
   25. 
       mappingtest/grails-app/views/index.gsp 4 kB
   26. 
       mappingtest/target/.../TESTS-TestSuites.xml 2 kB
   27. 
       mappingtest/.../TEST-integration-integration-mappingtest.UrlMappingTests.xml 2 kB
   28. 
       mappingtest/.../TomcatGrailsPlugin.class 7 kB
   29. 
       mappingtest/.../HibernateGrailsPlugin$_closure2.class 3 kB
   30. 
       mappingtest/.../HibernateGrailsPlugin$_closure1.class 4 kB

   Showing 30 of 131 items Download Zip

   $i18n.getText("admin.common.words.show")

   

   mappingtest.zip

   14/Apr/11 6:45 AM

   290 kB

   Marcin Erdmann

• Assignee:

  Graeme Rocher

  Reporter:

  Jesús Lanchas

• Created:

  13/Oct/09 3:29 PM

  Updated:

  04/May/11 2:25 AM

  Resolved:

  04/May/11 2:25 AM