Grails

g:javascript tag not working properly with plugin views

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.2-M4
  • Fix Version/s: 1.2-RC1
  • Component/s: View technologies
  • Labels:
    None

Description

The g:javascript tag is not working when used within a plugin view that uses an application layout, or an application view that overrides a plugin view. The problem is, the tag tries to "intelligently" determine whether its in a plugin view/layout, but fails. It simply checks whether the current controller (added as a request attribute) has a plugin context path.

Note that this behaviour is different to the g:resource tag, which has a plugin attribute.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-1249 pluginContextPath contains wrong path

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
supercedes

Bug - A problem which impairs or prevents the functions of the product. GPNIMBLE-1 Plugin overrules javascript location, breaking application JavaScript

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Peter Ledbrook added a comment -

The original issue wasn't a problem with the plugin.

Show
Peter Ledbrook added a comment - The original issue wasn't a problem with the plugin.
Hide
Permalink
Peter Ledbrook added a comment -

The fix for GRAILS-1249 is the source of the problem. It's only taken two years to surface!

Show
Peter Ledbrook added a comment - The fix for GRAILS-1249 is the source of the problem. It's only taken two years to surface!
Hide
Permalink
Graeme Rocher added a comment -

So the suggested fix is to make it take a plugin attribute like the rest of the tags?

Show
Graeme Rocher added a comment - So the suggested fix is to make it take a plugin attribute like the rest of the tags?
Hide
Permalink
Peter Ledbrook added a comment -

It's one option, but see dev mailing list for my e-mail. I have functional tests locally that check the behaviour of g:resource and g:javascript in the following:

  1. in a plugin view
  2. in an application view that overrides a plugin view
  3. in an application layout used by a plugin view
  4. ...and one other (I'll get back on this)
Show
Peter Ledbrook added a comment - It's one option, but see dev mailing list for my e-mail. I have functional tests locally that check the behaviour of g:resource and g:javascript in the following: in a plugin view in an application view that overrides a plugin view in an application layout used by a plugin view ...and one other (I'll get back on this)
Hide
Permalink
Graeme Rocher added a comment -

this is fixed already

Show
Graeme Rocher added a comment - this is fixed already

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Peter Ledbrook
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: