Grails
  1. Grails
  2. GRAILS-5404

pluginExcludes aren't supported in in-place plugins

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 1.2-M4
    • Fix Version/s: None
    • Component/s: Plugins
    • Labels:
      None

      Description

      pluginExcludes is currently only used in package-plugin. pluginExcludes should also be supported with in-place plugins that are included with grails.project.plugins.dir or grails.plugin.location.'pluginname' setting.

      Currently we have tests and configuration in the plugin project to run unit and integration tests for the plugin alone. When we include the plugin to some other project by using the grails.project.plugins.dir or grails.plugin.location.'pluginname' setting, the pluginExcludes are ignored.

      This is the pluginExcludes setting we are using:

         
          def pluginExcludes = [
                  "grails-app/views/error.gsp", "grails-app/conf/spring/*", "grails-app/conf/*"
          ]
      

        Issue Links

          Activity

          Hide
          Lari Hotari added a comment -

          I checked the source code and it seems to require quite a lot of changes to grails.util.PluginBuildSettings class to support pluginExcludes.

          Show
          Lari Hotari added a comment - I checked the source code and it seems to require quite a lot of changes to grails.util.PluginBuildSettings class to support pluginExcludes.
          Hide
          Lari Hotari added a comment -

          As a workaround we'll restructure plugin projects so that there's a separate project for each internal plugin that uses the plugin and contains the integration tests (and test configuration) for the plugin. That's how we can live without having this feature available now and we will be able to build the CI environment.

          Show
          Lari Hotari added a comment - As a workaround we'll restructure plugin projects so that there's a separate project for each internal plugin that uses the plugin and contains the integration tests (and test configuration) for the plugin. That's how we can live without having this feature available now and we will be able to build the CI environment.
          Hide
          Lari Hotari added a comment -

          Is there any progress on this issue? Now that GRAILS-2285 is solved (thanks Graeme!), this could be the next challenge...

          Show
          Lari Hotari added a comment - Is there any progress on this issue? Now that GRAILS-2285 is solved (thanks Graeme!), this could be the next challenge...
          Hide
          Graeme Rocher added a comment -

          will try look at it, at least for classes

          Show
          Graeme Rocher added a comment - will try look at it, at least for classes
          Hide
          Graeme Rocher added a comment -

          processing excludes at development time is a rather hard as we don't currently filter static resources nor do we filter views and so on.

          The easiest solution right now is to filter when creating a war file which we can do

          Show
          Graeme Rocher added a comment - processing excludes at development time is a rather hard as we don't currently filter static resources nor do we filter views and so on. The easiest solution right now is to filter when creating a war file which we can do
          Hide
          Serge P. Nekoval added a comment -

          One bad situation that we encountered is that domain classes from "local" plugin got processed by application and thus affected application's behaviour in unexpected way. So I vote for this ticket...

          Show
          Serge P. Nekoval added a comment - One bad situation that we encountered is that domain classes from "local" plugin got processed by application and thus affected application's behaviour in unexpected way. So I vote for this ticket...
          Hide
          Malte Huebner added a comment -

          This is still an issue in Grails 2.2.1. The gerneration of a pruduction war file is also affected.

          Show
          Malte Huebner added a comment - This is still an issue in Grails 2.2.1. The gerneration of a pruduction war file is also affected.

            People

            • Assignee:
              Unassigned
              Reporter:
              Lari Hotari
            • Votes:
              24 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

              • Created:
                Updated:
                Last Reviewed:

                Development