[#GRAILS-5485] grails test-app executes integrationtest-classes twice - Grails JIRA

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 1.2-RC1
Fix Version/s: 1.2-RC2
Component/s: Testing
Labels:
None
Environment:
Grails-1.2-RC1
JVM: 1.5.0_14-b03
JVM Vendor: Sun Microsystems Inc.
OS Name: Windows XP

Description

item 1

after upgrading from 1.2-M4 to 1.2-RC1 my integration-test-classes
seem to be executed twice.

the command i execute is:

monospaced
grails test-app integration: com.mycompany.myapp.DataModelIntegration -clean
monospaced

the output is:

monospaced
-------------------------------------------------------
Running 2 integration tests...
Running test com.mycompany.myapp.DataModelIntegrationTests...PASSED
Running test com.mycompany.myapp.DataModelIntegrationTests...PASSED
Tests Completed in 2672ms ...
-------------------------------------------------------
Tests passed: 6
Tests failed: 0
-------------------------------------------------------
monospaced

DataModelIntegrationTests.groovy contains 3 test-methods

same also happens, when i execute:

monospaced
grails test-app com.mycompany.myapp.DataModelIntegration -clean -integration
monospaced

item 2

[this may not have to categorized as a bug]

by mistake i forgot the colon of 'integration:'

monospaced
grails test-app integration com.mycompany.myapp.DataModelIntegration -clean
monospaced

and got a:

Error executing script TestApp: java.lang.StringIndexOutOfBoundsException: Strin
g index out of range: -1

Issue Links

This issue is duplicated by:
GRAILS-5530	exceptions/bad test counts (or running tests twice) when specifiying individual tests to run with grails 1.2 RC1
GRAILS-5534	Unit tests run twice

Options
- Show All
- Show Open

Sub-Tasks

1.	Integration tests are run twice		Closed	Luke Daley
2.	Running "test-app integration" causes exception		Closed	Luke Daley

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Luke Daley added a comment - 05/Dec/09 10:01 PM

Helmut,

I am having trouble reproducing item 1

Are you able to attach your project?

Show

Luke Daley added a comment - 05/Dec/09 10:01 PM Helmut, I am having trouble reproducing item 1 Are you able to attach your project?

Hide

Permalink

Helmut Denk added a comment - 06/Dec/09 8:01 AM

my steps to reproduce it:

step 1
grails create-app grails-test

step 2

create test-class test/integration/com/mycompany.myapp/DummyTest.groovy:

package com.mycompany.myapp

class DummyTests extends GroovyTestCase {
	void testShouldRunOk() {	
	}	
	
	void testShouldFail() {
		fail 'this test fails'
	}
}

step 3

run command:

grails test-app integration: com.mycompany.myapp.Dummy

this is the output for me:

-------------------------------------------------------
Running 2 integration tests...
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Tests Completed in 1375ms ...
-------------------------------------------------------
Tests passed: 2
Tests failed: 2
-------------------------------------------------------

Show

Helmut Denk added a comment - 06/Dec/09 8:01 AM my steps to reproduce it: step 1 grails create-app grails-test step 2 create test-class test/integration/com/mycompany.myapp/DummyTest.groovy:

package com.mycompany.myapp

class DummyTests extends GroovyTestCase {
	void testShouldRunOk() {	
	}	
	
	void testShouldFail() {
		fail 'this test fails'
	}
}

step 3 run command: grails test-app integration: com.mycompany.myapp.Dummy this is the output for me:

-------------------------------------------------------
Running 2 integration tests...
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Tests Completed in 1375ms ...
-------------------------------------------------------
Tests passed: 2
Tests failed: 2
-------------------------------------------------------

Hide

Permalink

Luke Daley added a comment - 07/Dec/09 5:46 AM

I followed these steps exactly and cannot reproduce, this may be a windows specific issue.

Show

Luke Daley added a comment - 07/Dec/09 5:46 AM I followed these steps exactly and cannot reproduce, this may be a windows specific issue.

Hide

Permalink

Peter Ledbrook added a comment - 07/Dec/09 6:48 AM

Can't reproduce on Linux with latest code. BTW, in step 2, the name of the test file is wrong: it should be DummyTests.groovy not DummyTest.groovy. Correcting it will save some heartache for those of us copying and pasting.

Show

Peter Ledbrook added a comment - 07/Dec/09 6:48 AM Can't reproduce on Linux with latest code. BTW, in step 2, the name of the test file is wrong: it should be DummyTests.groovy not DummyTest.groovy. Correcting it will save some heartache for those of us copying and pasting.

Hide

Permalink

Helmut Denk added a comment - 07/Dec/09 4:40 PM

a sequence of commands with output
executed on my xp-box:

1 = ok

>grails test-app

Welcome to Grails 1.2.0.RC1 - http://grails.org/
Licensed under Apache Standard License 2.0
Grails home is set to: c:\tools\grails\grails-1.2.RC1

Base Directory: F:\workspaces\test\grails12RC1-test2
Resolving dependencies...
Dependencies resolved in 1094ms.
Running script c:\tools\grails\grails-1.2.RC1\scripts\TestApp.groovy
Environment set to test
No authentication for svn repo at snapshot ...
No authentication for svn repo at released ...
No authentication for svn repo at thirdparty ...
Using explicit plugin resolve order [default, core] ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\html
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\plain

Starting unit test phase ...

Starting integration test phase ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes

-------------------------------------------------------
Running 1 integration test...
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Tests Completed in 1015ms ...
-------------------------------------------------------
Tests passed: 1
Tests failed: 1
-------------------------------------------------------

Starting other test phase ...
[junitreport] Processing F:\workspaces\test\grails12RC1-test2\target\test-reports\TESTS-TestSuites.xml to C:\DOKUME~1\hdenk\LOKALE~1\Temp\null1453917995
[junitreport] Loading stylesheet jar:file:/C:/Dokumente%20und%20Einstellungen/hdenk/.ivy2/cache/org.apache.ant/ant-junit/jars/ant-junit-1.7.1.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 1578ms
[junitreport] Deleting: C:\DOKUME~1\hdenk\LOKALE~1\Temp\null1453917995

Tests FAILED - view reports in target\test-reports
Application context shutting down...
Application context shutdown.

2 = ok

>grails test-app integration:

Welcome to Grails 1.2.0.RC1 - http://grails.org/
Licensed under Apache Standard License 2.0
Grails home is set to: c:\tools\grails\grails-1.2.RC1

Base Directory: F:\workspaces\test\grails12RC1-test2
Resolving dependencies...
Dependencies resolved in 1360ms.
Running script c:\tools\grails\grails-1.2.RC1\scripts\TestApp.groovy
Environment set to test
No authentication for svn repo at snapshot ...
No authentication for svn repo at released ...
No authentication for svn repo at thirdparty ...
Using explicit plugin resolve order [default, core] ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\html
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\plain

Starting integration test phase ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes

-------------------------------------------------------
Running 1 integration test...
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Tests Completed in 1000ms ...
-------------------------------------------------------
Tests passed: 1
Tests failed: 1
-------------------------------------------------------
[junitreport] Processing F:\workspaces\test\grails12RC1-test2\target\test-reports\TESTS-TestSuites.xml to C:\DOKUME~1\hdenk\LOKALE~1\Temp\null513622173
[junitreport] Loading stylesheet jar:file:/C:/Dokumente%20und%20Einstellungen/hdenk/.ivy2/cache/org.apache.ant/ant-junit/jars/ant-junit-1.7.1.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 1766ms
[junitreport] Deleting: C:\DOKUME~1\hdenk\LOKALE~1\Temp\null513622173

Tests FAILED - view reports in target\test-reports
Application context shutting down...
Application context shutdown.

3 = not ok

>grails test-app integration: com.mycompany.myapp.Dummy

Welcome to Grails 1.2.0.RC1 - http://grails.org/
Licensed under Apache Standard License 2.0
Grails home is set to: c:\tools\grails\grails-1.2.RC1

Base Directory: F:\workspaces\test\grails12RC1-test2
Resolving dependencies...
Dependencies resolved in 1219ms.
Running script c:\tools\grails\grails-1.2.RC1\scripts\TestApp.groovy
Environment set to test
No authentication for svn repo at snapshot ...
No authentication for svn repo at released ...
No authentication for svn repo at thirdparty ...
Using explicit plugin resolve order [default, core] ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\html
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\plain

Starting integration test phase ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes

-------------------------------------------------------
Running 2 integration tests...
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Tests Completed in 1188ms ...
-------------------------------------------------------
Tests passed: 2
Tests failed: 2
-------------------------------------------------------
[junitreport] Processing F:\workspaces\test\grails12RC1-test2\target\test-reports\TESTS-TestSuites.xml to C:\DOKUME~1\hdenk\LOKALE~1\Temp\null1251350568
[junitreport] Loading stylesheet jar:file:/C:/Dokumente%20und%20Einstellungen/hdenk/.ivy2/cache/org.apache.ant/ant-junit/jars/ant-junit-1.7.1.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 1547ms
[junitreport] Deleting: C:\DOKUME~1\hdenk\LOKALE~1\Temp\null1251350568

Tests FAILED - view reports in target\test-reports
Application context shutting down...
Application context shutdown.

Show

Helmut Denk added a comment - 07/Dec/09 4:40 PM a sequence of commands with output executed on my xp-box: 1 = ok

>grails test-app

Welcome to Grails 1.2.0.RC1 - http://grails.org/
Licensed under Apache Standard License 2.0
Grails home is set to: c:\tools\grails\grails-1.2.RC1

Base Directory: F:\workspaces\test\grails12RC1-test2
Resolving dependencies...
Dependencies resolved in 1094ms.
Running script c:\tools\grails\grails-1.2.RC1\scripts\TestApp.groovy
Environment set to test
No authentication for svn repo at snapshot ...
No authentication for svn repo at released ...
No authentication for svn repo at thirdparty ...
Using explicit plugin resolve order [default, core] ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\html
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\plain

Starting unit test phase ...

Starting integration test phase ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes

-------------------------------------------------------
Running 1 integration test...
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Tests Completed in 1015ms ...
-------------------------------------------------------
Tests passed: 1
Tests failed: 1
-------------------------------------------------------

Starting other test phase ...
[junitreport] Processing F:\workspaces\test\grails12RC1-test2\target\test-reports\TESTS-TestSuites.xml to C:\DOKUME~1\hdenk\LOKALE~1\Temp\null1453917995
[junitreport] Loading stylesheet jar:file:/C:/Dokumente%20und%20Einstellungen/hdenk/.ivy2/cache/org.apache.ant/ant-junit/jars/ant-junit-1.7.1.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 1578ms
[junitreport] Deleting: C:\DOKUME~1\hdenk\LOKALE~1\Temp\null1453917995

Tests FAILED - view reports in target\test-reports
Application context shutting down...
Application context shutdown.

2 = ok >grails test-app integration:

Welcome to Grails 1.2.0.RC1 - http://grails.org/
Licensed under Apache Standard License 2.0
Grails home is set to: c:\tools\grails\grails-1.2.RC1

Base Directory: F:\workspaces\test\grails12RC1-test2
Resolving dependencies...
Dependencies resolved in 1360ms.
Running script c:\tools\grails\grails-1.2.RC1\scripts\TestApp.groovy
Environment set to test
No authentication for svn repo at snapshot ...
No authentication for svn repo at released ...
No authentication for svn repo at thirdparty ...
Using explicit plugin resolve order [default, core] ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\html
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\plain

Starting integration test phase ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes

-------------------------------------------------------
Running 1 integration test...
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Tests Completed in 1000ms ...
-------------------------------------------------------
Tests passed: 1
Tests failed: 1
-------------------------------------------------------
[junitreport] Processing F:\workspaces\test\grails12RC1-test2\target\test-reports\TESTS-TestSuites.xml to C:\DOKUME~1\hdenk\LOKALE~1\Temp\null513622173
[junitreport] Loading stylesheet jar:file:/C:/Dokumente%20und%20Einstellungen/hdenk/.ivy2/cache/org.apache.ant/ant-junit/jars/ant-junit-1.7.1.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 1766ms
[junitreport] Deleting: C:\DOKUME~1\hdenk\LOKALE~1\Temp\null513622173

Tests FAILED - view reports in target\test-reports
Application context shutting down...
Application context shutdown.

3 = not ok

>grails test-app integration: com.mycompany.myapp.Dummy

Welcome to Grails 1.2.0.RC1 - http://grails.org/
Licensed under Apache Standard License 2.0
Grails home is set to: c:\tools\grails\grails-1.2.RC1

Base Directory: F:\workspaces\test\grails12RC1-test2
Resolving dependencies...
Dependencies resolved in 1219ms.
Running script c:\tools\grails\grails-1.2.RC1\scripts\TestApp.groovy
Environment set to test
No authentication for svn repo at snapshot ...
No authentication for svn repo at released ...
No authentication for svn repo at thirdparty ...
Using explicit plugin resolve order [default, core] ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\html
    [mkdir] Created dir: F:\workspaces\test\grails12RC1-test2\target\test-reports\plain

Starting integration test phase ...
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes
  [groovyc] Compiling 1 source file to F:\workspaces\test\grails12RC1-test2\target\classes

-------------------------------------------------------
Running 2 integration tests...
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Running test com.mycompany.myapp.DummyTests...
                    testShouldFail...FAILED
Tests Completed in 1188ms ...
-------------------------------------------------------
Tests passed: 2
Tests failed: 2
-------------------------------------------------------
[junitreport] Processing F:\workspaces\test\grails12RC1-test2\target\test-reports\TESTS-TestSuites.xml to C:\DOKUME~1\hdenk\LOKALE~1\Temp\null1251350568
[junitreport] Loading stylesheet jar:file:/C:/Dokumente%20und%20Einstellungen/hdenk/.ivy2/cache/org.apache.ant/ant-junit/jars/ant-junit-1.7.1.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 1547ms
[junitreport] Deleting: C:\DOKUME~1\hdenk\LOKALE~1\Temp\null1251350568

Tests FAILED - view reports in target\test-reports
Application context shutting down...
Application context shutdown.

Hide

Permalink

Luke Daley added a comment - 08/Dec/09 7:37 PM

Behaviour is no longer exhibited with HEAD.

Please verify that this has been fixed when RC2 is released over the coming days.

Show

Luke Daley added a comment - 08/Dec/09 7:37 PM Behaviour is no longer exhibited with HEAD. Please verify that this has been fixed when RC2 is released over the coming days.

Hide

Permalink

Helmut Denk added a comment - 17/Dec/09 5:17 AM

i checked it against RC2 and
test-app works as expected now.

Show

Helmut Denk added a comment - 17/Dec/09 5:17 AM i checked it against RC2 and test-app works as expected now.

Hide

Permalink

Graeme Rocher added a comment - 18/May/11 8:43 AM

Bulk closing bunch of resolved issues

Show

Graeme Rocher added a comment - 18/May/11 8:43 AM Bulk closing bunch of resolved issues

People

Assignee:

Luke Daley

Reporter:

Helmut Denk

Vote (0)

Watch (1)

Dates

Created:

05/Dec/09 2:49 PM

Updated:

18/May/11 8:43 AM

Resolved:

08/Dec/09 7:37 PM