Grails

JNDI code for tomcat plugin possibly incomplete or needs better documentation

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.2-RC1
  • Fix Version/s: 1.2.2, 1.3-RC1
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

Adding

def ds = new org.apache.commons.dbcp.BasicDataSource(
driverClassName:'org.hsqldb.jdbcDriver',
url:'jdbc:hsqldb:mem:testDb',
username:'sa',
password:'')
grails.naming.entries = ['jdbc/myDataSource':ds]

to Config.groovy and accordingly changing DataSource.groovy to

dataSource

{ pooled = false dbCreate = "create-drop" // one of 'create', 'create-drop','update' jndiName = "java:comp/env/jdbc/myDataSource" }

leads to the following output:

Running Grails application..
loading security config ...
Cannot create JDBC driver of class '' for connect URL 'null'
java.sql.SQLException: No suitable driver
at java.sql.DriverManager.getDriver(DriverManager.java:279)
at org.apache.tomcat.dbcp.dbcp.BasicDataSource.createDataSource(BasicDataSource.java:1143)
at org.apache.tomcat.dbcp.dbcp.BasicDataSource.getConnection(BasicDataSource.java:880)
at org.springframework.jdbc.datasource.DataSourceUtils.doGetConnection(DataSourceUtils.java:113)
at org.springframework.jdbc.datasource.DataSourceUtils.getConnection(DataSourceUtils.java:79)
at org.springframework.jdbc.support.JdbcUtils.extractDatabaseMetaData(JdbcUtils.java:280)
at org.springframework.jdbc.support.JdbcUtils.extractDatabaseMetaData(JdbcUtils.java:320)
at org.codehaus.groovy.grails.orm.hibernate.support.HibernateDialectDetectorFactoryBean.afterPropertiesSet(HibernateDialectDetectorFactoryBean.java:77)
[... and so on ...]

Looking at the tomcat plugin, I noticed, that grails.naming.entries is only used for picking up the basic name and type for the ContextResource instance. Where does the specific configuration get set, e.g. driverClassName and url?

My attached patch modifies the tomcat plugin to explicitly search for a list of properties that appear to be common for BasicDataSource configurations. Those properties are then copied over to the ContextResource instance.

The approach works for me, but it might not be correct or complete. I'm especially unsure whether the approach is generic enough...

  1. Text File
    fix_tomcat_jndi.patch
    23/Mar/10 6:42 AM
    2 kB
    Jason Royals
  2. Text File
    tomcat-jndi.patch
    09/Dec/09 5:29 PM
    0.9 kB
    Fabian Knittel

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jason Royals added a comment -

I ran into this as well. Our style of development means we expect Tomcat to provide resources when running in-container, whether it's dev or not. Unfortunately the code in the current plugin doesn't seem to work.

I needed something a little more generic than the patch supplied, so have provided one that can define one or many arbitrary resources to be configured, not just DataSources. Seems to work OK for me. Patch attached (fix_tomcat_jndi.patch).

To use it, in Config.groovy you can do something like this to replicate the Tomcat 5.5 examples at http://tomcat.apache.org/tomcat-5.5-doc/jndi-resources-howto.html:

grails.naming.entries = [
    "bean/MyBeanFactory": [
        auth: "Container",
        type: "com.mycompany.MyBean",
        factory: "org.apache.naming.factory.BeanFactory",
        bar: "23"
    ],
    "jdbc/EmployeeDB": [
        type: "javax.sql.DataSource", //required
        auth: "Container", // optional
        description: "Data source for Foo", //optional
        driverClassName: "org.hsql.jdbcDriver",
        url: "jdbc:HypersonicSQL:database",
        username: "dbusername",
        password: "dbpassword",
        maxActive: "8",
        maxIdle: "4"
    ],
    "mail/session": [
        type: "javax.mail.Session,
        auth: "Container",
        "mail.smtp.host": "localhost"
    ]
]

Hope this is useful

Show
Jason Royals added a comment - I ran into this as well. Our style of development means we expect Tomcat to provide resources when running in-container, whether it's dev or not. Unfortunately the code in the current plugin doesn't seem to work. I needed something a little more generic than the patch supplied, so have provided one that can define one or many arbitrary resources to be configured, not just DataSources. Seems to work OK for me. Patch attached (fix_tomcat_jndi.patch). To use it, in Config.groovy you can do something like this to replicate the Tomcat 5.5 examples at http://tomcat.apache.org/tomcat-5.5-doc/jndi-resources-howto.html: grails.naming.entries = [ "bean/MyBeanFactory" : [ auth: "Container" , type: "com.mycompany.MyBean" , factory: "org.apache.naming.factory.BeanFactory" , bar: "23" ], "jdbc/EmployeeDB" : [ type: "javax.sql.DataSource" , //required auth: "Container" , // optional description: "Data source for Foo" , //optional driverClassName: "org.hsql.jdbcDriver" , url: "jdbc:HypersonicSQL:database" , username: "dbusername" , password: "dbpassword" , maxActive: "8" , maxIdle: "4" ], "mail/session" : [ type: "javax.mail.Session, auth: "Container" , "mail.smtp.host" : "localhost" ] ] Hope this is useful
Hide
Permalink
Graeme Rocher added a comment -

Very useful, thanks will apply...

Show
Graeme Rocher added a comment - Very useful, thanks will apply...
Hide
Permalink
Graeme Rocher added a comment -

Fixed 1.3.x: http://github.com/grails-plugins/grails-tomcat-plugin/commit/abe389954bfb1fc15cb8b98826440060cbb27ce8
Fixed 1.2.x: http://github.com/grails-plugins/grails-tomcat-plugin/commit/8b4bdc796ad37984cb8fbf98697fbd54ada98ff7

Docs: http://github.com/grails/grails-doc/commit/90be8f55f9112f241892ca1e42f1c27e768a9bf3

Thanks for the patch.

Show
Graeme Rocher added a comment - Fixed 1.3.x: http://github.com/grails-plugins/grails-tomcat-plugin/commit/abe389954bfb1fc15cb8b98826440060cbb27ce8 Fixed 1.2.x: http://github.com/grails-plugins/grails-tomcat-plugin/commit/8b4bdc796ad37984cb8fbf98697fbd54ada98ff7 Docs: http://github.com/grails/grails-doc/commit/90be8f55f9112f241892ca1e42f1c27e768a9bf3 Thanks for the patch.
Hide
Permalink
Sudhakar Rayavaram added a comment -

There seems to be a problem with the submitted patch. It is removing the attributes from the grails.naming.entries when server started. Because of this, dynamic restart on files change is failing with exception "Must supply a resource type for JNDI configuration"

Ideally the code should be doing 

 resCfg["type"] instead of resCfg.remove("type")

for all the four parameters (type, auth, description, scope)

Please let me know if this needs to be raised as a separate bug.

Show
Sudhakar Rayavaram added a comment - There seems to be a problem with the submitted patch. It is removing the attributes from the grails.naming.entries when server started. Because of this, dynamic restart on files change is failing with exception "Must supply a resource type for JNDI configuration" Ideally the code should be doing resCfg["type"] instead of resCfg.remove("type") for all the four parameters (type, auth, description, scope) Please let me know if this needs to be raised as a separate bug.

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Fabian Knittel
Vote (3)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: