Grails
  1. Grails
  2. GRAILS-6007

Inline plugins do not include i18n messages.properties as expected

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.2 final
    • Fix Version/s: 2.1.5, 2.2.2, 2.3-M1
    • Component/s: Plugins
    • Labels:
      None
    • Testcase included:
      yes

      Description

      From the Grails User List:

      On Wed, Mar 10, 2010 at 4:28 PM, <Stokes_Chris@emc.com> wrote:
      Anyone have a working example of inline plugins and message.properties
      working properly?

      When building our project's war we've noticed "proper" plugins like
      hibernate and quartz (grails install-plugin *) will deploy
      message.properties in the final war file. This syncs up with
      http://jira.codehaus.org/browse/GRAILS-1403 which has this fixed back in
      1.1.

      For our modularized "inline" plugins we've noticed a different behavior.
      The messages.properties are included in the zip produced by grails
      package-plugin but the final war does not include the file as expected.
      To get around this we've added our messages to the top level project
      that depends on the inline plugins (for now at least).

      Are we doing something wrong or is this a legitimate bug? We're on
      version 1.2 at the moment.

      Thanks,

      – Chris

      Attached a project showing the behavior. Run grails package-plugin under inlines/hasmessages plugin and then build the war from nomessagesbug/.

      1. nomessagesbug.tar.gz
        164 kB
        Christopher Stokes

        Issue Links

          Activity

          Hide
          Graeme Rocher added a comment -

          this seems to work fine in current versions of Grails

          Show
          Graeme Rocher added a comment - this seems to work fine in current versions of Grails
          Hide
          Bertrand Le Foulgoc added a comment -

          I think this is still an issue, I just tested with Grails 2.2.2, it takes a few minutes to reproduce:

          1 -Create a brand new grails project
          2 -Add 'compile ":build-info:1.2.4"' in the plugins list in BuildConfig.groovy
          3 -Run the app and go to http://localhost:8080/yourApp/buildInfo

          Content of h1 should be "Build Info" but is plugin.title, if you add this entry in the app messages.properties, you will see that it then gets picked up.

          Show
          Bertrand Le Foulgoc added a comment - I think this is still an issue, I just tested with Grails 2.2.2, it takes a few minutes to reproduce: 1 -Create a brand new grails project 2 -Add 'compile ":build-info:1.2.4"' in the plugins list in BuildConfig.groovy 3 -Run the app and go to http://localhost:8080/yourApp/buildInfo Content of h1 should be "Build Info" but is plugin.title, if you add this entry in the app messages.properties, you will see that it then gets picked up.
          Hide
          Chad Johnston added a comment -

          I'm seeing this same behavior with the Spring Security and Spring Security UI plugins. I did a little bit of testing, and the properties work fine in 2.2.0 and 2.2.1. The break happens for me only with 2.2.2.

          This is a blocker for me, preventing me from upgrading to 2.2.2.

          Show
          Chad Johnston added a comment - I'm seeing this same behavior with the Spring Security and Spring Security UI plugins. I did a little bit of testing, and the properties work fine in 2.2.0 and 2.2.1. The break happens for me only with 2.2.2. This is a blocker for me, preventing me from upgrading to 2.2.2.
          Hide
          Colin Harrington added a comment -

          I'm also experiencing this.

          Show
          Colin Harrington added a comment - I'm also experiencing this.
          Hide
          Chad Johnston added a comment -

          I don't have the right permissions to link issues, but the JIRA for Grails 2.2.2 is here: http://jira.grails.org/browse/GRAILS-10058.

          Show
          Chad Johnston added a comment - I don't have the right permissions to link issues, but the JIRA for Grails 2.2.2 is here: http://jira.grails.org/browse/GRAILS-10058 .

            People

            • Assignee:
              Stéphane Maldini
              Reporter:
              Christopher Stokes
            • Votes:
              10 Vote for this issue
              Watchers:
              17 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Last Reviewed:

                Development