Grails

Unable to display a specific view with an additional HandlerExceptionResolver

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.2.2
  • Fix Version/s: 1.2.4, 1.3.4
  • Component/s: View technologies
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

When an additional HandlerExceptionResolver process an exception and returns a model and view , the default error view is displaed instead.

This happens because, in class GrailsDispatcherServlet, the following method isn't called:
> WebUtils.clearErrorRequestAttributes(request);

This method is called in parent class DispatcherServlet, but any more in GrailsDispatcherServlet.

See the patch for further informations.

  1. Text File
    GrailsDispatcherServlet.java.patch
    26/Mar/10 10:23 PM
    1 kB
    boillod manuel

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Graeme Rocher added a comment -

It would help if you could attach an example that reproduces the issue so that I can verify the patch

Show
Graeme Rocher added a comment - It would help if you could attach an example that reproduces the issue so that I can verify the patch
Hide
Permalink
boillod manuel added a comment -

Grails Project for reproduce the bug

Show
boillod manuel added a comment - Grails Project for reproduce the bug
Hide
Permalink
boillod manuel added a comment -

With difficult, I've reproduce the bug in a simple project : TestDispatcher.zip (joined).

The bug appears only if the GSP use a sitemesh layout !

How to reproduce the bug (Grails 1.3.1)

  • Run the project
  • Go to URL : http://localhost:8080/TestDispatcher/testDispatcher/index
  • Use the link "Runtime Exception" to use default error view [OK]
  • Use the link "RedirectViewException("/illegalArgumentViewLayout")" to be redirect to specific view [OK]
  • Use the link "RedirectViewException("/illegalArgumentView")" to be redirect to specific view with layout [ERROR]

Why the bug appears only in a GSP with a layout :

Debug with a layout ->
Use decorator : GrailsNoDecorator [GrailsPageFilter.doFilter.143]
Commit the http response during flush [GrailsNoDecorator.render.44]
Because the response is committed, the status of the response is not set by the instruction :
response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR); [StandardHostValve.throwable.282]

Debug Without a layout ->
Use decorator : OldDecorator2NewDecorator : org.codehaus.groovy.grails.web.sitemesh.GrailsPageFilter$1$1 [GrailsPageFilter.doFilter.143]
The status of the response is set by the instruction :
response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR); [StandardHostValve.throwable.282]

With the patch, everything is ok.

Show
boillod manuel added a comment - With difficult, I've reproduce the bug in a simple project : TestDispatcher.zip (joined). The bug appears only if the GSP use a sitemesh layout ! How to reproduce the bug (Grails 1.3.1) Run the project Go to URL : http://localhost:8080/TestDispatcher/testDispatcher/index Use the link "Runtime Exception" to use default error view [OK] Use the link "RedirectViewException("/illegalArgumentViewLayout")" to be redirect to specific view [OK] Use the link "RedirectViewException("/illegalArgumentView")" to be redirect to specific view with layout [ERROR] Why the bug appears only in a GSP with a layout : Debug with a layout -> Use decorator : GrailsNoDecorator [GrailsPageFilter.doFilter.143] Commit the http response during flush [GrailsNoDecorator.render.44] Because the response is committed, the status of the response is not set by the instruction : response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR); [StandardHostValve.throwable.282] Debug Without a layout -> Use decorator : OldDecorator2NewDecorator : org.codehaus.groovy.grails.web.sitemesh.GrailsPageFilter$1$1 [GrailsPageFilter.doFilter.143] The status of the response is set by the instruction : response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR); [StandardHostValve.throwable.282] With the patch, everything is ok.
Hide
Permalink
Graeme Rocher added a comment -

Thanks I will try apply your patch today

Show
Graeme Rocher added a comment - Thanks I will try apply your patch today
Hide
Permalink
Graeme Rocher added a comment -

Fixed 1.3.x: http://github.com/grails/grails-core/commit/692f7afbf92caa5dbe31678e46d439ab7d1d2da9
Fixed 1.2.x: http://github.com/grails/grails-core/commit/09bd01001424627b052cc61b36ed9f6e9f4b645c

Thanks for the patch

Show
Graeme Rocher added a comment - Fixed 1.3.x: http://github.com/grails/grails-core/commit/692f7afbf92caa5dbe31678e46d439ab7d1d2da9 Fixed 1.2.x: http://github.com/grails/grails-core/commit/09bd01001424627b052cc61b36ed9f6e9f4b645c Thanks for the patch
Hide
Permalink
Graeme Rocher added a comment -

Corrected fix version

Show
Graeme Rocher added a comment - Corrected fix version

People

  • Assignee:
    Graeme Rocher
    Reporter:
    boillod manuel
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: