Details
-
Type:
Improvement
-
Status:
Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: 1.2.2
-
Fix Version/s: None
-
Component/s: Configuration
-
Labels:None
Description
Here is a typical DataSource.groovy:
dataSource {
pooled = true
driverClassName = "com.mysql.jdbc.Driver"
username = "xxx_user"
password = "123456"
dialect = 'org.hibernate.dialect.MySQL5InnoDBDialect'
loggingSql = false
}
hibernate {
cache.use_second_level_cache=false
cache.use_query_cache=false
cache.provider_class='net.sf.ehcache.hibernate.EhCacheProvider'
}
// environment specific settings
environments {
development {
dataSource
}
test {
dataSource
}
production {
dataSource
}
}
As you can see the property 'dialect', 'dbCreate' and 'loggingSql' are Hibernate related properties, but they are belonged to the 'dataSource' block, which is confusing. Those properties should belong to the 'hibernate' block. I know this is a breaking change. It would be great if you can move those properties to 'hibernate' block, and deprecated those properties in the 'dataSource' (by giving warnings when the application is starting up)
Thank you
Activity
- All
- Comments
- Work Log
- History
- Activity
- Git Commits