Grails

LocaleContextHolder is accessing wrong i18n information (Accept-Language) from a taglib in a layout

Details

Description

Using
org.springframework.context.i18n.LocaleContextHolder.getLocale()
from a taglib inside a layout will only return "Accept-Language" locale information instead of the one configured by using any of the two options below

1. org.springframework.web.servlet.support.RequestContextUtils.getLocaleResolver(request).setLocale(request, response, new Locale(lang, country));

2. resources.groovy configuration as describe in the documentation

Referenced sites:
http://stackoverflow.com/questions/1569446/grails-how-to-change-the-current-locale
http://static.springsource.org/spring/docs/2.0.x/api/org/springframework/web/servlet/LocaleResolver.html#setLocale%28javax.servlet.http.HttpServletRequest,%20javax.servlet.http.HttpServletResponse,%20java.util.Locale%29
http://tramuntanal.wikidot.com/grails#toc13

Test application provided.
(it is a 1.2.M2 version that can be upgraded to 1.2.2 and 1.3.RC1 as user needs)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Facundo Donato added a comment -

Administrators, please update "component" attribute of the issue to:
taglib AND view technologies

Show
Facundo Donato added a comment - Administrators, please update "component" attribute of the issue to: taglib AND view technologies
Hide
Permalink
Facundo Donato added a comment -

to test it, enter:
http://localhost:8080/test-i18n/pruebaI18n/index?lang=fr (or any other "lang" different from the one set on your browser preferences)

Show
Facundo Donato added a comment - to test it, enter: http://localhost:8080/test-i18n/pruebaI18n/index?lang=fr (or any other "lang" different from the one set on your browser preferences)
Hide
Permalink
Facundo Donato added a comment - - edited

Small Fix, in every method that require to have *correct* locale information

Tools.groovy
import org.springframework.context.i18n.LocaleContextolder as LCH
import org.springframework.web.servlet.support.RequestContextUtils as RCU

...

	public static synchronized Locale configurarLocaleTagLib(pageScope, request) {
	    
	    if (!pageScope.hasProperty("locale")) {
	        Locale currentLocale;
            logger.debug "SETTING pageScope.locale... to ${RCU.getLocale(request)}"
            currentLocale = RCU.getLocale(request)

            pageScope.locale = validarLocale(currentLocale);
            LCH.setLocale(pageScope.locale);
	    }
	    
	    return pageScope.locale;
	}

doing an import, like this
import org.springframework.context.i18n.LocaleContextolder as LCH
import org.springframework.web.servlet.support.RequestContextUtils as RCU

Hope this helps... we don't have a Grails fix... but a fix indeed.

Show
Facundo Donato added a comment - - edited Small Fix, in every method that require to have * correct * locale information Tools.groovy import org.springframework.context.i18n.LocaleContextolder as LCH import org.springframework.web.servlet.support.RequestContextUtils as RCU ... public static synchronized Locale configurarLocaleTagLib(pageScope, request) { if (!pageScope.hasProperty( "locale" )) { Locale currentLocale; logger.debug "SETTING pageScope.locale... to ${RCU.getLocale(request)}" currentLocale = RCU.getLocale(request) pageScope.locale = validarLocale(currentLocale); LCH.setLocale(pageScope.locale); } return pageScope.locale; } doing an import, like this import org.springframework.context.i18n.LocaleContextolder as LCH import org.springframework.web.servlet.support.RequestContextUtils as RCU Hope this helps... we don't have a Grails fix... but a fix indeed.

People

  • Assignee:
    Unassigned
    Reporter:
    Facundo Donato
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Last Reviewed: