Grails

ReleasePlugin.groovy : support using different svn repo for source than the one the plugin is being published to.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.2.2
  • Fix Version/s: 1.2.5
  • Component/s: Plugins
  • Labels:
    None
  • Environment:
    mac os 10.6, subversion 1.6.6

Description

Hello,

Our code is hosted on a subversion repository different from the one used to release the plugin

That was working fine with 1.1.1 but now fails with 1.2.2
Looking at the code, three lines were removed, in regard to bug GRAILS-5319 http://github.com/grails/grails-core/commit/c8c3771eae3ae8d586fe00259bae88e6589d4c6a

The consequence is that the code is not copied to the plugin distrib repository, but the is a "remote tagging", copying what is in the plugin distrib repository trunk as the actual release. And what is in this trunk is nothing, because the code is on the source code svn server (and on the developper machine)

I put the three missing lines back and it works (but as Luke Daley removed those lines, the problem must not be so simple)

509,512d508
< //ADDDED BY ALEX - 3 LINES
< if (new File(grailsSettings.baseDir, ".svn").exists())

{ < copyFromUrl = wcClient.doInfo(new File("."), SVNRevision.WORKING).URL < }

we had to make the modif on the ReleasePlugin.groovy on all the developpers of the team...
Any idea to solve that nicely?

Alex

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-5319 Plugin --zipOnly release fails if plugin is using different svn source.

  • Blocker - Blocks development and/or testing work, production could not run.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Luke Daley added a comment -

This is definitely going to reopen GRAILS-5319. I'll take a look and come up with a better patch.

Show
Luke Daley added a comment - This is definitely going to reopen GRAILS-5319 . I'll take a look and come up with a better patch.
Hide
Permalink
Luke Daley added a comment -

Closing this as won't fix as we are moving away from using svn for plugin repositories. Please reopen if this is a critical issue for you.

Show
Luke Daley added a comment - Closing this as won't fix as we are moving away from using svn for plugin repositories. Please reopen if this is a critical issue for you.
Hide
Permalink
Alexandre Masselot added a comment -

Hi Luke
Thanks for the answer.
We'll survive with the fix.

When you say "we are moving away from using svn for plugin repositories", how should we deploy repositories, with grails 1.3.5 if not with svn?

thanks
alex

Show
Alexandre Masselot added a comment - Hi Luke Thanks for the answer. We'll survive with the fix. When you say "we are moving away from using svn for plugin repositories", how should we deploy repositories, with grails 1.3.5 if not with svn? thanks alex
Hide
Permalink
Luke Daley added a comment -

By using m2 repositories: http://grails.org/doc/latest/guide/3.%20Configuration.html#3.7.9%20Deploying%20to%20a%20Maven%20Repository

Show
Luke Daley added a comment - By using m2 repositories: http://grails.org/doc/latest/guide/3.%20Configuration.html#3.7.9%20Deploying%20to%20a%20Maven%20Repository
Hide
Permalink
Alexandre Masselot added a comment -

thanks,
So we'll need to learn how to use maven, I guess...

Show
Alexandre Masselot added a comment - thanks, So we'll need to learn how to use maven, I guess...
Hide
Permalink
Luke Daley added a comment -

You actually don't need to learn much maven at all. Deploying only involves an m2 repo which is just a filesystem with a certain layout.

Show
Luke Daley added a comment - You actually don't need to learn much maven at all. Deploying only involves an m2 repo which is just a filesystem with a certain layout.
Hide
Permalink
Alexandre Masselot added a comment -

thank you Luke for all the help
alex

Show
Alexandre Masselot added a comment - thank you Luke for all the help alex

People

  • Assignee:
    Luke Daley
    Reporter:
    Alexandre Masselot
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: