Several plugin scripts reset files in conf folder

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Won't Fix
Affects Version/s: 1.3 RC2
Fix Version/s: 1.2.3, 1.3 final
Component/s: Plugins, Project infrastructure
Labels:
None

Description

Scripts like 'grails load-skin' of the Skin Loader plugin or 'grails install-searchable-config' overwrite changes made to Bootstrap.groovy, BuildConfig.groovy, Config.groovy, DataSource.groovy and UrlMappings.groovy resetting those files to their defaults.

I suppose this has something to do with a target these scripts depend on that as of Grails 1.3 has a somewhat different behaviour than expected. Here is the message yielded by both scripts:

Environment set to development
[copy] Copying 1 resource to GRAILS_APP_FOLDER
[unjar] Expanding: GRAILS_APP_FOLDER/grails-shared-files.jar into GRAILS_APP_FOLDER
[delete] Deleting: GRAILS_APP_FOLDER/grails-shared-files.jar
[copy] Copying 1 resource to GRAILS_APP_FOLDER
[unjar] Expanding: GRAILS_APP_FOLDER/grails-app-files.jar into GRAILS_APP_FOLDERw
[delete] Deleting: GRAILS_APP_FOLDER/grails-app-files.jar

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Graeme Rocher added a comment - 09/May/10 6:04 AM

The issue should be fixed in the plugins in question

Show

Graeme Rocher added a comment - 09/May/10 6:04 AM The issue should be fixed in the plugins in question

Hide

Permalink

Anthony Campbell added a comment - 31/May/10 9:02 AM

Could more information be provided to the changes made to 1.3? There's some documentation on the scripts area but not a lot.

Show

Anthony Campbell added a comment - 31/May/10 9:02 AM Could more information be provided to the changes made to 1.3? There's some documentation on the scripts area but not a lot.

Hide

Permalink

Anthony Campbell added a comment - 31/May/10 12:10 PM

I've had a chance to take a little look at the problem. The cause of the problem seems to be the fact that the "Init" script sets itself to be the default target. Then once all the setup has completed the script simply runs "Init" instead of load-skin etc. To fix my skin-loader script I've overriden the default target to the target called by the user and simply placed a "depends" on the Init script. Fix can be seen in skin-loader plug-in 1.0.6.

Show

Anthony Campbell added a comment - 31/May/10 12:10 PM I've had a chance to take a little look at the problem. The cause of the problem seems to be the fact that the "Init" script sets itself to be the default target. Then once all the setup has completed the script simply runs "Init" instead of load-skin etc. To fix my skin-loader script I've overriden the default target to the target called by the user and simply placed a "depends" on the Init script. Fix can be seen in skin-loader plug-in 1.0.6.

Hide

Permalink

Marcus Better added a comment - 03/Jun/10 3:48 AM

Also affects the Functional Testing plugin (GRAILSPLUGINS-2212).

Show

Marcus Better added a comment - 03/Jun/10 3:48 AM Also affects the Functional Testing plugin (GRAILSPLUGINS-2212).

Hide

Permalink

Peter Ledbrook added a comment - 30/Jun/10 8:17 AM

Anthony, the correct fix is to depend on the _GrailsInit script:

includeTargets << grailsScript("_GrailsInit")

This probably wasn't communicated clearly at the time of the 1.1 release, so sorry. You should only ever depend on the internal scripts, i.e. the ones prefixed by an underscore.

Show

Peter Ledbrook added a comment - 30/Jun/10 8:17 AM Anthony, the correct fix is to depend on the _GrailsInit script: includeTargets << grailsScript( "_GrailsInit" ) This probably wasn't communicated clearly at the time of the 1.1 release, so sorry. You should only ever depend on the internal scripts, i.e. the ones prefixed by an underscore.

Hide

Permalink

Alex McManus added a comment - 25/Aug/10 1:40 PM

I just ran into this issue with Grails 1.3.2 with my own inline plugin. The thing is, I just ran

> create-script Sample

to create the script, and it generated

includeTargets << grailsScript("Init")

target(main: "The description of the script goes here!") {
    // TODO: Implement script here
}

setDefaultTarget(main)

So, is this an error in create-script? Certainly my issue disappeared when I changed the includeTargets to "_GrailsInit").

Show

Alex McManus added a comment - 25/Aug/10 1:40 PM I just ran into this issue with Grails 1.3.2 with my own inline plugin. The thing is, I just ran > create-script Sample to create the script, and it generated includeTargets << grailsScript( "Init" ) target(main: "The description of the script goes here!" ) { // TODO: Implement script here } setDefaultTarget(main) So, is this an error in create-script? Certainly my issue disappeared when I changed the includeTargets to "_GrailsInit").

Hide

Permalink

Christian Sterzl added a comment - 14/Sep/10 6:16 AM

I changed the line in .grails\1.3.4\projects\<PROJECTNAME>\plugins\scaffold-tags-0.7.3\scripts\InstallSkin.groovy from

includeTargets << new File("${grailsHome}/scripts/Init.groovy")

includeTargets << grailsScript("_GrailsInit")

and run now into following problems:

$ grails install-skin
Welcome to Grails 1.3.4 - http://grails.org/
Licensed under Apache Standard License 2.0
Grails home is set to: C:/Program Files/springsource/grails-1.3.4

Base Directory: D:\grailsPluginTests\ScaffoldTags
Resolving dependencies...
Dependencies resolved in 1890ms.
Running script C:\Documents and Settings\cst\.grails\1.3.4\projects\ScaffoldTags\plugins\scaffold-tags-0.7.3\scripts\InstallSkin.groovy
Environment set to development
Available skins under grails-app/skins directories:
        dojo
        no-img-skin
        old
Skin name not specified. Please enter:
Error executing script InstallSkin: groovy.lang.DeprecationException: readLine() on InputStream is no longer supported. Either use a Reader or encapsulate the InputStream with a BufferedReader and an InputStreamReader.
groovy.lang.DeprecationException: readLine() on InputStream is no longer supported. Either use a Reader or encapsulate the InputStream with a BufferedReader and an InputStreamReader.
        at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:391)
        at gant.Gant$_dispatch_closure7.doCall(Gant.groovy:415)
        at gant.Gant$_dispatch_closure7.doCall(Gant.groovy)
        at gant.Gant.withBuildListeners(Gant.groovy:427)
        at gant.Gant.this$2$withBuildListeners(Gant.groovy)
        at gant.Gant$this$2$withBuildListeners.callCurrent(Unknown Source)
        at gant.Gant.dispatch(Gant.groovy:415)
        at gant.Gant.this$2$dispatch(Gant.groovy)
        at gant.Gant.invokeMethod(Gant.groovy)
        at gant.Gant.executeTargets(Gant.groovy:590)
        at gant.Gant.executeTargets(Gant.groovy:589)
Caused by: groovy.lang.DeprecationException: readLine() on InputStream is no longer supported. Either use a Reader or encapsulate the InputStream with a BufferedReader and an InputStreamReader.
        at InstallSkin$_run_closure1.doCall(InstallSkin:52)
        at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:381)
        ... 10 more
--- Nested Exception ---
groovy.lang.DeprecationException: readLine() on InputStream is no longer supported. Either use a Reader or encapsulate the InputStream with a BufferedReader and an InputStreamReader.
        at InstallSkin$_run_closure1.doCall(InstallSkin:52)
        at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:381)
        at gant.Gant$_dispatch_closure7.doCall(Gant.groovy:415)
        at gant.Gant$_dispatch_closure7.doCall(Gant.groovy)
        at gant.Gant.withBuildListeners(Gant.groovy:427)
        at gant.Gant.this$2$withBuildListeners(Gant.groovy)
        at gant.Gant$this$2$withBuildListeners.callCurrent(Unknown Source)
        at gant.Gant.dispatch(Gant.groovy:415)
        at gant.Gant.this$2$dispatch(Gant.groovy)
        at gant.Gant.invokeMethod(Gant.groovy)
        at gant.Gant.executeTargets(Gant.groovy:590)
        at gant.Gant.executeTargets(Gant.groovy:589)
Error executing script InstallSkin: groovy.lang.DeprecationException: readLine() on InputStream is no longer supported. Either use a Reader or encapsulate the InputStream with a BufferedReader and an InputStreamReader.

$ grails install-skin dojo
Welcome to Grails 1.3.4 - http://grails.org/
Licensed under Apache Standard License 2.0
Grails home is set to: C:/Program Files/springsource/grails-1.3.4

Base Directory: D:\grailsPluginTests\ScaffoldTags
Resolving dependencies...
Dependencies resolved in 1984ms.
Running script C:\Documents and Settings\cst\.grails\1.3.4\projects\ScaffoldTags\plugins\scaffold-tags-0.7.3\scripts\InstallSkin.groovy
Environment set to development
Error executing script InstallSkin: java.lang.RuntimeException: Cannot redefine symbol targets
java.lang.RuntimeException: Cannot redefine symbol targets
        at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:391)
        at gant.Gant$_dispatch_closure7.doCall(Gant.groovy:415)
        at gant.Gant$_dispatch_closure7.doCall(Gant.groovy)
        at gant.Gant.withBuildListeners(Gant.groovy:427)
        at gant.Gant.this$2$withBuildListeners(Gant.groovy)
        at gant.Gant$this$2$withBuildListeners.callCurrent(Unknown Source)
        at gant.Gant.dispatch(Gant.groovy:415)
        at gant.Gant.this$2$dispatch(Gant.groovy)
        at gant.Gant.invokeMethod(Gant.groovy)
        at gant.Gant.executeTargets(Gant.groovy:590)
        at gant.Gant.executeTargets(Gant.groovy:589)
Caused by: java.lang.RuntimeException: Cannot redefine symbol targets
        at InstallSkin$_run_closure1.doCall(InstallSkin:70)
        at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:381)
        ... 10 more
--- Nested Exception ---
java.lang.RuntimeException: Cannot redefine symbol targets
        at InstallSkin$_run_closure1.doCall(InstallSkin:70)
        at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:381)
        at gant.Gant$_dispatch_closure7.doCall(Gant.groovy:415)
        at gant.Gant$_dispatch_closure7.doCall(Gant.groovy)
        at gant.Gant.withBuildListeners(Gant.groovy:427)
        at gant.Gant.this$2$withBuildListeners(Gant.groovy)
        at gant.Gant$this$2$withBuildListeners.callCurrent(Unknown Source)
        at gant.Gant.dispatch(Gant.groovy:415)
        at gant.Gant.this$2$dispatch(Gant.groovy)
        at gant.Gant.invokeMethod(Gant.groovy)
        at gant.Gant.executeTargets(Gant.groovy:590)
        at gant.Gant.executeTargets(Gant.groovy:589)
Error executing script InstallSkin: java.lang.RuntimeException: Cannot redefine symbol targets

Show

Christian Sterzl added a comment - 14/Sep/10 6:16 AM I changed the line in .grails\1.3.4\projects\<PROJECTNAME>\plugins\scaffold-tags-0.7.3\scripts\InstallSkin.groovy from includeTargets << new File( "${grailsHome}/scripts/Init.groovy" ) to includeTargets << grailsScript( "_GrailsInit" ) and run now into following problems: $ grails install-skin Welcome to Grails 1.3.4 - http: //grails.org/ Licensed under Apache Standard License 2.0 Grails home is set to: C:/Program Files/springsource/grails-1.3.4 Base Directory: D:\grailsPluginTests\ScaffoldTags Resolving dependencies... Dependencies resolved in 1890ms. Running script C:\Documents and Settings\cst\.grails\1.3.4\projects\ScaffoldTags\plugins\scaffold-tags-0.7.3\scripts\InstallSkin.groovy Environment set to development Available skins under grails-app/skins directories: dojo no-img-skin old Skin name not specified. Please enter: Error executing script InstallSkin: groovy.lang.DeprecationException: readLine() on InputStream is no longer supported. Either use a Reader or encapsulate the InputStream with a BufferedReader and an InputStreamReader. groovy.lang.DeprecationException: readLine() on InputStream is no longer supported. Either use a Reader or encapsulate the InputStream with a BufferedReader and an InputStreamReader. at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:391) at gant.Gant$_dispatch_closure7.doCall(Gant.groovy:415) at gant.Gant$_dispatch_closure7.doCall(Gant.groovy) at gant.Gant.withBuildListeners(Gant.groovy:427) at gant.Gant. this $2$withBuildListeners(Gant.groovy) at gant.Gant$ this $2$withBuildListeners.callCurrent(Unknown Source) at gant.Gant.dispatch(Gant.groovy:415) at gant.Gant. this $2$dispatch(Gant.groovy) at gant.Gant.invokeMethod(Gant.groovy) at gant.Gant.executeTargets(Gant.groovy:590) at gant.Gant.executeTargets(Gant.groovy:589) Caused by: groovy.lang.DeprecationException: readLine() on InputStream is no longer supported. Either use a Reader or encapsulate the InputStream with a BufferedReader and an InputStreamReader. at InstallSkin$_run_closure1.doCall(InstallSkin:52) at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:381) ... 10 more --- Nested Exception --- groovy.lang.DeprecationException: readLine() on InputStream is no longer supported. Either use a Reader or encapsulate the InputStream with a BufferedReader and an InputStreamReader. at InstallSkin$_run_closure1.doCall(InstallSkin:52) at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:381) at gant.Gant$_dispatch_closure7.doCall(Gant.groovy:415) at gant.Gant$_dispatch_closure7.doCall(Gant.groovy) at gant.Gant.withBuildListeners(Gant.groovy:427) at gant.Gant. this $2$withBuildListeners(Gant.groovy) at gant.Gant$ this $2$withBuildListeners.callCurrent(Unknown Source) at gant.Gant.dispatch(Gant.groovy:415) at gant.Gant. this $2$dispatch(Gant.groovy) at gant.Gant.invokeMethod(Gant.groovy) at gant.Gant.executeTargets(Gant.groovy:590) at gant.Gant.executeTargets(Gant.groovy:589) Error executing script InstallSkin: groovy.lang.DeprecationException: readLine() on InputStream is no longer supported. Either use a Reader or encapsulate the InputStream with a BufferedReader and an InputStreamReader. $ grails install-skin dojo Welcome to Grails 1.3.4 - http: //grails.org/ Licensed under Apache Standard License 2.0 Grails home is set to: C:/Program Files/springsource/grails-1.3.4 Base Directory: D:\grailsPluginTests\ScaffoldTags Resolving dependencies... Dependencies resolved in 1984ms. Running script C:\Documents and Settings\cst\.grails\1.3.4\projects\ScaffoldTags\plugins\scaffold-tags-0.7.3\scripts\InstallSkin.groovy Environment set to development Error executing script InstallSkin: java.lang.RuntimeException: Cannot redefine symbol targets java.lang.RuntimeException: Cannot redefine symbol targets at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:391) at gant.Gant$_dispatch_closure7.doCall(Gant.groovy:415) at gant.Gant$_dispatch_closure7.doCall(Gant.groovy) at gant.Gant.withBuildListeners(Gant.groovy:427) at gant.Gant. this $2$withBuildListeners(Gant.groovy) at gant.Gant$ this $2$withBuildListeners.callCurrent(Unknown Source) at gant.Gant.dispatch(Gant.groovy:415) at gant.Gant. this $2$dispatch(Gant.groovy) at gant.Gant.invokeMethod(Gant.groovy) at gant.Gant.executeTargets(Gant.groovy:590) at gant.Gant.executeTargets(Gant.groovy:589) Caused by: java.lang.RuntimeException: Cannot redefine symbol targets at InstallSkin$_run_closure1.doCall(InstallSkin:70) at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:381) ... 10 more --- Nested Exception --- java.lang.RuntimeException: Cannot redefine symbol targets at InstallSkin$_run_closure1.doCall(InstallSkin:70) at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:381) at gant.Gant$_dispatch_closure7.doCall(Gant.groovy:415) at gant.Gant$_dispatch_closure7.doCall(Gant.groovy) at gant.Gant.withBuildListeners(Gant.groovy:427) at gant.Gant. this $2$withBuildListeners(Gant.groovy) at gant.Gant$ this $2$withBuildListeners.callCurrent(Unknown Source) at gant.Gant.dispatch(Gant.groovy:415) at gant.Gant. this $2$dispatch(Gant.groovy) at gant.Gant.invokeMethod(Gant.groovy) at gant.Gant.executeTargets(Gant.groovy:590) at gant.Gant.executeTargets(Gant.groovy:589) Error executing script InstallSkin: java.lang.RuntimeException: Cannot redefine symbol targets

Hide

Permalink

Anthony Campbell added a comment - 14/Sep/10 12:28 PM

From the exception:

Error executing script InstallSkin: java.lang.RuntimeException: Cannot redefine symbol targets

You have some core target conflicts. Most likely contributed from upgrading to the latest Grails.

Show

Anthony Campbell added a comment - 14/Sep/10 12:28 PM From the exception: Error executing script InstallSkin: java.lang.RuntimeException: Cannot redefine symbol targets You have some core target conflicts. Most likely contributed from upgrading to the latest Grails.

People

Assignee:

Unassigned

Reporter:

Björn Wilmsmann

Vote (0)

Watch (2)

Dates

Created:

08/May/10 8:42 AM

Updated:

14/Sep/10 12:28 PM

Resolved:

09/May/10 6:04 AM

Agile

View on Board