Grails

Regression: params with underscores automap differently from prior grails versions

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.3.1
  • Fix Version/s: 2.3-M2
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes

Description

If you use underscores in your form params for non-checkboxes - which is/was perfectly legal - doing so with 1.3.1 yields unexpected results as the automaps have been adapted to support nested checkboxes (GRAILS-6224) which now breaks non-checkbox usage.

I'm not sure there is a solution, but it needs flagging that this can break old apps.

See attached app.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-3299 checkBox does not work for nested boolean properties

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. GRAILS-6224 Support checkbox fields on nested command objects with Spring data binding

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Marc Palmer added a comment -

This issue has been rolled over so many times it has become sausage-shaped.

Show
Marc Palmer added a comment - This issue has been rolled over so many times it has become sausage-shaped.
Hide
Permalink
Graeme Rocher added a comment -

Patches welcome

Show
Graeme Rocher added a comment - Patches welcome
Hide
Permalink
Jeff Brown added a comment -

A pull request with a failing functional test would be helpful (even if the pull request doesn't include a fix). https://github.com/grails/grails-functional-tests/tree/master/apps/kitchen_sink_app/test/functional/parambinding might be a good place for the test.

Show
Jeff Brown added a comment - A pull request with a failing functional test would be helpful (even if the pull request doesn't include a fix). https://github.com/grails/grails-functional-tests/tree/master/apps/kitchen_sink_app/test/functional/parambinding might be a good place for the test.

People

  • Assignee:
    Unassigned
    Reporter:
    Marc Palmer
Vote (2)
Watch (6)

Dates

  • Created:
    Updated:
    Last Reviewed: