Grails

Remove redundant artifact suffixes when using the scripts "grails create-xxxxx"

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.2.4, 1.3.4
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

"grails create-service com.example.SomethingService" currently creates "SomethingServiceService.groovy" but it should have created "SomethingService.groovy".

Since the community has started to use packages consistently this has become more of an issue.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-6606 create-integration-test and create-unit-test fail with MissingPropertyException

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Colin Harrington added a comment -

The patch is directly from my github repository.

http://github.com/ColinHarrington/grails-core/commit/620dc24f1f66b3c63cd62c5fc4fefc0f8206933e
http://github.com/ColinHarrington/grails-core/commits/RemoveRedundantArtefactSuffixesSquashed

I tested my purgeRedundantArtifactSuffix closure: http://groovyconsole.appspot.com/script/143001

Show
Colin Harrington added a comment - The patch is directly from my github repository. http://github.com/ColinHarrington/grails-core/commit/620dc24f1f66b3c63cd62c5fc4fefc0f8206933e http://github.com/ColinHarrington/grails-core/commits/RemoveRedundantArtefactSuffixesSquashed I tested my purgeRedundantArtifactSuffix closure: http://groovyconsole.appspot.com/script/143001
Hide
Permalink
Colin Harrington added a comment -

This issue affects "create-service", "create-controller", "create-tag-lib", "create-filters", "create-integration-test" and "create-unit-test"

Show
Colin Harrington added a comment - This issue affects "create-service", "create-controller", "create-tag-lib", "create-filters", "create-integration-test" and "create-unit-test"
Hide
Permalink
Graeme Rocher added a comment -

Fixed 1.3.x: http://github.com/grails/grails-core/commit/7eb4da33e6bb93f3d20a11bcd395df39fe4b6e03
Fixed 1.2.x: http://github.com/grails/grails-core/commit/0cf1a0353ca17cf270d9745cd60011065b1e6526

Show
Graeme Rocher added a comment - Fixed 1.3.x: http://github.com/grails/grails-core/commit/7eb4da33e6bb93f3d20a11bcd395df39fe4b6e03 Fixed 1.2.x: http://github.com/grails/grails-core/commit/0cf1a0353ca17cf270d9745cd60011065b1e6526
Hide
Permalink
Jeff Brown added a comment -

Relevant functional test written as part of addressing GRAILS-6606:

http://github.com/grails/grails-functional-tests/commit/94fb188f0e64d6d0a0573e3d516441a5d9720c04

Show
Jeff Brown added a comment - Relevant functional test written as part of addressing GRAILS-6606 : http://github.com/grails/grails-functional-tests/commit/94fb188f0e64d6d0a0573e3d516441a5d9720c04

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Colin Harrington
Vote (3)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: