Grails

Still can't register custom exception handlers

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: 2.3-M2
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

It's not possible to register custom exception pages for GrailsExceptionResolver since exceptions are wrapped as org.codehaus.groovy.runtime.InvokerInvocationException. But if you add this at the top of GrailsExceptionResolver.resolveException():

if (e instanceof InvokerInvocationException) {
   e = (Exception)getRootCause(e);
}

then the exception mappings will use the real exception to lookup the page to use.

See this thread for discussion: http://www.nabble.com/Custom-exception-handling---GrailsExceptionResolver-generating--NullPointerException-td25206893.html

  1. File
    ExTest.tar
    22/Jun/10 4:53 AM
    670 kB
    Kevin Richards

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kevin Richards added a comment -

This is still a problem - the fix only unwraps 1 level of Grails exception wrapping. If you have a service throwing an exception you get the exception wrapped from the service, and then another wrapped exception from the Controller so to get to the actual exception that caused the problem you have to unwrap it twice.

Show
Kevin Richards added a comment - This is still a problem - the fix only unwraps 1 level of Grails exception wrapping. If you have a service throwing an exception you get the exception wrapped from the service, and then another wrapped exception from the Controller so to get to the actual exception that caused the problem you have to unwrap it twice.
Hide
Permalink
Graeme Rocher added a comment -

Please attach an example

Show
Graeme Rocher added a comment - Please attach an example
Hide
Permalink
Kevin Richards added a comment -

Project showing the problem and current workaround

Show
Kevin Richards added a comment - Project showing the problem and current workaround
Hide
Permalink
Kevin Richards added a comment -

I've attached a project which demonstrates the problem and our current workaround.

If you hit /ExTest/simple/index you will get a 'Simple' error page.

If you remove the 'exceptionHandler(CleanExceptionHandler)' from resources.groovy and add "500"(view:'/error') to the UrlMappings, you get the default grails behaviour.

There are two problems we have with the current custom exception handling

1. The previous fix to ignore InvokerInvocationException and ControllerExecutionException wrappers changed the behaviour - instead of just ignoring these exceptions the resolveException implementation in GrailsExceptionResolver returns the root cause. This means if an application exception wraps another exception the exceptionMappings don't work.
2. The second problem which is less annoying is that if you have the "500" entry in the UrlMappings the exceptionMappings get ignored.

Regards

Kevin

Show
Kevin Richards added a comment - I've attached a project which demonstrates the problem and our current workaround. If you hit /ExTest/simple/index you will get a 'Simple' error page. If you remove the 'exceptionHandler(CleanExceptionHandler)' from resources.groovy and add "500"(view:'/error') to the UrlMappings, you get the default grails behaviour. There are two problems we have with the current custom exception handling 1. The previous fix to ignore InvokerInvocationException and ControllerExecutionException wrappers changed the behaviour - instead of just ignoring these exceptions the resolveException implementation in GrailsExceptionResolver returns the root cause. This means if an application exception wraps another exception the exceptionMappings don't work. 2. The second problem which is less annoying is that if you have the "500" entry in the UrlMappings the exceptionMappings get ignored. Regards Kevin

People

  • Assignee:
    Unassigned
    Reporter:
    Kevin Richards
Vote (6)
Watch (4)

Dates

  • Created:
    Updated:
    Last Reviewed: