Grails

Automatic XML parsing fails

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.3.4
  • Fix Version/s: 1.2.4, 1.3.5
  • Component/s: Converters
  • Labels:
    None
  • Environment:
    Windows XP/Vista

Description

Automatic parsing of a POST-request with XML (application/xml) content into a domain instance fails with Grails v1.3.4. parseRequest ist properly set in UrlMappings. I've attached two sample projects (v1.3.3 and v1.3.4)
Try to do da POST request with:

Bar.xml
<?xml version='1.0' encoding='UTF-8' ?><foo><bar>test</bar></foo>

Activity

Ascending order - Click to sort in descending order
Graeme Rocher made changes -
Field Original Value New Value
Fix Version/s 1.3.5 [ 16651 ]
Hide
Permalink
Atsuya Takagi added a comment -

Any workaround?

Show
Atsuya Takagi added a comment - Any workaround?
Hide
Permalink
Robert La Ferla added a comment -

We ran into this problem as well and it's a showstopper for us.

Show
Robert La Ferla added a comment - We ran into this problem as well and it's a showstopper for us.
Burt Beckwith made changes -
Description Automatic parsing of a POST-request with XML (application/xml) content into a domain instance fails with Grails v1.3.4. parseRequest ist properly set in UrlMappings. I've attached two sample projects (v1.3.3 and v1.3.4)
Try to do da POST request with:

{code:title=Bar.xml|
<?xml version='1.0' encoding='UTF-8' ?><foo><bar>test</bar></foo>
{code} 		Automatic parsing of a POST-request with XML (application/xml) content into a domain instance fails with Grails v1.3.4. parseRequest ist properly set in UrlMappings. I've attached two sample projects (v1.3.3 and v1.3.4)
Try to do da POST request with:

{code:title=Bar.xml}
<?xml version='1.0' encoding='UTF-8' ?><foo><bar>test</bar></foo>
{code}
Burt Beckwith made changes -
Assignee Burt Beckwith [ burtbeckwith ]
Hide
Permalink
Burt Beckwith added a comment -

Peter - could you take a look at this? It looks like http://github.com/grails/grails-core/commit/3a0e57a1cd847517796d8d8deaa1524364d11849 broke XML (and JSON) parsing since the request params that are stored by XMLParsingParameterCreationListener/JSONParsingParameterCreationListener are now discarded on the forward.

Show
Burt Beckwith added a comment - Peter - could you take a look at this? It looks like http://github.com/grails/grails-core/commit/3a0e57a1cd847517796d8d8deaa1524364d11849 broke XML (and JSON) parsing since the request params that are stored by XMLParsingParameterCreationListener/JSONParsingParameterCreationListener are now discarded on the forward.
Burt Beckwith made changes -
Assignee Burt Beckwith [ burtbeckwith ] Peter Ledbrook [ pledbrook ]
Hide
Permalink
Peter Ledbrook added a comment -

That commit was reverted, so this is working in 1.2.4. It will also be in 1.3.5. I'll add a functional test to the Grails suite based on the attached project.

Show
Peter Ledbrook added a comment - That commit was reverted, so this is working in 1.2.4. It will also be in 1.3.5. I'll add a functional test to the Grails suite based on the attached project.
Peter Ledbrook made changes -
Fix Version/s 1.2.4 [ 16555 ]
Repository Branch Revision Date Author/Committer Message
Grails Functional Tests master c5b560f... 2010-09-02 05:28:24 -0700 Peter Ledbrook / Peter Ledbrook Functional tests for GRAILS-6614: automatic parsing of JSON and XML
requests not happening.
Files Changed
MODIFY apps/content-negotiation/grails-app/conf/UrlMappings.groovy
ADD apps/content-negotiation/grails-app/controllers/PostController.groovy
ADD apps/content-negotiation/grails-app/domain/Post.groovy
MODIFY apps/content-negotiation/test/functional/ContentNegotiationFunctionalTests.groovy
ADD apps/content-negotiation/test/functional/ContentParsingFunctionalTests.groovy

Repository Branch Revision Date Author/Committer Message
Grails Functional Tests 2.0.x c5b560f... 2010-09-02 05:28:24 -0700 Peter Ledbrook / Peter Ledbrook Functional tests for GRAILS-6614: automatic parsing of JSON and XML
requests not happening.
Files Changed
MODIFY apps/content-negotiation/grails-app/conf/UrlMappings.groovy
ADD apps/content-negotiation/grails-app/controllers/PostController.groovy
ADD apps/content-negotiation/grails-app/domain/Post.groovy
MODIFY apps/content-negotiation/test/functional/ContentNegotiationFunctionalTests.groovy
ADD apps/content-negotiation/test/functional/ContentParsingFunctionalTests.groovy

Repository Branch Revision Date Author/Committer Message
Grails Functional Tests 2.1.x c5b560f... 2010-09-02 05:28:24 -0700 Peter Ledbrook / Peter Ledbrook Functional tests for GRAILS-6614: automatic parsing of JSON and XML
requests not happening.
Files Changed
MODIFY apps/content-negotiation/grails-app/conf/UrlMappings.groovy
ADD apps/content-negotiation/grails-app/controllers/PostController.groovy
ADD apps/content-negotiation/grails-app/domain/Post.groovy
MODIFY apps/content-negotiation/test/functional/ContentNegotiationFunctionalTests.groovy
ADD apps/content-negotiation/test/functional/ContentParsingFunctionalTests.groovy

Repository Branch Revision Date Author/Committer Message
Grails Functional Tests 2.2.x c5b560f... 2010-09-02 05:28:24 -0700 Peter Ledbrook / Peter Ledbrook Functional tests for GRAILS-6614: automatic parsing of JSON and XML
requests not happening.
Files Changed
MODIFY apps/content-negotiation/grails-app/conf/UrlMappings.groovy
ADD apps/content-negotiation/grails-app/controllers/PostController.groovy
ADD apps/content-negotiation/grails-app/domain/Post.groovy
MODIFY apps/content-negotiation/test/functional/ContentNegotiationFunctionalTests.groovy
ADD apps/content-negotiation/test/functional/ContentParsingFunctionalTests.groovy

Repository Branch Revision Date Author/Committer Message
Grails Functional Tests 1.2.x b5033a2... 2010-09-02 05:29:13 -0700 Peter Ledbrook / Peter Ledbrook Functional tests for GRAILS-6614: automatic parsing of JSON and XML
requests not happening.
Files Changed
MODIFY apps/content-negotiation/grails-app/conf/UrlMappings.groovy
ADD apps/content-negotiation/grails-app/controllers/PostController.groovy
ADD apps/content-negotiation/grails-app/domain/Post.groovy
MODIFY apps/content-negotiation/test/functional/ContentNegotiationFunctionalTests.groovy
ADD apps/content-negotiation/test/functional/ContentParsingFunctionalTests.groovy

Hide
Permalink
Peter Ledbrook added a comment -

Added functional tests in the 1.3.x branch and the 1.2.x one.

Show
Peter Ledbrook added a comment - Added functional tests in the 1.3.x branch and the 1.2.x one .
Peter Ledbrook made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Graeme Rocher made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Contegix Support made changes -
Project Import Thu Mar 24 21:22:24 CDT 2011 [ 1301019744151 ]
Burt Beckwith made changes -
Workflow jira [ 35063 ] Grails [ 46878 ]
Burt Beckwith made changes -
Workflow Grails [ 46878 ] Copy of Grails [ 54336 ]
Burt Beckwith made changes -
Workflow Copy of Grails [ 54336 ] Grails [ 61746 ]
Burt Beckwith made changes -
Workflow Grails [ 61746 ] Grails2 [ 69327 ]
Burt Beckwith made changes -
Workflow Grails2 [ 69327 ] jira [ 76899 ]
Burt Beckwith made changes -
Workflow jira [ 76899 ] Grails2 [ 85437 ]
Peter Ledbrook made changes -
Workflow Grails2 [ 85437 ] jira [ 93835 ]
Peter Ledbrook made changes -
Workflow jira [ 93835 ] Grails2 [ 101995 ]

People

  • Assignee:
    Peter Ledbrook
    Reporter:
    Felix M.
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: