Grails

forwarding should not pass the original request parameters along, but it does

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Not A Bug
  • Affects Version/s: 1.3.4
  • Fix Version/s: 1.2.4, 1.3.5
  • Component/s: None
  • Labels:
    None

Description

See attached simple demo app.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-6669 Forward requests cannot include explicit parameters

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jeff Brown added a comment -

Fixed.

1.2.4:
http://github.com/grails/grails-core/commit/5ec493e48f91ada90c8f9d1da4980acea4a94b8c
http://github.com/grails/grails-functional-tests/commit/e486dab250c7a0615538460563561ccacdc72691

1.3.5:
http://github.com/grails/grails-core/commit/3e53c1074cee36a676885e411993a107ad364deb
http://github.com/grails/grails-functional-tests/commit/a057279d63c7513802b0441159f85b57cab2f0ec

Show
Jeff Brown added a comment - Fixed. 1.2.4: http://github.com/grails/grails-core/commit/5ec493e48f91ada90c8f9d1da4980acea4a94b8c http://github.com/grails/grails-functional-tests/commit/e486dab250c7a0615538460563561ccacdc72691 1.3.5: http://github.com/grails/grails-core/commit/3e53c1074cee36a676885e411993a107ad364deb http://github.com/grails/grails-functional-tests/commit/a057279d63c7513802b0441159f85b57cab2f0ec
Hide
Permalink
Jeff Brown added a comment -

Upon further discussion of the issue with Graeme, we decided that forwarding parameters is actually the right thing to do. we should not be removing params before issuing a redirect.

http://github.com/grails/grails-core/commit/6ebf5c0390e7a10057108dff99a9d507ae5304c9
http://github.com/grails/grails-core/commit/efecebc23103e9a813ac97eb4147bff7a03b7395
http://github.com/grails/grails-functional-tests/commit/abec44edd8ce7d7d5fa7ee070bb63ce94cb60b1c

Show
Jeff Brown added a comment - Upon further discussion of the issue with Graeme, we decided that forwarding parameters is actually the right thing to do. we should not be removing params before issuing a redirect. http://github.com/grails/grails-core/commit/6ebf5c0390e7a10057108dff99a9d507ae5304c9 http://github.com/grails/grails-core/commit/efecebc23103e9a813ac97eb4147bff7a03b7395 http://github.com/grails/grails-functional-tests/commit/abec44edd8ce7d7d5fa7ee070bb63ce94cb60b1c

People

  • Assignee:
    Jeff Brown
    Reporter:
    Jeff Brown
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: