Grails
  1. Grails
  2. GRAILS-6653

NPE in PluginFilterRetriever makes grails.plugin.excludes setting unusable with collections

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.4
    • Fix Version/s: 1.3.5
    • Component/s: Plugins
    • Labels:
      None
    • Environment:
      Grails 1.3.4, Java 1.6.0_20 (Apple) on OSX 10.6.4
    • Patch Submitted:
      Yes

      Description

      Specifying grails.plugin.excludes (or plugin.excludes) in conf/Config.groovy with a Collection value e.g.:

      grails.plugin.excludes = ['hibernate']

      causes NullPointerException in org.codehaus.groovy.grails.plugins.PluginFilterRetriever in java.util.HashSet line 51; on that line erroneously passes includes, which will be null at that point, to the constructor of java.util.HashSet.

      This was introduced back in march of 2010, so I'm unsure what other versions are affected, but 1.3.4 is.

      Attached you'll find the patch for this.

        Activity

        Hide
        Burt Beckwith added a comment -

        Please don't assign time estimates - as the form says, "Only to be filled in by the assignee before starting work"

        Show
        Burt Beckwith added a comment - Please don't assign time estimates - as the form says, "Only to be filled in by the assignee before starting work"
        Show
        Burt Beckwith added a comment - Fixed by http://github.com/grails/grails-core/commit/f333df5d0c9d6d4d18d1c92fdde9429d91ea9e85
        Hide
        Zoran Regvart added a comment -

        Sorry about the time estimate, thanks for the fix

        Show
        Zoran Regvart added a comment - Sorry about the time estimate, thanks for the fix

          People

          • Assignee:
            Burt Beckwith
            Reporter:
            Zoran Regvart
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development