Grails

run-war https with Tomcat no longer works

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.3.4
  • Fix Version/s: 1.4-M1
  • Component/s: None
  • Labels:
    None

Description

Broken by this change: http://github.com/grails-plugins/grails-tomcat-plugin/commit/3f26f4d6305353588244ee502acbe08109024f5b

The startSecure() method needs to become "war aware".

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-6129 Grails 1.3RC1 run-war does not work - shows 404 error page

  • Blocker - Blocks development and/or testing work, production could not run.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. GRAILS-5666 Run-war has some classpath conflicts

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Luke Daley made changes -
Field Original Value New Value
Link This issue relates to GRAILS-5666 [ GRAILS-5666 ]
Hide
Permalink
Luke Daley added a comment -

caused by change for GRAILS-5666

Show
Luke Daley added a comment - caused by change for GRAILS-5666
Luke Daley made changes -
Link This issue relates to GRAILS-6129 [ GRAILS-6129 ]
Hide
Permalink
Luke Daley added a comment -

caused by fix for GRAILS-6129

Show
Luke Daley added a comment - caused by fix for GRAILS-6129
Hide
Permalink
Luke Daley added a comment -

Resolved by: http://github.com/alkemist/grails-tomcat-plugin/commit/c0c8197a4aa0e5b0ae4c5652ee1a13f50a733a19

Can someone please pull this into the plugin as I don't have commit rights.

Show
Luke Daley added a comment - Resolved by: http://github.com/alkemist/grails-tomcat-plugin/commit/c0c8197a4aa0e5b0ae4c5652ee1a13f50a733a19 Can someone please pull this into the plugin as I don't have commit rights.
Luke Daley made changes -
Assignee Jeff Brown [ brownj ]
Jeff Brown made changes -
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Luke Daley added a comment -

Sorry Jeff, http://github.com/alkemist/grails-tomcat-plugin/commit/c0c8197a4aa0e5b0ae4c5652ee1a13f50a733a19 fixes GRAILS-6689 and not this issue. I commented on the wrong issue.

Show
Luke Daley added a comment - Sorry Jeff, http://github.com/alkemist/grails-tomcat-plugin/commit/c0c8197a4aa0e5b0ae4c5652ee1a13f50a733a19 fixes GRAILS-6689 and not this issue. I commented on the wrong issue.
Hide
Permalink
Lari Hotari added a comment -

System properties specified at the command line should be passed to run-war (tomcat instance) too.

For example we are using something like this to run grails: "grails -Ddevdb.host=dbhost run-war" . This no longer works in Grails 1.3.x . Also noticed that "grails prod run-war" seems to start some other environment?

Show
Lari Hotari added a comment - System properties specified at the command line should be passed to run-war (tomcat instance) too. For example we are using something like this to run grails: "grails -Ddevdb.host=dbhost run-war" . This no longer works in Grails 1.3.x . Also noticed that "grails prod run-war" seems to start some other environment?
Luke Daley made changes -
Assignee Jeff Brown [ brownj ] Luke Daley [ ldaley ]
Hide
Permalink
Luke Daley added a comment -

Got a bit trigger happy with the assign button.

Show
Luke Daley added a comment - Got a bit trigger happy with the assign button.
Luke Daley made changes -
Assignee Luke Daley [ ldaley ] Jeff Brown [ brownj ]
Jeff Brown made changes -
Fix Version/s 1.3.5 [ 16651 ]
Fix Version/s 1.3.6 [ 16730 ]
Luke Daley made changes -
Assignee Jeff Brown [ brownj ] Luke Daley [ ldaley ]
Jeff Brown made changes -
Fix Version/s 1.4-M1 [ 16812 ]
Fix Version/s 1.3.6 [ 16730 ]
Hide
Permalink
Kurt Harriger added a comment -

@LariHotari the issue with the incorrect environment is fixed in 1.3.6 per GRAILS-6842

Show
Kurt Harriger added a comment - @LariHotari the issue with the incorrect environment is fixed in 1.3.6 per GRAILS-6842
Contegix Support made changes -
Project Import Thu Mar 24 21:22:24 CDT 2011 [ 1301019744151 ]
Luke Daley made changes -
Assignee Luke Daley [ ldaley ]
Luke Daley made changes -
Assignee Luke Daley [ ldaley ]
Hide
Permalink
Luke Daley added a comment -

Version 1.3.7.1 of the Tomcat plugin brings this feature to the 1.3.x Grails line.

Show
Luke Daley added a comment - Version 1.3.7.1 of the Tomcat plugin brings this feature to the 1.3.x Grails line.
Repository Branch Revision Date Author/Committer Message
Grails Core master e9fb3b0... 2011-05-07 21:15:56 -0700 Luke Daley / Luke Daley GRAILS-6688,GRAILS-7488 - fix https with run-war for tomcat and allow user to specify keystore to use for htttps.

This brings the fixes in the 1.3.7.1 version of the tomcat plugin to 1.4.
Files Changed
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatLoader.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServerFactory.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core cli-improvements e9fb3b0... 2011-05-07 21:15:56 -0700 Luke Daley / Luke Daley GRAILS-6688,GRAILS-7488 - fix https with run-war for tomcat and allow user to specify keystore to use for htttps.

This brings the fixes in the 1.3.7.1 version of the tomcat plugin to 1.4.
Files Changed
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatLoader.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServerFactory.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.0.x e9fb3b0... 2011-05-07 21:15:56 -0700 Luke Daley / Luke Daley GRAILS-6688,GRAILS-7488 - fix https with run-war for tomcat and allow user to specify keystore to use for htttps.

This brings the fixes in the 1.3.7.1 version of the tomcat plugin to 1.4.
Files Changed
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatLoader.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServerFactory.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core hibernate4 e9fb3b0... 2011-05-07 21:15:56 -0700 Luke Daley / Luke Daley GRAILS-6688,GRAILS-7488 - fix https with run-war for tomcat and allow user to specify keystore to use for htttps.

This brings the fixes in the 1.3.7.1 version of the tomcat plugin to 1.4.
Files Changed
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatLoader.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServerFactory.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.1.x e9fb3b0... 2011-05-07 21:15:56 -0700 Luke Daley / Luke Daley GRAILS-6688,GRAILS-7488 - fix https with run-war for tomcat and allow user to specify keystore to use for htttps.

This brings the fixes in the 1.3.7.1 version of the tomcat plugin to 1.4.
Files Changed
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatLoader.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServerFactory.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x e9fb3b0... 2011-05-07 21:15:56 -0700 Luke Daley / Luke Daley GRAILS-6688,GRAILS-7488 - fix https with run-war for tomcat and allow user to specify keystore to use for htttps.

This brings the fixes in the 1.3.7.1 version of the tomcat plugin to 1.4.
Files Changed
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
ADD grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatLoader.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServerFactory.groovy

Hide
Permalink
Luke Daley added a comment -

https://github.com/grails/grails-core/commit/e9fb3b0dcede45bfbe90f1c4ab3ce5bb7ec9ede5

Show
Luke Daley added a comment - https://github.com/grails/grails-core/commit/e9fb3b0dcede45bfbe90f1c4ab3ce5bb7ec9ede5
Luke Daley made changes -
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Graeme Rocher made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Burt Beckwith made changes -
Workflow jira [ 35004 ] Grails [ 46850 ]
Burt Beckwith made changes -
Workflow Grails [ 46850 ] Copy of Grails [ 54308 ]
Burt Beckwith made changes -
Workflow Copy of Grails [ 54308 ] Grails [ 61718 ]
Burt Beckwith made changes -
Workflow Grails [ 61718 ] Grails2 [ 69299 ]
Burt Beckwith made changes -
Workflow Grails2 [ 69299 ] jira [ 78354 ]
Burt Beckwith made changes -
Workflow jira [ 78354 ] Grails2 [ 86512 ]
Peter Ledbrook made changes -
Workflow Grails2 [ 86512 ] jira [ 94877 ]
Peter Ledbrook made changes -
Workflow jira [ 94877 ] Grails2 [ 103017 ]

People

  • Assignee:
    Luke Daley
    Reporter:
    Luke Daley
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: