A value rejected during the data binding gets lost after validation

Denis Yudin added a comment - 10/Sep/10 3:20 PM attached a patch: changed org.codehaus.groovy.grails.orm.hibernate.metaclass.AbstractDynamicPersistentMethod.setupErrorsProperty(Object) to add a FieldError instead of rejecting a value

Graeme Rocher added a comment - 15/Sep/10 9:04 AM will review patch

boillod manuel added a comment - 04/Jan/12 8:47 AM Attach a simpliest test case which shows that : first call to validate() lost some attributes of binding errors second call to validate() lost all binding errors first call to validate() clear all error manually added I think that the two first cases are easy to resolve. The attached patch should be sufficient (see below). But the second is harder. However, it's easiest to live with when we know it. The fix proposed should also be applied to the same code in ValidationSupport class. Regards

boillod manuel added a comment - 02/Apr/12 11:12 AM - edited The most common way to update a domain from a controller is: bind params: def d = new Domain(params) save domain and check for errors: {{if (!d.save()) ... }} So, I think that the best solution is to keep unchanged binding errors BindingResult errors = new ValidationErrors(target); ... FieldError fe = (FieldError)o; if (fe.isBindingFailure()) { errors.addError(fe); } And if we want to remove binding errors, we can call clearErrors() , as described is documentation: http://grails.org/doc/latest/ref/Domain%20Classes/clearErrors.html What do you think about this simple patch ?

Serge P. Nekoval added a comment - 23/Oct/12 4:38 AM For those waiting for 2.3 to see this fixed, the WORKAROUND is: When you see scaffolded code like this: if (!entityInstance.save(flush: true )) { ... } prepend an additional check here: if (entityInstance.hasErrors() || !entityInstance.save(flush: true )) { ... } when you add this, save() does not get called, therefore you won't get your errors copied, and — your rejected text does not corrupted! Consider it a hack, because the code will look really weird.

boillod manuel added a comment - 23/Mar/13 9:29 AM I developed a "smarter" version which retains the binding errors after validation. Example: //bind request parameters to a new Person Person p = new Person(params) if (!Domains.save(p)){ //handle errors } Source code: Domains.java /** * Utility class for domains * * WORKAROUND for GRAILS-6710 * * @author Manuel Boillod * */ public final class Domains { private static final String ERRORS_PROPERTY = "errors" ; private static final String SAVE_METHOD = "save" ; private static final String VALIDATE_METHOD = "validate" ; /** * Save domain and merge binding errors and validation errors. * @param domain * @ return the result of call of save() method */ public static <T> T save(T domain){ return saveOrValidate(domain, SAVE_METHOD); } /** * Validate domain and merge binding errors and validation errors * @param domain * @ return the result of call of validate() method */ //TEMP GRAILS-6710 public static <T> T validate(T domain){ return saveOrValidate(domain, VALIDATE_METHOD); } /** * Save or validate method and merge errors of binding and save. * @param domain * @param saveOrValidateMethod * @ return the result of call of save() or validate() method */ private static <T> T saveOrValidate(T domain, String saveOrValidateMethod){ MetaClass mc = GroovySystem.getMetaClassRegistry().getMetaClass(domain.getClass()); Errors originalErrors = (Errors) mc.getProperty(domain, ERRORS_PROPERTY); //If domain has already errors, merge existing binding errors with new validation errors if (originalErrors.hasErrors()){ //Call save() method callSaveOrValidate(mc, domain, saveOrValidateMethod); Errors saveErrors = (Errors) mc.getProperty(domain, ERRORS_PROPERTY); //Merge errors from original and save errors BindingResult mergedErrors = new ValidationErrors(domain); //List of fields with a binding error. We don't add save error for that fields List< String > fieldsWithBindingErrors = new ArrayList< String >(); //Add binding errors from original errors for ( Object o : originalErrors.getFieldErrors()) { FieldError fe = (FieldError)o; if (fe.isBindingFailure()) { mergedErrors.addError(fe); fieldsWithBindingErrors.add(fe.getField()); } } //Add binding errors from original errors for ( Object o : saveErrors.getFieldErrors()) { FieldError fe = (FieldError)o; if (!fieldsWithBindingErrors.contains(fe.getField())) { mergedErrors.addError(fe); } } //Assign merged errors mc.setProperty(domain, ERRORS_PROPERTY, mergedErrors); //Return null to indicate errors return null ; } else { //If not yet errors, call simple save or validate return callSaveOrValidate(mc, domain, saveOrValidateMethod); } } /** * Do call "save()" or "validate" method on given domain * @param mc Domain's metaclass * @param domain Domain object * @param saveOrValidateMethod Method's name * @ return The results of method called */ private static <T> T callSaveOrValidate(MetaClass mc, T domain, String saveOrValidateMethod) { MetaMethod method = mc.getMetaMethod(saveOrValidateMethod, null ); return (T)method.invoke(domain, null ); } }

Jeff Brown added a comment - 30/Apr/13 12:35 PM This was a validation problem more than a data binding problem. https://github.com/SpringSource/grails-data-mapping/commit/4540ded5cf99a3c045b9f9310021261c389de2a7