Grails

Custom groovy Codec support broken in 1.3.5

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.3.5, 1.3.6
  • Fix Version/s: 1.4-M1
  • Component/s: None
  • Labels:
    None

Description

It appears that custom Codecs do not work in 1.3.5. Given the custom codec XmlCodec.groovy, with the default codec set to "xml", (you could also set the default codec to "base64") the app will fail. The relevant error from the stacktrace.log is given below.

2010-10-06 22:58:22,488 [http-8080-1] ERROR StackTrace - Sanitizing stacktrace:
java.lang.NullPointerException
at org.springframework.util.ReflectionUtils.makeAccessible(ReflectionUtils.java:399)
at org.codehaus.groovy.grails.web.util.CodecPrintWriter.initEncode(CodecPrintWriter.java:24)
at org.codehaus.groovy.grails.web.util.CodecPrintWriter.<init>(CodecPrintWriter.java:19)
at org.codehaus.groovy.grails.web.pages.GroovyPage.initRun(GroovyPage.java:183)
at org.codehaus.groovy.grails.web.pages.GroovyPageWritable.writeTo(GroovyPageWritable.java:186)
at org.codehaus.groovy.grails.web.servlet.view.GroovyPageView.renderWithTemplateEngine(GroovyPageView.java:146)
at org.codehaus.groovy.grails.web.servlet.view.GroovyPageView.renderMergedOutputModel(GroovyPageView.java:79)
at org.springframework.web.servlet.view.AbstractView.render(AbstractView.java:250)
at org.codehaus.groovy.grails.web.servlet.ErrorHandlingServlet$1.doFilter(ErrorHandlingServlet.java:138)
at org.codehaus.groovy.grails.web.servlet.mvc.GrailsWebRequestFilter.doFilterInternal(GrailsWebRequestFilter.java:69)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:76)
at org.codehaus.groovy.grails.web.servlet.ErrorHandlingServlet.doDispatch(ErrorHandlingServlet.java:113)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:719)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:644)
at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:549)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:646)
at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:438)
at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:374)

Issue Links

is related to

Improvement - An improvement or enhancement to an existing feature or task. GRAILS-6073 Performance penalty for people not using default codec

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jeff Brown added a comment -

I think this may have been caused by https://github.com/grails/grails-core/commit/38f1844a8a00f27e6f29c256cf610e5cb678e8fe. Will investigate and get resolved.

Show
Jeff Brown added a comment - I think this may have been caused by https://github.com/grails/grails-core/commit/38f1844a8a00f27e6f29c256cf610e5cb678e8fe . Will investigate and get resolved.
Hide
Permalink
Jeff Brown added a comment -

It looks like per the commit mentioned in the previous comment, default codecs will only work if they define an encode method, not an encode closure property. A fix is forthcoming.

Show
Jeff Brown added a comment - It looks like per the commit mentioned in the previous comment, default codecs will only work if they define an encode method, not an encode closure property. A fix is forthcoming.
Hide
Permalink
Jeff Brown added a comment -

Fixed.

https://github.com/grails/grails-core/commit/7c3153e2f5f3cbca7eeb7b838eb569773f4d925d
https://github.com/grails/grails-core/commit/6ff95dabc498657eccb1b88932668a0a893f0756

Show
Jeff Brown added a comment - Fixed. https://github.com/grails/grails-core/commit/7c3153e2f5f3cbca7eeb7b838eb569773f4d925d https://github.com/grails/grails-core/commit/6ff95dabc498657eccb1b88932668a0a893f0756
Hide
Permalink
Jeff Brown added a comment -

I believe this problem only relates to the default codec specified in Config.groovy. I think things were working as expected for explicit calls to encodeAs[Codec Name]().

Show
Jeff Brown added a comment - I believe this problem only relates to the default codec specified in Config.groovy. I think things were working as expected for explicit calls to encodeAs [Codec Name] ().

People

  • Assignee:
    Jeff Brown
    Reporter:
    Andrei Stefan
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: