Grails

Jetty plugin no longer works for functional testing

Details

  • Type: Test Test
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.3.5
  • Fix Version/s: 1.3.6, 1.4-M1
  • Component/s: Testing
  • Labels:
    None

Description

NullPointerExceptions are encountered when trying to run functional tests with the Jetty plugin.

Issue Links

relates to

Test - A new unit, integration or system test GRAILS-7033 Add end-to-end tests for functionally testing using the jetty plugin

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Antony Jones added a comment -

Could somebody with access please set the version on this to 1.3.5 - We had hoped the fix would get into 1.3.6 but it doesn't look like it will - this bug makes it impossible to run things like GEB.

Show
Antony Jones added a comment - Could somebody with access please set the version on this to 1.3.5 - We had hoped the fix would get into 1.3.6 but it doesn't look like it will - this bug makes it impossible to run things like GEB.
Hide
Permalink
Russell Wilson added a comment -

Bug report

Show
Russell Wilson added a comment - Bug report
Hide
Permalink
Russell Wilson added a comment -

Running grails test-app against the bug report will throw a NullPointerException

Show
Russell Wilson added a comment - Running grails test-app against the bug report will throw a NullPointerException
Hide
Permalink
Graeme Rocher added a comment -

Fixed 1.3.x: https://github.com/grails/grails-core/commit/5761ea8e51fb7e1f0d626cc8b24b1f45f82e561c
Fixed 1.4.x: https://github.com/grails/grails-core/commit/7a7a9b41a23639d82aeef7f2f1dcbd35d767909f

Show
Graeme Rocher added a comment - Fixed 1.3.x: https://github.com/grails/grails-core/commit/5761ea8e51fb7e1f0d626cc8b24b1f45f82e561c Fixed 1.4.x: https://github.com/grails/grails-core/commit/7a7a9b41a23639d82aeef7f2f1dcbd35d767909f
Hide
Permalink
Luke Daley added a comment -

This fixes the issue, but there are still no tests in place.

Show
Luke Daley added a comment - This fixes the issue, but there are still no tests in place.
Hide
Permalink
Luke Daley added a comment -

I've converted this issue to cover the fact that it doesn't work, and created a new issue for the creation of tests.

Show
Luke Daley added a comment - I've converted this issue to cover the fact that it doesn't work, and created a new issue for the creation of tests.
Hide
Permalink
Urs Reupke added a comment -

Luke, Graeme,

in Grails 1.3.6., I still encounter this problem.
I have a suite of tests on functional-test-1.2.7 and just switched from tomcat to jetty-1.2-SNAPSHOT (to better mirror my production environent).

Running grails test-app yields an exception identical to the one in GEB-9.
Funny enought, the same happens when I run grails test-app functional, but this time the tests are reported as passed.

java.lang.NullPointerException
        at org.grails.jetty.JettyServer.stop(JettyServer.groovy:140)
        at grails.web.container.EmbeddableServer$stop.call(Unknown Source)
        at _GrailsRun_groovy$_run_closure10.doCall(_GrailsRun_groovy:307)
        at _GrailsTest_groovy$_run_closure12.doCall(_GrailsTest_groovy:380)
        at _GrailsTest_groovy$_run_closure12.doCall(_GrailsTest_groovy)
        at _GrailsTest_groovy$_run_closure1_closure21.doCall(_GrailsTest_groovy:
190)
        at _GrailsTest_groovy$_run_closure1.doCall(_GrailsTest_groovy:174)
        at TestApp$_run_closure1.doCall(TestApp.groovy:82)
        at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:381)
        at gant.Gant$_dispatch_closure7.doCall(Gant.groovy:415)
        at gant.Gant$_dispatch_closure7.doCall(Gant.groovy)
        at gant.Gant.withBuildListeners(Gant.groovy:427)
        at gant.Gant.this$2$withBuildListeners(Gant.groovy)
        at gant.Gant$this$2$withBuildListeners.callCurrent(Unknown Source)
        at gant.Gant.dispatch(Gant.groovy:415)
        at gant.Gant.this$2$dispatch(Gant.groovy)
        at gant.Gant.invokeMethod(Gant.groovy)
        at gant.Gant.executeTargets(Gant.groovy:590)
        at gant.Gant.executeTargets(Gant.groovy:589)
Show
Urs Reupke added a comment - Luke, Graeme, in Grails 1.3.6., I still encounter this problem. I have a suite of tests on functional-test-1.2.7 and just switched from tomcat to jetty-1.2-SNAPSHOT (to better mirror my production environent). Running grails test-app yields an exception identical to the one in GEB-9. Funny enought, the same happens when I run grails test-app functional , but this time the tests are reported as passed. java.lang.NullPointerException at org.grails.jetty.JettyServer.stop(JettyServer.groovy:140) at grails.web.container.EmbeddableServer$stop.call(Unknown Source) at _GrailsRun_groovy$_run_closure10.doCall(_GrailsRun_groovy:307) at _GrailsTest_groovy$_run_closure12.doCall(_GrailsTest_groovy:380) at _GrailsTest_groovy$_run_closure12.doCall(_GrailsTest_groovy) at _GrailsTest_groovy$_run_closure1_closure21.doCall(_GrailsTest_groovy: 190) at _GrailsTest_groovy$_run_closure1.doCall(_GrailsTest_groovy:174) at TestApp$_run_closure1.doCall(TestApp.groovy:82) at gant.Gant$_dispatch_closure5.doCall(Gant.groovy:381) at gant.Gant$_dispatch_closure7.doCall(Gant.groovy:415) at gant.Gant$_dispatch_closure7.doCall(Gant.groovy) at gant.Gant.withBuildListeners(Gant.groovy:427) at gant.Gant. this $2$withBuildListeners(Gant.groovy) at gant.Gant$ this $2$withBuildListeners.callCurrent(Unknown Source) at gant.Gant.dispatch(Gant.groovy:415) at gant.Gant. this $2$dispatch(Gant.groovy) at gant.Gant.invokeMethod(Gant.groovy) at gant.Gant.executeTargets(Gant.groovy:590) at gant.Gant.executeTargets(Gant.groovy:589)

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Luke Daley
Vote (8)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: