Grails

Enable use of Tomcat Advanced IO/ NIO connector in Grails Development mode

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.3.5
  • Fix Version/s: 1.4-M1
  • Component/s: Plugins
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

This patch allows the user to select whether to use the tomcat NIO connector during grails development.
They can add an option to Config.groovy - grails.tomcat.nio = true
The Http11NioProtocol will then be used.

This allows use of the Tomcat Advanced IO features in Grails development mode.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Fletcher added a comment -

I can't seem to access the patch. Anyway FYI I'm using this in _Events.groovy and it more or less works:

import org.apache.catalina.connector.Connector;

eventConfigureTomcat = {tomcat ->
def ajpConnector = new Connector("org.apache.coyote.http11.Http11NioProtocol")
ajpConnector.port = 8009
ajpConnector.setProperty("redirectPort", "8443")
ajpConnector.setProperty("protocol", "AJP/1.3")
ajpConnector.setProperty("enableLookups", "false")

tomcat.service.addConnector ajpConnector
}

A config option instead would be great!

Show
John Fletcher added a comment - I can't seem to access the patch. Anyway FYI I'm using this in _Events.groovy and it more or less works: import org.apache.catalina.connector.Connector; eventConfigureTomcat = {tomcat -> def ajpConnector = new Connector("org.apache.coyote.http11.Http11NioProtocol") ajpConnector.port = 8009 ajpConnector.setProperty("redirectPort", "8443") ajpConnector.setProperty("protocol", "AJP/1.3") ajpConnector.setProperty("enableLookups", "false") tomcat.service.addConnector ajpConnector } A config option instead would be great!
Hide
Permalink
David Dawson added a comment -

Patch to add the option to enable the NIO connector

Show
David Dawson added a comment - Patch to add the option to enable the NIO connector
David Dawson made changes -
Field Original Value New Value
Attachment tomcatadvancedio.patch [ 52693 ]
Hide
Permalink
David Dawson added a comment -

Somehow the patch went missing when I made the issue. Ah well, attached now

Show
David Dawson added a comment - Somehow the patch went missing when I made the issue. Ah well, attached now
Hide
Permalink
John Fletcher added a comment -

Thanks a lot for this - I tried it out via your tomcatnio plugin and it works perfectly. Please can someone commit it to core!

Show
John Fletcher added a comment - Thanks a lot for this - I tried it out via your tomcatnio plugin and it works perfectly. Please can someone commit it to core!
Graeme Rocher made changes -
Fix Version/s 1.4-M1 [ 16812 ]
Priority Major [ 3 ] Blocker [ 1 ]
Contegix Support made changes -
Project Import Thu Mar 24 21:22:24 CDT 2011 [ 1301019744151 ]
Repository Branch Revision Date Author/Committer Message
Grails Core master d94c8be... 2011-05-09 08:32:33 -0700 Graeme Rocher / Graeme Rocher fix for GRAILS-7018 "Enable use of Tomcat Advanced IO/ NIO connector in Grails Development mode"
Files Changed
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core cli-improvements d94c8be... 2011-05-09 08:32:33 -0700 Graeme Rocher / Graeme Rocher fix for GRAILS-7018 "Enable use of Tomcat Advanced IO/ NIO connector in Grails Development mode"
Files Changed
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.0.x d94c8be... 2011-05-09 08:32:33 -0700 Graeme Rocher / Graeme Rocher fix for GRAILS-7018 "Enable use of Tomcat Advanced IO/ NIO connector in Grails Development mode"
Files Changed
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core hibernate4 d94c8be... 2011-05-09 08:32:33 -0700 Graeme Rocher / Graeme Rocher fix for GRAILS-7018 "Enable use of Tomcat Advanced IO/ NIO connector in Grails Development mode"
Files Changed
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.1.x d94c8be... 2011-05-09 08:32:33 -0700 Graeme Rocher / Graeme Rocher fix for GRAILS-7018 "Enable use of Tomcat Advanced IO/ NIO connector in Grails Development mode"
Files Changed
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x d94c8be... 2011-05-09 08:32:33 -0700 Graeme Rocher / Graeme Rocher fix for GRAILS-7018 "Enable use of Tomcat Advanced IO/ NIO connector in Grails Development mode"
Files Changed
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/InlineExplodedTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedTomcat.java
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/IsolatedWarTomcatServer.groovy
MODIFY grails-plugin-tomcat/src/main/groovy/org/grails/plugins/tomcat/TomcatServer.groovy

Graeme Rocher made changes -
Assignee Graeme Rocher [ graemerocher ]
Graeme Rocher made changes -
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Graeme Rocher added a comment -

Fixed. Thanks for the patch. I've extended it to also working with run-war. See the Git Commits tab for info

Show
Graeme Rocher added a comment - Fixed. Thanks for the patch. I've extended it to also working with run-war. See the Git Commits tab for info
Graeme Rocher made changes -
Status In Progress [ 3 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Burt Beckwith made changes -
Workflow jira [ 35487 ] Grails [ 41719 ]
Burt Beckwith made changes -
Workflow Grails [ 41719 ] Copy of Grails [ 49172 ]
Burt Beckwith made changes -
Workflow Copy of Grails [ 49172 ] Grails [ 56582 ]
Burt Beckwith made changes -
Workflow Grails [ 56582 ] Grails2 [ 64159 ]
Burt Beckwith made changes -
Workflow Grails2 [ 64159 ] jira [ 77946 ]
Burt Beckwith made changes -
Workflow jira [ 77946 ] Grails2 [ 86234 ]
Peter Ledbrook made changes -
Workflow Grails2 [ 86234 ] jira [ 94611 ]
Peter Ledbrook made changes -
Workflow jira [ 94611 ] Grails2 [ 102755 ]

People

  • Assignee:
    Graeme Rocher
    Reporter:
    David Dawson
Vote (3)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: