Grails

Add Build Events for Application Startup and Shutdown

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.3.6
  • Fix Version/s: 2.3-M2
  • Component/s: None
  • Labels:
    None
  • Environment:
    Linux 2.6.35-zen2 x86_64 Intel(R) Core(TM)2 Duo CPU T9500
    Java(TM) SE Runtime Environment (build 1.6.0_20-b02)

Description

There appears to be no clean way to hook into application startup or shutdown events. For application start one could hook into the ant tasks using something like the following in _Events.grovy:

eventRunAppStart = { doStartThing() }
bq. eventRunAppHttpsStart = { doStartThing() }

eventRunWarStart = { doStartThing() }
bq. eventRunWarHttpsStart = { doStartThing() }

but this method does not seem to be the cleanest of approaches.
As for server shutdown I cannot see any way of hooking into the DevelopmentShutdownHook without modifying the application.

It would be very useful if the _GrailsRun script would issue specific events (e.g. in the runServer closure) for changes in the EmbeddableServer lifecycle.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Luke Daley added a comment -

Can you please elaborate on ?but this method does not seem to be the cleanest of approaches?.

Show
Luke Daley added a comment - Can you please elaborate on ?but this method does not seem to be the cleanest of approaches?.
Hide
Permalink
Gus Power added a comment -

Hi Luke,

Sure. I'm looking to get notifications of application startup and shutdown. I perceive the method I listed to have the following drawbacks:

  • 4 closures required to catch events that are conceptually the same (i.e. application starting up)
  • no context available in these events (e.g. does not get passed the EmbeddedServer instance)
  • would not pick up new methods of running the application (e.g. runAppCustom)
  • different mechanism from other build events; relies on the gant target execution order rather than being something explicitly part of the build system mechanic
  • does not support application shutdown

As an aside the build system event mechanism seems a little loose. My preference would be to explicitly define some kind of build lifecycle contract so that integrators can have a level of assurance that events are fired consistently across differing versions of grails for key lifecycle events. There are also some inconsistencies; for example 'StatusFinal' is fired after the application starts up before a functional tests run.

Show
Gus Power added a comment - Hi Luke, Sure. I'm looking to get notifications of application startup and shutdown. I perceive the method I listed to have the following drawbacks: 4 closures required to catch events that are conceptually the same (i.e. application starting up) no context available in these events (e.g. does not get passed the EmbeddedServer instance) would not pick up new methods of running the application (e.g. runAppCustom) different mechanism from other build events; relies on the gant target execution order rather than being something explicitly part of the build system mechanic does not support application shutdown As an aside the build system event mechanism seems a little loose. My preference would be to explicitly define some kind of build lifecycle contract so that integrators can have a level of assurance that events are fired consistently across differing versions of grails for key lifecycle events. There are also some inconsistencies; for example 'StatusFinal' is fired after the application starts up before a functional tests run.
Hide
Permalink
Luke Daley added a comment -

Hi Gus,

Thanks for the extra information. All makes a lot of sense. Will get something in that covers all of this for 1.4.

Show
Luke Daley added a comment - Hi Gus, Thanks for the extra information. All makes a lot of sense. Will get something in that covers all of this for 1.4.
Hide
Permalink
Gus Power added a comment -

OK great. I'd be happy to lend a hand if it would help.

Show
Gus Power added a comment - OK great. I'd be happy to lend a hand if it would help.

People

  • Assignee:
    Unassigned
    Reporter:
    Gus Power
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Last Reviewed: