Grails

Concurrency problem in web request handling (was: Image refresh oddity)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.4-M1
  • Fix Version/s: 2.0-M1
  • Component/s: View technologies
  • Labels:
    None
  • Environment:
    Windows 7 - 64bit, Java 6 - 64 bit, Grails 1.4.0-M1, STS 2.7.0M1

Description

I have a screen with 6 PNG images on it (charts)... think of a a graphical dashboard. Now that I upgraded to 1.4.0M1 these images come up very inconsistently. If I refresh these PNG's sometimes appear in the wrong spot (ie. chart 4 will appear 3 times over other charts, in the wrong order...etc). Every time I refresh it seems to change the behavior of where the charts are appearing.

This is how I create the charts using JfreeChart:
EncoderUtil.writeBufferedImage(chart.createBufferedImage(400, 100), "png", response.getOutputStream())

This is how they are displayed:
<img width='400' height='100' src='$

{createLink(controller: 'dashboard', action: 'mail')}

?r=$

{System.currentTimeMillis()}

' />

This worked perfectly in all previous version

  1. Microsoft Word
    Firefox and IE.docx
    29/May/11 12:15 PM
    490 kB
    Henry Zaccak

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Graeme Rocher added a comment -

attach an example that reproduces the problem

Show
Graeme Rocher added a comment - attach an example that reproduces the problem
Hide
Permalink
Henry Zaccak added a comment -

Here is an STS project. Start up the app and go to the index page. Refresh it a few times and you will see chart1 shows up in chart2's spot.. etc. The charts just move around in different spots. Keep refreshing the screen and every now and then it will happen.

Show
Henry Zaccak added a comment - Here is an STS project. Start up the app and go to the index page. Refresh it a few times and you will see chart1 shows up in chart2's spot.. etc. The charts just move around in different spots. Keep refreshing the screen and every now and then it will happen.
Hide
Permalink
Henry Zaccak added a comment - - edited

You can see it here in my screenshots. It seems to happen more in firefox, but it does happen in IE as well. It's less noticeable when I take out the ?r=$

{System.currentTimeMillis()}

but it still happens without a constant behavior.

Show
Henry Zaccak added a comment - - edited You can see it here in my screenshots. It seems to happen more in firefox, but it does happen in IE as well. It's less noticeable when I take out the ?r=$ {System.currentTimeMillis()} but it still happens without a constant behavior.
Hide
Permalink
Lari Hotari added a comment -

This must be a bug in Grails. I tried the test app and added some logging to the different methods. On the browser side I could see separate requests for chart1, chart2, chart3, chart4, chart5 & chart6, but on the server side random chart* actions get executed.

Show
Lari Hotari added a comment - This must be a bug in Grails. I tried the test app and added some logging to the different methods. On the browser side I could see separate requests for chart1, chart2, chart3, chart4, chart5 & chart6, but on the server side random chart* actions get executed.
Hide
Permalink
Lari Hotari added a comment -

In Test.zip's TestController, I added a println to each action.

to chart1:
println "chart1 $

{webRequest.actionName}"
to chart2:
println "chart2 ${webRequest.actionName}

"
.
.
.

This prints out:
chart5 chart5
chart5 chart6
chart5 chart3
chart5 chart1
chart5 chart2
chart5 chart4

The webRequest.actionName is correct, but the request gets routed to the wrong action .

Show
Lari Hotari added a comment - In Test.zip's TestController, I added a println to each action. to chart1: println "chart1 $ {webRequest.actionName}" to chart2: println "chart2 ${webRequest.actionName} " . . . This prints out: chart5 chart5 chart5 chart6 chart5 chart3 chart5 chart1 chart5 chart2 chart5 chart4 The webRequest.actionName is correct, but the request gets routed to the wrong action .
Hide
Permalink
Lari Hotari added a comment -

Problem in grails-plugin-controllers/src/main/groovy/org/codehaus/groovy/grails/plugins/web/ControllersGrailsPlugin.groovy , the mainSimpleController isn't a prototype bean.

Show
Lari Hotari added a comment - Problem in grails-plugin-controllers/src/main/groovy/org/codehaus/groovy/grails/plugins/web/ControllersGrailsPlugin.groovy , the mainSimpleController isn't a prototype bean.
Hide
Permalink
Lari Hotari added a comment -

Git commit: https://github.com/grails/grails-core/commit/733ff21793372c0b9559be6e2006244647e850b4

Show
Lari Hotari added a comment - Git commit: https://github.com/grails/grails-core/commit/733ff21793372c0b9559be6e2006244647e850b4
Hide
Permalink
Lari Hotari added a comment -

Renamed the title of this issue.

Show
Lari Hotari added a comment - Renamed the title of this issue.
Hide
Permalink
Henry Zaccak added a comment -

Hi Lari, Is there a quick workaround I can use until M2 comes out?

Show
Henry Zaccak added a comment - Hi Lari, Is there a quick workaround I can use until M2 comes out?
Hide
Permalink
Graeme Rocher added a comment -

You could redefine the 'mainSimpleController' bean as prototype in resources.groovy

mainSimpleController(SimpleGrailsController) { bean ->
      grailsControllerHelper = ref('grailsControllerHelper')
      bean.scope = 'prototype'
}
Show
Graeme Rocher added a comment - You could redefine the 'mainSimpleController' bean as prototype in resources.groovy mainSimpleController(SimpleGrailsController) { bean -> grailsControllerHelper = ref('grailsControllerHelper') bean.scope = 'prototype' }
Hide
Permalink
Henry Zaccak added a comment -

Thank you!

Show
Henry Zaccak added a comment - Thank you!

People

  • Assignee:
    Lari Hotari
    Reporter:
    Henry Zaccak
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: