Grails

"No thread-bound request found" when running tests using 1.4M1

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.4-M1
  • Fix Version/s: 2.0-M1
  • Component/s: None
  • Labels:
  • Testcase included:
    yes

Description

A lot of my tests that were passing under Grails 1.3.6 now fail after upgrading to 1.4M1. The test classes in question extend either TagLibUnitTestCase or GrailsUnitTestCase. In all cases, the error message is:

java.lang.IllegalStateException: No thread-bound request found: Are you referring to request attributes outside of an actual web request, or processing a request outside of the originally receiving thread? If you are actually operating within a web request and still receive this message, your code is probably running outside of DispatcherServlet/DispatcherPortlet: In this case, use RequestContextListener or RequestContextFilter to expose the current request.
	at ie.pocketkings.web.admintool.tag.FormTagLib.partial(FormTagLib.groovy)
	at ie.pocketkings.web.admintool.tag.FormTagLib$partial.call(Unknown Source)
	at ie.pocketkings.web.admintool.tag.FormTagLibTests.testPartialForm(FormTagLibTests.groovy:39)

I've attached the class and test class corresponding to the exception above.

I realise that these abstract test classes are now deprecated in favour of mixins, but presumably they're still supposed to work? Don't hesitate to let me know if there's anything I can do to help with this issue

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Peter Ledbrook added a comment -

It appears to me there is a more fundamental issue here. I've done a little bit of investigation and it seems that the setUp() method isn't executed. Also, adding an @Before annotation to the setUp() method in FormTagLibTests results in this error:

|  Error running unit tests: groovy.lang.MissingPropertyException: No such property: children for class: org.junit.internal.runners.ErrorReportingRunner

I think it definitely warrants a further look.

Show
Peter Ledbrook added a comment - It appears to me there is a more fundamental issue here. I've done a little bit of investigation and it seems that the setUp() method isn't executed. Also, adding an @Before annotation to the setUp() method in FormTagLibTests results in this error: | Error running unit tests: groovy.lang.MissingPropertyException: No such property: children for class: org.junit.internal.runners.ErrorReportingRunner I think it definitely warrants a further look.
Hide
Permalink
Peter Ledbrook added a comment -

BTW, it also looks to me like the newInstance() implementation should be removed from TagLibUnitTestCase since MvcUnitTestCase already provides a more feature-full one (which happens to initialise the RequestContextHolder).

Show
Peter Ledbrook added a comment - BTW, it also looks to me like the newInstance() implementation should be removed from TagLibUnitTestCase since MvcUnitTestCase already provides a more feature-full one (which happens to initialise the RequestContextHolder ).
Hide
Permalink
Richard Feldman added a comment -

You get the same error if you try to test a Controller without using @TestFor (e.g. just using a vanilla class like "class SomeControllerTest"), manually instantiate a controller instance, and then have that instance invoke render(), try to access its "request" field, etc.

Show
Richard Feldman added a comment - You get the same error if you try to test a Controller without using @TestFor (e.g. just using a vanilla class like "class SomeControllerTest"), manually instantiate a controller instance, and then have that instance invoke render(), try to access its "request" field, etc.

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Donal
Vote (3)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: