Grails

GSP compilation error for valid code

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.0-M1
  • Fix Version/s: 2.0-M1
  • Component/s: View technologies
  • Labels:
    None

Description

A project with the google-visualization plugin installed won't build a war because some of the GSPs report false errors. This is a distilled version of the failing code from one:

<g:each var="formatter" in="${visualizationData.formatters}">
   var formatter = new ${formatter.object}(${formatter.options});
</g:each>

The issue appears to be the parentheses - if you remove them it works. The top of the stack trace is

org.codehaus.groovy.grails.web.taglib.exceptions.GrailsTagException: Unclosed GSP expression
        at org.codehaus.groovy.grails.web.pages.GroovyPageScanner.checkValidExpressionState(GroovyPageScanner.java:272)
        at org.codehaus.groovy.grails.web.pages.GroovyPageScanner.nextToken(GroovyPageScanner.java:238)
        at org.codehaus.groovy.grails.web.pages.GroovyPageParser.page(GroovyPageParser.java:740)
        at org.codehaus.groovy.grails.web.pages.GroovyPageParser.generateGsp(GroovyPageParser.java:340)
        at org.codehaus.groovy.grails.web.pages.GroovyPageParser.generateGsp(GroovyPageParser.java:329)

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-7180 Double closure fails in GSP

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-7741 HTML context influences brackets and braces check which leads to GSP compilation errors

  • Blocker - Blocks development and/or testing work, production could not run.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. GRAILS-7915 GSP compilation apparently broken in build #1229

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
Trackbacks

[JIRA: O2 TITAN] [OTT-732] Upgrade to Grails 2 What I have found and done some weeks ago with Grails 2 RC1. I have a local 'grails2' git branch with all the mentioned changes. * Tomcat - WARNING [OK] ** INFO > core.StandardEngine - Starting Servlet Engine: Apache Tomcat/7.0.16 ** WARN > dige...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Graeme Rocher added a comment -

Probably related to Jeff's recent parser changes

Show
Graeme Rocher added a comment - Probably related to Jeff's recent parser changes
Hide
Permalink
Jurgen Lust added a comment -

I'm having trouble with this as well, especially in pages that have some jQuery code. This gsp page for example fails to compile, due to a Unclosed GSP expression on line 4:

<script type="text/javascript">
$(document).ready(function() {
    $('#${id}').fullCalendar({
        theme: true<g:if test="${body}">,</g:if>
        ${body}
    });
});
</script>

<div id="${id}"></div>

In Grails 1.3.x, this compiled fine.

Show
Jurgen Lust added a comment - I'm having trouble with this as well, especially in pages that have some jQuery code. This gsp page for example fails to compile, due to a Unclosed GSP expression on line 4: <script type="text/javascript"> $(document).ready(function() { $('#${id}').fullCalendar({ theme: true<g:if test="${body}">,</g:if> ${body} }); }); </script> <div id="${id}"></div> In Grails 1.3.x, this compiled fine.
Hide
Permalink
Jeff Brown added a comment -

Thanks for the input Jurgen. Will get it straightened out right away.

Show
Jeff Brown added a comment - Thanks for the input Jurgen. Will get it straightened out right away.

People

  • Assignee:
    Jeff Brown
    Reporter:
    Burt Beckwith
Vote (4)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: