[#GRAILS-8001] Regression: pageScope.variables in tags is empty - Grails JIRA

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 2.0-M2
Fix Version/s: 2.0-RC1
Component/s: None
Labels:
None

Testcase included:
yes

Description

Bean-fields and hence any plugin/app that depend on it are broken by this problem.

Previously in Grails, pageScope.variables[x] would return values from the model. In 2.0m2 this is broken. The GroovyPageBinding that pageScope is, contains nothing except and empty "flash" by default.

See attached test project. Just run and browse to /

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

$i18n.getText("admin.common.words.hide")
PageScopeRegression-bug-report-08092011.zip

08/Sep/11 6:28 AM

20 kB

Marc Palmer
grails-app/conf/BootStrap.groovy 0.1 kB

grails-app/conf/BuildConfig.groovy 2 kB

grails-app/conf/Config.groovy 4 kB

grails-app/conf/DataSource.groovy 1 kB

grails-app/conf/UrlMappings.groovy 0.2 kB

grails-app/conf/spring/resources.groovy 0.0 kB

grails-app/i18n/messages.properties 3 kB

grails-app/.../messages_cs_CZ.properties 3 kB

grails-app/i18n/messages_da.properties 3 kB

grails-app/i18n/messages_de.properties 4 kB

grails-app/i18n/messages_es.properties 3 kB

grails-app/i18n/messages_fr.properties 2 kB

grails-app/i18n/messages_it.properties 2 kB

grails-app/i18n/messages_ja.properties 4 kB

grails-app/i18n/messages_nl.properties 3 kB

grails-app/.../messages_pt_BR.properties 3 kB

grails-app/.../messages_pt_PT.properties 3 kB

grails-app/i18n/messages_ru.properties 4 kB

grails-app/i18n/messages_sv.properties 3 kB

grails-app/i18n/messages_th.properties 5 kB

grails-app/.../messages_zh_CN.properties 2 kB

grails-app/taglib/.../BorkBorkTagLib.groovy 0.1 kB

grails-app/views/error.gsp 0.3 kB

grails-app/views/index.gsp 2 kB

grails-app/views/layouts/main.gsp 2 kB

test/unit/.../BorkBorkTagLibTests.groovy 0.3 kB

application.properties 0.1 kB

Download Zip
$i18n.getText("admin.common.words.show")

PageScopeRegression-bug-report-08092011.zip

08/Sep/11 6:28 AM

20 kB

Marc Palmer

Issue Links

This issue is depended upon by:
GPBEANFIELDS-40	NullPointerException on Grails 2.0.0.M2 - Cannot get property 'class' on null object

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Lari Hotari added a comment - 08/Sep/11 2:20 PM - edited

This is caused by the optimizations I made to GroovyPageBinding. The optimizations doubled the performance of the jtdev performance test.

Would it be possible make a change in bean-fields and use "pageScope.getVariable(x)" instead of "pageScope.variables[x]" ?

Show

Lari Hotari added a comment - 08/Sep/11 2:20 PM - edited This is caused by the optimizations I made to GroovyPageBinding. The optimizations doubled the performance of the jtdev performance test. Would it be possible make a change in bean-fields and use "pageScope.getVariable(x)" instead of "pageScope.variables[x]" ?

Hide

Permalink

Graeme Rocher added a comment - 08/Sep/11 3:08 PM

This is a pretty major regression and may break others things. Is there no way to make variables[x] work lazily?

Show

Graeme Rocher added a comment - 08/Sep/11 3:08 PM This is a pretty major regression and may break others things. Is there no way to make variables[x] work lazily?

Hide

Permalink

Lari Hotari added a comment - 09/Sep/11 12:30 AM

I solved this problem by implementing java.util.Map . variables[x] will call getVariable(x) under the covers.

Show

Lari Hotari added a comment - 09/Sep/11 12:30 AM I solved this problem by implementing java.util.Map . variables[x] will call getVariable(x) under the covers.

People

Assignee:

Lari Hotari

Reporter:

Marc Palmer

Vote (0)

Watch (1)

Dates

Created:

08/Sep/11 6:28 AM

Updated:

14/Sep/11 2:30 PM

Resolved:

09/Sep/11 12:30 AM