Grails

Running "grails clean" should provide a totally clean environment to run the app

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Blocker Blocker
  • Resolution: Unresolved
  • Affects Version/s: 1.3.7, 2.0-RC1
  • Fix Version/s: 2.3-M2
  • Component/s: None
  • Labels:
    None

Description

Running "grails clean" does not delete all files that affect the build of an app, and this seems counter-intuitive.

e.g. a custom BuildConfig with:

grails.project.work.dir="target/work"

Means that you cannot reliably switch between grails versions on a code base (e.g. using git local branches) as the work directory is polluted and "clean" does not clear it.

I think clean should mean clean.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Antony Jones added a comment -

Absolutely the bane of our lives, especially on our CI boxes.

grails clean should delete ~/.grails/x.x.x/projects/* as well, as the amount of times 'rm -rf'ing this directory makes our tests pass is infuriating.

Show
Antony Jones added a comment - Absolutely the bane of our lives, especially on our CI boxes. grails clean should delete ~/.grails/x.x.x/projects/* as well, as the amount of times 'rm -rf'ing this directory makes our tests pass is infuriating.
Hide
Permalink
Lloyd Jones added a comment -

In grails 2.0 We are also finding issues relating to clean before creating wars. We use eventCreateWarStart to append subversion revision to the war name during the build. Previously clean would remove the war from target so the new war is the only one present in target. Now the war is left and not overwritten (since its name is different) so we end up with multiple wars in target. Its not a major issue as we can manually remove old wars in eventCreateWarStart beforehand.

Maybe a super powerful clean-all command would allow the clean of all required directories

A more granular suggestion would be the ability to specify what is cleaned:

  • -custom : would remove folders used by custom build config
  • -war : would remove the war
  • -project : would remove project folders from the /.grails/2.0.0/projects/myRandomProject/*
Show
Lloyd Jones added a comment - In grails 2.0 We are also finding issues relating to clean before creating wars. We use eventCreateWarStart to append subversion revision to the war name during the build. Previously clean would remove the war from target so the new war is the only one present in target. Now the war is left and not overwritten (since its name is different) so we end up with multiple wars in target. Its not a major issue as we can manually remove old wars in eventCreateWarStart beforehand. Maybe a super powerful clean-all command would allow the clean of all required directories A more granular suggestion would be the ability to specify what is cleaned: -custom : would remove folders used by custom build config -war : would remove the war -project : would remove project folders from the /.grails/2.0.0/projects/myRandomProject/*
Hide
Permalink
Fred Janon added a comment -

As of 2.2.2 2013-05-27, "grails clean" still leaves a lot of .class files in target\work\plugin-classes. It takes too long to go cleanup by hand and the "grails clean" command is still the magic wand to solve some issues sometime. It would be good to know it is really cleaning up. This issue has been up since 1.3.7, is there any chance to see it fixed? Is it a major issue to fix? I am not sure why it would be so difficult to fix it, especially in Groovy.

"stacktrace.log" is also not deleted and sometimes it's quite big.

Env: 2.2.2, Win7

Show
Fred Janon added a comment - As of 2.2.2 2013-05-27, "grails clean" still leaves a lot of .class files in target\work\plugin-classes. It takes too long to go cleanup by hand and the "grails clean" command is still the magic wand to solve some issues sometime. It would be good to know it is really cleaning up. This issue has been up since 1.3.7, is there any chance to see it fixed? Is it a major issue to fix? I am not sure why it would be so difficult to fix it, especially in Groovy. "stacktrace.log" is also not deleted and sometimes it's quite big. Env: 2.2.2, Win7

People

  • Assignee:
    Unassigned
    Reporter:
    Marc Palmer
Vote (15)
Watch (11)

Dates

  • Created:
    Updated:
    Last Reviewed: