Grails

Controller AllowedMethods in unit test not working

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.0-RC3
  • Fix Version/s: None
  • Component/s: Controllers, Testing
  • Labels:
    None
  • Testcase included:
    yes

Description

In a controller I define a method that only accept http POST method.
When I want to test this behavior in a unit test, if I define a request using GET method, I have no error status in the response. Instead I get a 200.

I attach a simple project with a test doing test with both GET and POST method.

  1. File
    test.tgz
    02/Dec/11 2:53 PM
    98 kB
    Stephane Prohaszka

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. GRAILS-8434 Allowed methods are not respected in unit tests

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-8382 Error with unit testing extended controllers

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-5036 Unit testing controller with allowedMethods is not returning expected status code

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
supercedes

Bug - A problem which impairs or prevents the functions of the product. GRAILS-5036 Unit testing controller with allowedMethods is not returning expected status code

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Berenger COLLOTTE added a comment - - edited

Hi,

Do you have some news about this bug being fixed ?

I have this method in my test file (One among others):

    void testSave() {
        controller.save()
        assert response.status == HttpServletResponse.SC_METHOD_NOT_ALLOWED

        response.reset()
        request.method = 'POST'
        controller.save()

        assert model.accessibleItemInstance != null
        assert view == '/accessibleItem/create'

        response.reset()

        populateValidParams(params)
        controller.save()

        assert response.redirectedUrl == '/accessibleItem/show/1'
        assert controller.flash.message != null
        assert AccessibleItem.count() == 1
    }

I have this error when I try to test my application:

| Failure:  testSave(com.my.app.AccessibleItemControllerTests)
|  Assertion failed: 

assert response.status == HttpServletResponse.SC_METHOD_NOT_ALLOWED
       |        |      |                      |
       |        200    false                  405
       org.codehaus.groovy.grails.plugins.testing.GrailsMockHttpServletResponse@1c4fd40

	at com.my.app.AccessibleItemControllerTests.testSave(AccessibleItemControllerTests.groovy:44)

The tests fails for all Save, Delete and Updates tests.
Any news that could help to solve the problems ?

Show
Berenger COLLOTTE added a comment - - edited Hi, Do you have some news about this bug being fixed ? I have this method in my test file (One among others): void testSave() { controller.save() assert response.status == HttpServletResponse.SC_METHOD_NOT_ALLOWED response.reset() request.method = 'POST' controller.save() assert model.accessibleItemInstance != null assert view == '/accessibleItem/create' response.reset() populateValidParams(params) controller.save() assert response.redirectedUrl == '/accessibleItem/show/1' assert controller.flash.message != null assert AccessibleItem.count() == 1 } I have this error when I try to test my application: | Failure: testSave(com.my.app.AccessibleItemControllerTests) | Assertion failed: assert response.status == HttpServletResponse.SC_METHOD_NOT_ALLOWED | | | | | 200 false 405 org.codehaus.groovy.grails.plugins.testing.GrailsMockHttpServletResponse@1c4fd40 at com.my.app.AccessibleItemControllerTests.testSave(AccessibleItemControllerTests.groovy:44) The tests fails for all Save, Delete and Updates tests. Any news that could help to solve the problems ?
Hide
Permalink
Jeff Brown added a comment -

This issue relates to the fix for GRAILS-8382. The ability to unit test allowedMethods in this way was removed with https://github.com/grails/grails-core/commit/c5c056dcd8bdb36135ed820bcb0e2d68d2d0342e. We need to take a look at this and figure out a good solution. One may be to compile time rig up the allowedMethods handling and depending on how that is implemented, the ability to do this style of unit test may come back as a result. Another option may be to get the metaprogrammed solution working again.

Show
Jeff Brown added a comment - This issue relates to the fix for GRAILS-8382 . The ability to unit test allowedMethods in this way was removed with https://github.com/grails/grails-core/commit/c5c056dcd8bdb36135ed820bcb0e2d68d2d0342e . We need to take a look at this and figure out a good solution. One may be to compile time rig up the allowedMethods handling and depending on how that is implemented, the ability to do this style of unit test may come back as a result. Another option may be to get the metaprogrammed solution working again.

People

  • Assignee:
    Jeff Brown
    Reporter:
    Stephane Prohaszka
Vote (12)
Watch (12)

Dates

  • Created:
    Updated:
    Last Reviewed: